* [Qemu-devel] [Bug 611646] [NEW] isa bus not working
@ 2010-07-30 10:26 Victor Shkamerda
2010-08-02 8:22 ` Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Victor Shkamerda @ 2010-07-30 10:26 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
isa bus emulation not working anymore.
Try running "qemu -M isapc". It will crash with segmentation fault.
This is a qemu HEAD from git on Fedora linux.
** Affects: qemu
Importance: Undecided
Status: New
--
isa bus not working
https://bugs.launchpad.net/bugs/611646
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
isa bus emulation not working anymore.
Try running "qemu -M isapc". It will crash with segmentation fault.
This is a qemu HEAD from git on Fedora linux.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working
2010-07-30 10:26 [Qemu-devel] [Bug 611646] [NEW] isa bus not working Victor Shkamerda
@ 2010-08-02 8:22 ` Markus Armbruster
2010-08-02 8:53 ` Isaku Yamahata
2010-09-12 17:03 ` [Qemu-devel] [Bug 611646] " Victor Shkamerda
2011-02-20 17:14 ` Aurelien Jarno
2 siblings, 1 reply; 6+ messages in thread
From: Markus Armbruster @ 2010-08-02 8:22 UTC (permalink / raw)
To: Bug 611646; +Cc: Isaku Yamahata, qemu-devel
Victor Shkamerda <611646@bugs.launchpad.net> writes:
> Public bug reported:
>
> isa bus emulation not working anymore.
>
> Try running "qemu -M isapc". It will crash with segmentation fault.
>
> This is a qemu HEAD from git on Fedora linux.
>
> ** Affects: qemu
> Importance: Undecided
> Status: New
git bisect points to
commit f885f1eaa8711c06033ceb1599e3750fb37c306f
Author: Isaku Yamahata <yamahata@valinux.co.jp>
Date: Fri May 14 16:29:04 2010 +0900
pc, i440fx: Make smm enable/disable function i440fx independent.
make cpu_smm_update() generic to be independent on i440fx by
registering a callback.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working
2010-08-02 8:22 ` Markus Armbruster
@ 2010-08-02 8:53 ` Isaku Yamahata
2010-08-02 11:02 ` Markus Armbruster
0 siblings, 1 reply; 6+ messages in thread
From: Isaku Yamahata @ 2010-08-02 8:53 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Bug 611646, qemu-devel
Sorry for that.
Does the attached patch fix it?
>From 20b13fa4a2c5e755346f7a91d44d23dd781a87fa Mon Sep 17 00:00:00 2001
Message-Id: <20b13fa4a2c5e755346f7a91d44d23dd781a87fa.1280738898.git.yamahata@valinux.co.jp>
In-Reply-To: <cover.1280738898.git.yamahata@valinux.co.jp>
References: <cover.1280738898.git.yamahata@valinux.co.jp>
From: Isaku Yamahata <yamahata@valinux.co.jp>
Date: Mon, 2 Aug 2010 17:47:07 +0900
Subject: [PATCH] isapc: fix segfault.
This patch fixes the following segfault introduced by
f885f1eaa8711c06033ceb1599e3750fb37c306f
i440fx_state in pc_init1() isn't initialized.
> Core was generated by `./i386-softmmu/qemu -M isapc'.
> Program terminated with signal 11, Segmentation fault.
> [New process 19686]
> at /home/yamahata/xen/iommu/qemu/git/mkpatch/qemu-isapc-fix-0/hw/piix_pci.c:136
> (gdb) where
> at /home/yamahata/xen/iommu/qemu/git/mkpatch/qemu-isapc-fix-0/hw/piix_pci.c:136
> boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> kernel_cmdline=0x6469bf "", initrd_filename=0x0,
> cpu_model=0x654d10 "486", pci_enabled=0)
> at /home/yamahata/xen/iommu/qemu/git/mkpatch/qemu-isapc-fix-0/hw/pc_piix.c:178
> boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> kernel_cmdline=0x6469bf "", initrd_filename=0x0, cpu_model=0x654d10 "486")
> at /home/yamahata/xen/iommu/qemu/git/mkpatch/qemu-isapc-fix-0/hw/pc_piix.c:207
> envp=0x7fffe1f5b188)
> at /home/yamahata/xen/iommu/qemu/git/mkpatch/qemu-isapc-fix-0/vl.c:2871
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pc_piix.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 812ddfd..634e8e6 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -69,7 +69,7 @@ static void pc_init1(ram_addr_t ram_size,
int i;
ram_addr_t below_4g_mem_size, above_4g_mem_size;
PCIBus *pci_bus;
- PCII440FXState *i440fx_state;
+ PCII440FXState *i440fx_state = NULL;
int piix3_devfn = -1;
qemu_irq *cpu_irq;
qemu_irq *isa_irq;
--
1.7.1.1
On Mon, Aug 02, 2010 at 10:22:43AM +0200, Markus Armbruster wrote:
> Victor Shkamerda <611646@bugs.launchpad.net> writes:
>
> > Public bug reported:
> >
> > isa bus emulation not working anymore.
> >
> > Try running "qemu -M isapc". It will crash with segmentation fault.
> >
> > This is a qemu HEAD from git on Fedora linux.
> >
> > ** Affects: qemu
> > Importance: Undecided
> > Status: New
>
> git bisect points to
>
> commit f885f1eaa8711c06033ceb1599e3750fb37c306f
> Author: Isaku Yamahata <yamahata@valinux.co.jp>
> Date: Fri May 14 16:29:04 2010 +0900
>
> pc, i440fx: Make smm enable/disable function i440fx independent.
>
> make cpu_smm_update() generic to be independent on i440fx by
> registering a callback.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>
--
yamahata
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working
2010-08-02 8:53 ` Isaku Yamahata
@ 2010-08-02 11:02 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2010-08-02 11:02 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: Bug 611646, qemu-devel
Isaku Yamahata <yamahata@valinux.co.jp> writes:
> Sorry for that.
> Does the attached patch fix it?
As far as I can see, yes.
I'd prefer:
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 812ddfd..34c65d5 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size,
pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, isa_irq, ram_size);
} else {
pci_bus = NULL;
+ i440fx_state = NULL;
isa_bus_new(NULL);
}
isa_bus_irqs(isa_irq);
Matter of taste, so you get to pick.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 611646] Re: isa bus not working
2010-07-30 10:26 [Qemu-devel] [Bug 611646] [NEW] isa bus not working Victor Shkamerda
2010-08-02 8:22 ` Markus Armbruster
@ 2010-09-12 17:03 ` Victor Shkamerda
2011-02-20 17:14 ` Aurelien Jarno
2 siblings, 0 replies; 6+ messages in thread
From: Victor Shkamerda @ 2010-09-12 17:03 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: New => Fix Committed
--
isa bus not working
https://bugs.launchpad.net/bugs/611646
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Fix Committed
Bug description:
isa bus emulation not working anymore.
Try running "qemu -M isapc". It will crash with segmentation fault.
This is a qemu HEAD from git on Fedora linux.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 611646] Re: isa bus not working
2010-07-30 10:26 [Qemu-devel] [Bug 611646] [NEW] isa bus not working Victor Shkamerda
2010-08-02 8:22 ` Markus Armbruster
2010-09-12 17:03 ` [Qemu-devel] [Bug 611646] " Victor Shkamerda
@ 2011-02-20 17:14 ` Aurelien Jarno
2 siblings, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2011-02-20 17:14 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/611646
Title:
isa bus not working
Status in QEMU:
Fix Released
Bug description:
isa bus emulation not working anymore.
Try running "qemu -M isapc". It will crash with segmentation fault.
This is a qemu HEAD from git on Fedora linux.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-20 17:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-30 10:26 [Qemu-devel] [Bug 611646] [NEW] isa bus not working Victor Shkamerda
2010-08-02 8:22 ` Markus Armbruster
2010-08-02 8:53 ` Isaku Yamahata
2010-08-02 11:02 ` Markus Armbruster
2010-09-12 17:03 ` [Qemu-devel] [Bug 611646] " Victor Shkamerda
2011-02-20 17:14 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.