* [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
@ 2010-09-14 7:30 Kyungmin Park
2010-09-14 23:20 ` Ben Dooks
0 siblings, 1 reply; 5+ messages in thread
From: Kyungmin Park @ 2010-09-14 7:30 UTC (permalink / raw)
To: Haavard Skinnemoen, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Wolfram Sang, Tejun Heo, Kyungmin Park, Marek Szyprowski,
linux-i2c, linux-kernel
Don't include asm/gpio.h directly. Use the linux/gpio.h.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index d9aa9a6..0c1cc37 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -15,7 +15,7 @@
#include <linux/slab.h>
#include <linux/platform_device.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
/* Toggle SDA by changing the direction of the pin */
static void i2c_gpio_setsda_dir(void *data, int state)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
2010-09-14 7:30 [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly Kyungmin Park
@ 2010-09-14 23:20 ` Ben Dooks
2010-09-15 6:35 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2010-09-14 23:20 UTC (permalink / raw)
To: Kyungmin Park
Cc: Haavard Skinnemoen, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Wolfram Sang, Tejun Heo, Kyungmin Park, Marek Szyprowski,
linux-i2c, linux-kernel
On Tue, Sep 14, 2010 at 04:30:53PM +0900, Kyungmin Park wrote:
> Don't include asm/gpio.h directly. Use the linux/gpio.h.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
will merge this, unless Jean wants to do it, at the next merge window.
> ---
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index d9aa9a6..0c1cc37 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -15,7 +15,7 @@
> #include <linux/slab.h>
> #include <linux/platform_device.h>
>
> -#include <asm/gpio.h>
> +#include <linux/gpio.h>
>
> /* Toggle SDA by changing the direction of the pin */
> static void i2c_gpio_setsda_dir(void *data, int state)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
@ 2010-09-15 6:35 ` Jean Delvare
0 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2010-09-15 6:35 UTC (permalink / raw)
To: Ben Dooks
Cc: Kyungmin Park, Haavard Skinnemoen, Wolfram Sang, Tejun Heo,
Kyungmin Park, Marek Szyprowski, linux-i2c, linux-kernel
On Wed, 15 Sep 2010 00:20:26 +0100, Ben Dooks wrote:
> On Tue, Sep 14, 2010 at 04:30:53PM +0900, Kyungmin Park wrote:
> > Don't include asm/gpio.h directly. Use the linux/gpio.h.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> will merge this, unless Jean wants to do it, at the next merge window.
Please do, i2c-gpio is mostly used on embedded systems.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
@ 2010-09-15 6:35 ` Jean Delvare
0 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2010-09-15 6:35 UTC (permalink / raw)
To: Ben Dooks
Cc: Kyungmin Park, Haavard Skinnemoen, Wolfram Sang, Tejun Heo,
Kyungmin Park, Marek Szyprowski,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wed, 15 Sep 2010 00:20:26 +0100, Ben Dooks wrote:
> On Tue, Sep 14, 2010 at 04:30:53PM +0900, Kyungmin Park wrote:
> > Don't include asm/gpio.h directly. Use the linux/gpio.h.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> will merge this, unless Jean wants to do it, at the next merge window.
Please do, i2c-gpio is mostly used on embedded systems.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
@ 2010-09-14 7:30 Kyungmin Park
0 siblings, 0 replies; 5+ messages in thread
From: Kyungmin Park @ 2010-09-14 7:30 UTC (permalink / raw)
To: Haavard Skinnemoen, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Wolfram Sang
Don't include asm/gpio.h directly. Use the linux/gpio.h.
Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index d9aa9a6..0c1cc37 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -15,7 +15,7 @@
#include <linux/slab.h>
#include <linux/platform_device.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
/* Toggle SDA by changing the direction of the pin */
static void i2c_gpio_setsda_dir(void *data, int state)
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-15 6:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-14 7:30 [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly Kyungmin Park
2010-09-14 23:20 ` Ben Dooks
2010-09-15 6:35 ` Jean Delvare
2010-09-15 6:35 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 7:30 Kyungmin Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.