* [PATCH] Bluetooth: Don't clear the blacklist when closing the HCI device
@ 2010-09-09 7:32 johan.hedberg
2010-09-15 9:49 ` Ville Tervo
0 siblings, 1 reply; 3+ messages in thread
From: johan.hedberg @ 2010-09-09 7:32 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Johan Hedberg
From: Johan Hedberg <johan.hedberg@nokia.com>
Clearing the blacklist in hci_dev_do_close() would mean that user space
needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle.
This patch removes the clearing of the blacklist in this case and
thereby saves user space from the extra work.
Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
---
net/bluetooth/hci_core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index c52f091..bc2a052 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -562,7 +562,6 @@ static int hci_dev_do_close(struct hci_dev *hdev)
hci_dev_lock_bh(hdev);
inquiry_cache_flush(hdev);
hci_conn_hash_flush(hdev);
- hci_blacklist_clear(hdev);
hci_dev_unlock_bh(hdev);
hci_notify(hdev, HCI_DEV_DOWN);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Don't clear the blacklist when closing the HCI device
2010-09-09 7:32 [PATCH] Bluetooth: Don't clear the blacklist when closing the HCI device johan.hedberg
@ 2010-09-15 9:49 ` Ville Tervo
2010-09-27 20:49 ` Gustavo F. Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Ville Tervo @ 2010-09-15 9:49 UTC (permalink / raw)
To: ext johan.hedberg@gmail.com
Cc: linux-bluetooth, Hedberg Johan (Nokia-MS/Helsinki)
On Thu, Sep 09, 2010 at 09:32:39AM +0200, ext johan.hedberg@gmail.com wrote:
> From: Johan Hedberg <johan.hedberg@nokia.com>
>
> Clearing the blacklist in hci_dev_do_close() would mean that user space
> needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle.
> This patch removes the clearing of the blacklist in this case and
> thereby saves user space from the extra work.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
Acked-by: Ville Tervo <ville.tervo@nokia.com>
> ---
> net/bluetooth/hci_core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index c52f091..bc2a052 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -562,7 +562,6 @@ static int hci_dev_do_close(struct hci_dev *hdev)
> hci_dev_lock_bh(hdev);
> inquiry_cache_flush(hdev);
> hci_conn_hash_flush(hdev);
> - hci_blacklist_clear(hdev);
> hci_dev_unlock_bh(hdev);
>
> hci_notify(hdev, HCI_DEV_DOWN);
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Don't clear the blacklist when closing the HCI device
2010-09-15 9:49 ` Ville Tervo
@ 2010-09-27 20:49 ` Gustavo F. Padovan
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo F. Padovan @ 2010-09-27 20:49 UTC (permalink / raw)
To: Ville Tervo
Cc: ext johan.hedberg@gmail.com, linux-bluetooth,
Hedberg Johan (Nokia-MS/Helsinki)
Hi Johan,
* Ville Tervo <ville.tervo@nokia.com> [2010-09-15 12:49:09 +0300]:
> On Thu, Sep 09, 2010 at 09:32:39AM +0200, ext johan.hedberg@gmail.com wrote:
> > From: Johan Hedberg <johan.hedberg@nokia.com>
> >
> > Clearing the blacklist in hci_dev_do_close() would mean that user space
> > needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle.
> > This patch removes the clearing of the blacklist in this case and
> > thereby saves user space from the extra work.
> >
> > Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
>
> Acked-by: Ville Tervo <ville.tervo@nokia.com>
Patch has been applied to my bluetooth-next-2.6 tree to later merge in
wireless-next-2.6
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-27 20:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-09 7:32 [PATCH] Bluetooth: Don't clear the blacklist when closing the HCI device johan.hedberg
2010-09-15 9:49 ` Ville Tervo
2010-09-27 20:49 ` Gustavo F. Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.