* [PATCH v2] drivers/net/eql.c: prevent reading uninitialized stack memory
@ 2010-09-15 21:43 Dan Rosenberg
2010-09-17 4:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Rosenberg @ 2010-09-15 21:43 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, security, stable
Fixed formatting (tabs and line breaks).
The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16
bytes of uninitialized stack memory, because the "master_name" member of
the master_config_t struct declared on the stack in eql_g_master_cfg()
is not altered or zeroed before being copied back to the user. This
patch takes care of it.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
--- linux-2.6.35.4.orig/drivers/net/eql.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/eql.c 2010-09-14 21:25:27.719474445 -0400
@@ -555,6 +555,8 @@ static int eql_g_master_cfg(struct net_d
equalizer_t *eql;
master_config_t mc;
+ memset(&mc, 0, sizeof(master_config_t));
+
if (eql_is_master(dev)) {
eql = netdev_priv(dev);
mc.max_slaves = eql->max_slaves;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drivers/net/eql.c: prevent reading uninitialized stack memory
2010-09-15 21:43 [PATCH v2] drivers/net/eql.c: prevent reading uninitialized stack memory Dan Rosenberg
@ 2010-09-17 4:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-17 4:55 UTC (permalink / raw)
To: drosenberg; +Cc: linux-kernel, netdev, security, stable
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Wed, 15 Sep 2010 17:43:04 -0400
> Fixed formatting (tabs and line breaks).
>
> The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16
> bytes of uninitialized stack memory, because the "master_name" member of
> the master_config_t struct declared on the stack in eql_g_master_cfg()
> is not altered or zeroed before being copied back to the user. This
> patch takes care of it.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-17 4:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-15 21:43 [PATCH v2] drivers/net/eql.c: prevent reading uninitialized stack memory Dan Rosenberg
2010-09-17 4:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.