All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1
Date: Fri, 17 Sep 2010 12:52:27 +0200	[thread overview]
Message-ID: <20100917105227.GA18090@edde.se.axis.com> (raw)
In-Reply-To: <1284411690-3557-1-git-send-email-hpoussin@reactos.org>

On Mon, Sep 13, 2010 at 11:01:30PM +0200, Hervé Poussineau wrote:
> Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them
> This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Applied, thanks.


> ---
>  slirp/ip_input.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 0fe0ff7..768ab0c 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -144,7 +144,7 @@ ip_input(struct mbuf *m)
>  	   m_adj(m, ip->ip_len - m->m_len);
>  
>  	/* check ip_ttl for a correct ICMP reply */
> -	if(ip->ip_ttl==0 || ip->ip_ttl==1) {
> +	if(ip->ip_ttl==0) {
>  	  icmp_error(m, ICMP_TIMXCEED,ICMP_TIMXCEED_INTRANS, 0,"ttl");
>  	  goto bad;
>  	}
> -- 
> 1.7.1.GIT
> 
> 

      parent reply	other threads:[~2010-09-17 11:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 21:01 [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1 Hervé Poussineau
2010-09-14 15:47 ` Edgar E. Iglesias
2010-09-17 10:52 ` Edgar E. Iglesias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100917105227.GA18090@edde.se.axis.com \
    --to=edgar.iglesias@gmail.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.