From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] mmci: work with only one irq
Date: Mon, 11 Oct 2010 10:44:04 +0100 [thread overview]
Message-ID: <20101011094404.GB27153@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1286755601-25664-1-git-send-email-rabin.vincent@stericsson.com>
On Mon, Oct 11, 2010 at 05:36:41AM +0530, Rabin Vincent wrote:
> @@ -276,6 +292,10 @@ mmci_data_irq(struct mmci_host *host, struct mmc_data *data,
> if (status & MCI_DATAEND) {
> mmci_stop_data(host);
>
> + /* MCI_DATABLOCKEND not used with single irq */
> + if (host->singleirq && !data->error)
> + host->data_xfered = data->blksz * data->blocks;
> +
I'm uneasy about this. If we don't get datablockend interrupts, then
when there's an error we don't know how much data was transferred, and
with big requests, we're going to have a very long time spent retrying
block by block.
next prev parent reply other threads:[~2010-10-11 9:44 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 9:17 [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 02/12] mmci: fix multi block transfers Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-07-29 13:18 ` Russell King - ARM Linux
2010-07-29 13:18 ` Russell King - ARM Linux
2010-07-29 13:31 ` Colin Tuckley
2010-07-29 13:36 ` Russell King - ARM Linux
2010-07-29 13:42 ` Colin Tuckley
2010-07-29 13:55 ` Russell King - ARM Linux
2010-07-29 14:14 ` Russell King - ARM Linux
2010-06-22 9:17 ` [PATCH 03/12] mmci: let core poll for card detection Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 04/12] mmci: allow the card detect status not to be inverted Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-07-29 12:34 ` Russell King - ARM Linux
2010-07-29 12:34 ` Russell King - ARM Linux
2010-07-29 13:53 ` Linus Walleij
2010-07-29 13:53 ` Linus Walleij
2010-07-29 14:20 ` Russell King - ARM Linux
2010-07-29 14:20 ` Russell King - ARM Linux
2010-08-05 6:14 ` Rabin VINCENT
2010-08-05 6:14 ` Rabin VINCENT
2010-08-05 9:25 ` Russell King - ARM Linux
2010-08-05 9:25 ` Russell King - ARM Linux
2010-08-09 10:37 ` Rabin VINCENT
2010-08-09 10:37 ` Rabin VINCENT
2010-08-09 11:25 ` Russell King - ARM Linux
2010-08-09 11:25 ` Russell King - ARM Linux
2010-06-22 9:17 ` [PATCH 05/12] mmci: support card detection interrupts Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 06/12] mmci: allow neither ->status nor gpio_cd to be specified Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 07/12] mmci: pass power_mode to the translate_vdd callback Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 22:03 ` Linus Walleij
2010-06-22 22:03 ` Linus Walleij
2010-06-24 8:27 ` Rabin VINCENT
2010-06-24 8:27 ` Rabin VINCENT
2010-06-24 8:56 ` Linus WALLEIJ
2010-06-24 8:56 ` Linus WALLEIJ
2010-07-19 12:57 ` [PATCHv2 " Rabin Vincent
2010-07-19 12:57 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 08/12] mmci: add variant data and default MCICLOCK support Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 09/12] mmci: enable hardware flow control on Ux500 variants Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 10/12] mmci: support larger MMCIDATALENGTH register Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 11/12] mmci: support different FIFO sizes Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 12/12] mmci: support variants with only one irq Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-09-23 20:04 ` Linus Walleij
2010-09-23 20:04 ` Linus Walleij
2010-10-11 0:06 ` [PATCHv2] mmci: work " Rabin Vincent
2010-10-11 9:13 ` Linus Walleij
2010-10-11 9:44 ` Russell King - ARM Linux [this message]
2010-10-11 11:10 ` Linus Walleij
2010-10-19 12:52 ` Linus Walleij
2010-07-07 20:34 ` [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Linus Walleij
2010-07-07 20:34 ` Linus Walleij
2010-07-19 13:23 ` [PATCHv2 " Rabin Vincent
2010-07-19 13:23 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011094404.GB27153@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.