From: Linus Walleij <linus.ml.walleij@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>,
Colin Tuckley <colin.tuckley@arm.com>,
linux-arm-kernel@lists.infradead.org,
STEricsson_nomadik_linux@list.st.com, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 04/12] mmci: allow the card detect status not to be inverted
Date: Thu, 29 Jul 2010 15:53:19 +0200 [thread overview]
Message-ID: <AANLkTikQi+SPpx8Wpvb0siSSsw0ZhusWaaKmqRnfHrnz@mail.gmail.com> (raw)
In-Reply-To: <20100729123443.GA18923@n2100.arm.linux.org.uk>
2010/7/29 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> What now needs to happen is the sense of the GPIOLIB support on platforms
> needs to be checked - eg, I suspect the card detect via the GPIO primecell
> is inverted on Realview - in which case we need a 'cd_invert' rather
> than the negative 'cd_noinvert'.
Doesn't seem so. I applied this patch and it works like a charm just
like before on PB1176. (PL061 is compiled in, so it's not that other
weird stuff being used.)
I hope I'm doing the right thing, boot with card inserted, this appears
in the bootlog:
mmc0: new SD card at address 80ca
mmcblk0: mmc0:80ca SU512 483 MiB
mmcblk0: p1
Remove card:
mmc0: card 80ca removed
Insert card:
mmc0: new SD card at address 80ca
mmcblk0: mmc0:80ca SU512 483 MiB
mmcblk0: p1
And so on.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mmci: allow the card detect status not to be inverted
Date: Thu, 29 Jul 2010 15:53:19 +0200 [thread overview]
Message-ID: <AANLkTikQi+SPpx8Wpvb0siSSsw0ZhusWaaKmqRnfHrnz@mail.gmail.com> (raw)
In-Reply-To: <20100729123443.GA18923@n2100.arm.linux.org.uk>
2010/7/29 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> What now needs to happen is the sense of the GPIOLIB support on platforms
> needs to be checked - eg, I suspect the card detect via the GPIO primecell
> is inverted on Realview - in which case we need a 'cd_invert' rather
> than the negative 'cd_noinvert'.
Doesn't seem so. I applied this patch and it works like a charm just
like before on PB1176. (PL061 is compiled in, so it's not that other
weird stuff being used.)
I hope I'm doing the right thing, boot with card inserted, this appears
in the bootlog:
mmc0: new SD card at address 80ca
mmcblk0: mmc0:80ca SU512 483 MiB
mmcblk0: p1
Remove card:
mmc0: card 80ca removed
Insert card:
mmc0: new SD card at address 80ca
mmcblk0: mmc0:80ca SU512 483 MiB
mmcblk0: p1
And so on.
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-07-29 13:53 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 9:17 [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 02/12] mmci: fix multi block transfers Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-07-29 13:18 ` Russell King - ARM Linux
2010-07-29 13:18 ` Russell King - ARM Linux
2010-07-29 13:31 ` Colin Tuckley
2010-07-29 13:36 ` Russell King - ARM Linux
2010-07-29 13:42 ` Colin Tuckley
2010-07-29 13:55 ` Russell King - ARM Linux
2010-07-29 14:14 ` Russell King - ARM Linux
2010-06-22 9:17 ` [PATCH 03/12] mmci: let core poll for card detection Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 04/12] mmci: allow the card detect status not to be inverted Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-07-29 12:34 ` Russell King - ARM Linux
2010-07-29 12:34 ` Russell King - ARM Linux
2010-07-29 13:53 ` Linus Walleij [this message]
2010-07-29 13:53 ` Linus Walleij
2010-07-29 14:20 ` Russell King - ARM Linux
2010-07-29 14:20 ` Russell King - ARM Linux
2010-08-05 6:14 ` Rabin VINCENT
2010-08-05 6:14 ` Rabin VINCENT
2010-08-05 9:25 ` Russell King - ARM Linux
2010-08-05 9:25 ` Russell King - ARM Linux
2010-08-09 10:37 ` Rabin VINCENT
2010-08-09 10:37 ` Rabin VINCENT
2010-08-09 11:25 ` Russell King - ARM Linux
2010-08-09 11:25 ` Russell King - ARM Linux
2010-06-22 9:17 ` [PATCH 05/12] mmci: support card detection interrupts Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 06/12] mmci: allow neither ->status nor gpio_cd to be specified Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 07/12] mmci: pass power_mode to the translate_vdd callback Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 22:03 ` Linus Walleij
2010-06-22 22:03 ` Linus Walleij
2010-06-24 8:27 ` Rabin VINCENT
2010-06-24 8:27 ` Rabin VINCENT
2010-06-24 8:56 ` Linus WALLEIJ
2010-06-24 8:56 ` Linus WALLEIJ
2010-07-19 12:57 ` [PATCHv2 " Rabin Vincent
2010-07-19 12:57 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 08/12] mmci: add variant data and default MCICLOCK support Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 09/12] mmci: enable hardware flow control on Ux500 variants Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 10/12] mmci: support larger MMCIDATALENGTH register Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 11/12] mmci: support different FIFO sizes Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-06-22 9:17 ` [PATCH 12/12] mmci: support variants with only one irq Rabin Vincent
2010-06-22 9:17 ` Rabin Vincent
2010-09-23 20:04 ` Linus Walleij
2010-09-23 20:04 ` Linus Walleij
2010-10-11 0:06 ` [PATCHv2] mmci: work " Rabin Vincent
2010-10-11 9:13 ` Linus Walleij
2010-10-11 9:44 ` Russell King - ARM Linux
2010-10-11 11:10 ` Linus Walleij
2010-10-19 12:52 ` Linus Walleij
2010-07-07 20:34 ` [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Linus Walleij
2010-07-07 20:34 ` Linus Walleij
2010-07-19 13:23 ` [PATCHv2 " Rabin Vincent
2010-07-19 13:23 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikQi+SPpx8Wpvb0siSSsw0ZhusWaaKmqRnfHrnz@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=colin.tuckley@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rabin.vincent@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.