* [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init.
@ 2010-10-04 21:15 Scott Wood
2010-10-18 18:32 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2010-10-04 21:15 UTC (permalink / raw)
To: QEMU Developers
This will deadlock when the I/O thread is used, since the
CPU thread is blocked waiting for qemu_system_ready.
The synchronization is unnecessary since this is before
cpu_synchronize_all_post_init().
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
hw/ppc440_bamboo.c | 2 --
hw/ppce500_mpc8544ds.c | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
index 34ddf45..645e84f 100644
--- a/hw/ppc440_bamboo.c
+++ b/hw/ppc440_bamboo.c
@@ -156,8 +156,6 @@ static void bamboo_init(ram_addr_t ram_size,
exit(1);
}
- cpu_synchronize_state(env);
-
/* Set initial guest state. */
env->gpr[1] = (16<<20) - 8;
env->gpr[3] = FDT_ADDR;
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 1422fad..f7e9465 100644
--- a/hw/ppce500_mpc8544ds.c
+++ b/hw/ppce500_mpc8544ds.c
@@ -269,8 +269,6 @@ static void mpc8544ds_init(ram_addr_t ram_size,
exit(1);
}
- cpu_synchronize_state(env);
-
/* Set initial guest state. */
env->gpr[1] = (16<<20) - 8;
env->gpr[3] = dt_base;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init.
2010-10-04 21:15 [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init Scott Wood
@ 2010-10-18 18:32 ` Scott Wood
2010-10-18 18:53 ` [Qemu-devel] " Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2010-10-18 18:32 UTC (permalink / raw)
To: QEMU Developers
On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote:
> This will deadlock when the I/O thread is used, since the
> CPU thread is blocked waiting for qemu_system_ready.
>
> The synchronization is unnecessary since this is before
> cpu_synchronize_all_post_init().
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> hw/ppc440_bamboo.c | 2 --
> hw/ppce500_mpc8544ds.c | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
Any comment on/objection to this patch?
-Scott
>
> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
> index 34ddf45..645e84f 100644
> --- a/hw/ppc440_bamboo.c
> +++ b/hw/ppc440_bamboo.c
> @@ -156,8 +156,6 @@ static void bamboo_init(ram_addr_t ram_size,
> exit(1);
> }
>
> - cpu_synchronize_state(env);
> -
> /* Set initial guest state. */
> env->gpr[1] = (16<<20) - 8;
> env->gpr[3] = FDT_ADDR;
> diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
> index 1422fad..f7e9465 100644
> --- a/hw/ppce500_mpc8544ds.c
> +++ b/hw/ppce500_mpc8544ds.c
> @@ -269,8 +269,6 @@ static void mpc8544ds_init(ram_addr_t ram_size,
> exit(1);
> }
>
> - cpu_synchronize_state(env);
> -
> /* Set initial guest state. */
> env->gpr[1] = (16<<20) - 8;
> env->gpr[3] = dt_base;
> --
> 1.7.0.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] Don't call cpu_synchronize_state() from machine init.
2010-10-18 18:32 ` Scott Wood
@ 2010-10-18 18:53 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2010-10-18 18:53 UTC (permalink / raw)
To: Scott Wood; +Cc: QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
Am 18.10.2010 20:32, Scott Wood wrote:
> On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote:
>> This will deadlock when the I/O thread is used, since the
>> CPU thread is blocked waiting for qemu_system_ready.
>>
>> The synchronization is unnecessary since this is before
>> cpu_synchronize_all_post_init().
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> ---
>> hw/ppc440_bamboo.c | 2 --
>> hw/ppce500_mpc8544ds.c | 2 --
>> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> Any comment on/objection to this patch?
>
Obviously correct, should get committed.
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
> -Scott
>
>>
>> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
>> index 34ddf45..645e84f 100644
>> --- a/hw/ppc440_bamboo.c
>> +++ b/hw/ppc440_bamboo.c
>> @@ -156,8 +156,6 @@ static void bamboo_init(ram_addr_t ram_size,
>> exit(1);
>> }
>>
>> - cpu_synchronize_state(env);
>> -
>> /* Set initial guest state. */
>> env->gpr[1] = (16<<20) - 8;
>> env->gpr[3] = FDT_ADDR;
>> diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
>> index 1422fad..f7e9465 100644
>> --- a/hw/ppce500_mpc8544ds.c
>> +++ b/hw/ppce500_mpc8544ds.c
>> @@ -269,8 +269,6 @@ static void mpc8544ds_init(ram_addr_t ram_size,
>> exit(1);
>> }
>>
>> - cpu_synchronize_state(env);
>> -
>> /* Set initial guest state. */
>> env->gpr[1] = (16<<20) - 8;
>> env->gpr[3] = dt_base;
>> --
>> 1.7.0.4
>>
>>
>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-18 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-04 21:15 [Qemu-devel] [PATCH] Don't call cpu_synchronize_state() from machine init Scott Wood
2010-10-18 18:32 ` Scott Wood
2010-10-18 18:53 ` [Qemu-devel] " Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.