* [PATCH 1/1] cciss: fix PCI IDs for new Smart Array controllers
@ 2010-10-18 18:53 Mike Miller
2010-10-18 19:55 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mike Miller @ 2010-10-18 18:53 UTC (permalink / raw)
To: Andrew Morton, Jens Axboe; +Cc: LKML, LKML-scsi
Patch 1 of 1
cciss: fix PCI IDs for new controllers
This patch fixes the botched up PCI IDs of new controllers. Please consider
this patch for inclusion.
Signed-off-by: Mike Miller <mike.miller@hp.com>
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 5e4fadc..48c4af1 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -105,11 +105,12 @@ static const struct pci_device_id cciss_pci_device_id[] = {
{PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3249},
{PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x324A},
{PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x324B},
- {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3250},
- {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3251},
- {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3252},
- {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3253},
- {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSE, 0x103C, 0x3254},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3350},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3351},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3352},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3353},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3354},
+ {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_CISSF, 0x103C, 0x3355},
{0,}
};
@@ -149,11 +150,12 @@ static struct board_type products[] = {
{0x3249103C, "Smart Array P812", &SA5_access},
{0x324A103C, "Smart Array P712m", &SA5_access},
{0x324B103C, "Smart Array P711m", &SA5_access},
- {0x3250103C, "Smart Array", &SA5_access},
- {0x3251103C, "Smart Array", &SA5_access},
- {0x3252103C, "Smart Array", &SA5_access},
- {0x3253103C, "Smart Array", &SA5_access},
- {0x3254103C, "Smart Array", &SA5_access},
+ {0x3350103C, "Smart Array", &SA5_access},
+ {0x3351103C, "Smart Array", &SA5_access},
+ {0x3352103C, "Smart Array", &SA5_access},
+ {0x3353103C, "Smart Array", &SA5_access},
+ {0x3354103C, "Smart Array", &SA5_access},
+ {0x3355103C, "Smart Array", &SA5_access},
};
/* How long to wait (in milliseconds) for board to go into simple mode */
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 10d3330..0a5dcb5 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -739,6 +739,7 @@
#define PCI_DEVICE_ID_HP_CISSC 0x3230
#define PCI_DEVICE_ID_HP_CISSD 0x3238
#define PCI_DEVICE_ID_HP_CISSE 0x323a
+#define PCI_DEVICE_ID_HP_CISSF 0x323b
#define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
#define PCI_VENDOR_ID_PCTECH 0x1042
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] cciss: fix PCI IDs for new Smart Array controllers
2010-10-18 18:53 [PATCH 1/1] cciss: fix PCI IDs for new Smart Array controllers Mike Miller
@ 2010-10-18 19:55 ` Andrew Morton
2010-10-18 21:14 ` Miller, Mike (OS Dev)
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2010-10-18 19:55 UTC (permalink / raw)
To: Mike Miller; +Cc: Jens Axboe, LKML, LKML-scsi
On Mon, 18 Oct 2010 13:53:07 -0500
Mike Miller <mike.miller@hp.com> wrote:
> Patch 1 of 1
> cciss: fix PCI IDs for new controllers
>
> This patch fixes the botched up PCI IDs of new controllers. Please consider
> this patch for inclusion.
>
What was botched up about it?
What are the runtime effects of this change?
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] cciss: fix PCI IDs for new Smart Array controllers
2010-10-18 19:55 ` Andrew Morton
@ 2010-10-18 21:14 ` Miller, Mike (OS Dev)
0 siblings, 0 replies; 3+ messages in thread
From: Miller, Mike (OS Dev) @ 2010-10-18 21:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jens Axboe, LKML, LKML-scsi
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Monday, October 18, 2010 2:56 PM
> To: Miller, Mike (OS Dev)
> Cc: Jens Axboe; LKML; LKML-scsi
> Subject: Re: [PATCH 1/1] cciss: fix PCI IDs for new Smart
> Array controllers
>
> On Mon, 18 Oct 2010 13:53:07 -0500
> Mike Miller <mike.miller@hp.com> wrote:
>
> > Patch 1 of 1
> > cciss: fix PCI IDs for new controllers
> >
> > This patch fixes the botched up PCI IDs of new controllers. Please
> > consider this patch for inclusion.
> >
>
> What was botched up about it?
>
> What are the runtime effects of this change?
>
The PCI subsystem ID's were wrong. They were 3250 to 3254. They should have been 335x. I also added another new controller that just popped up.
The runtime effects are the boards will not be recognized without this fix.
-- mikem
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-18 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-18 18:53 [PATCH 1/1] cciss: fix PCI IDs for new Smart Array controllers Mike Miller
2010-10-18 19:55 ` Andrew Morton
2010-10-18 21:14 ` Miller, Mike (OS Dev)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.