* [PATCH] drivers/crypto: dubious error check
@ 2010-10-24 13:05 Nicolas Kaiser
2010-10-24 16:39 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Kaiser @ 2010-10-24 13:05 UTC (permalink / raw)
To: Herbert Xu; +Cc: David S. Miller, linux-crypto, linux-kernel
Looks like a copy-and-paste problem to me.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/crypto/n2_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 88ee015..7614126 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1832,7 +1832,7 @@ static int __devinit get_irq_props(struct mdesc_handle *mdesc, u64 node,
return -ENODEV;
ino = mdesc_get_property(mdesc, node, "ino", &ino_len);
- if (!intr)
+ if (!ino)
return -ENODEV;
if (intr_len != ino_len)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/crypto: dubious error check
2010-10-24 13:05 [PATCH] drivers/crypto: dubious error check Nicolas Kaiser
@ 2010-10-24 16:39 ` David Miller
2010-10-25 23:26 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2010-10-24 16:39 UTC (permalink / raw)
To: nikai; +Cc: herbert, linux-crypto, linux-kernel
From: Nicolas Kaiser <nikai@nikai.net>
Date: Sun, 24 Oct 2010 15:05:56 +0200
> Looks like a copy-and-paste problem to me.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/crypto: dubious error check
2010-10-24 16:39 ` David Miller
@ 2010-10-25 23:26 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2010-10-25 23:26 UTC (permalink / raw)
To: David Miller; +Cc: nikai, linux-crypto, linux-kernel
On Sun, Oct 24, 2010 at 09:39:49AM -0700, David Miller wrote:
> From: Nicolas Kaiser <nikai@nikai.net>
> Date: Sun, 24 Oct 2010 15:05:56 +0200
>
> > Looks like a copy-and-paste problem to me.
> >
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Applied to crypto-2.6. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/crypto: dubious error check
@ 2010-10-25 23:26 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2010-10-25 23:26 UTC (permalink / raw)
To: David Miller; +Cc: nikai, linux-crypto, linux-kernel
On Sun, Oct 24, 2010 at 09:39:49AM -0700, David Miller wrote:
> From: Nicolas Kaiser <nikai@nikai.net>
> Date: Sun, 24 Oct 2010 15:05:56 +0200
>
> > Looks like a copy-and-paste problem to me.
> >
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Applied to crypto-2.6. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-25 23:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-24 13:05 [PATCH] drivers/crypto: dubious error check Nicolas Kaiser
2010-10-24 16:39 ` David Miller
2010-10-25 23:26 ` Herbert Xu
2010-10-25 23:26 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.