From: Jean Delvare <khali@linux-fr.org>
To: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
Cc: "Samuel Ortiz" <sameo@linux.intel.com>,
"Wolfram Sang" <w.sang@pengutronix.de>,
"Ralf Baechle" <ralf@linux-mips.org>, <linux-i2c@vger.kernel.org>,
"LKML" <linux-kernel@vger.kernel.org>,
"Ben Dooks " <ben-linux@fluff.org>,
"Linus Walleij" <linus.walleij@stericsson.com>,
"srinidhi kasagar" <srinidhi.kasagar@stericsson.com>,
"Tomoya MORINAGA" <morinaga526@dsn.okisemi.com>,
"Wang Qi" <qi.wang@intel.com>,
"Wang Yong Y" <yong.y.wang@intel.com>, <kok.howg.ewe@intel.com>,
<joel.clark@intel.com>, <andrew.chih.howe.khor@intel.com>
Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36
Date: Tue, 26 Oct 2010 13:26:49 +0200 [thread overview]
Message-ID: <20101026132649.623461f9@endymion.delvare> (raw)
In-Reply-To: <001c01cb74f2$d3dd8990$66f8800a@maildom.okisemi.com>
On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote:
> Hi Jean,
>
> On Tuesday, October 26, 2010 6:13 PM, Jean Delvare wrote:
> > The _pch becomes redundant then, i2c-topcliff.c would be enough, but
> > both are fine with me, as my initial concern is gone.
> I agree.
> I will modify to "i2c-topcliff.c".
>
> > There's no Reviewed-by, Acked-by or Signed-off-by from anyone at Intel
> > in the patch you posted.
> Must we get Intel's signature ?
> We have already got the following. Isn't this enough ?
> > Reviewed-by: Linus Walleij <linus.walleij@stericsson.com>
>
> Though I haven't heard like the requirement,
> if Intel's signature is mandatory, I will request to Intel.
It's not mandatory, but the time Ben and myself have to review new
drivers is scarce, so it's in your own interest to have the code
reviewed by people with more time and more interest in the specific
hardware. I can only imagine that Intel wants Topcliff to be supported
as soon as possible by the Linux kernel, so they should certainly have
resources to allocate for the review and testing.
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Tomoya MORINAGA <tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
srinidhi kasagar
<srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Tomoya MORINAGA
<morinaga526-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>,
Wang Qi <qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Wang Yong Y <yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36
Date: Tue, 26 Oct 2010 13:26:49 +0200 [thread overview]
Message-ID: <20101026132649.623461f9@endymion.delvare> (raw)
In-Reply-To: <001c01cb74f2$d3dd8990$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote:
> Hi Jean,
>
> On Tuesday, October 26, 2010 6:13 PM, Jean Delvare wrote:
> > The _pch becomes redundant then, i2c-topcliff.c would be enough, but
> > both are fine with me, as my initial concern is gone.
> I agree.
> I will modify to "i2c-topcliff.c".
>
> > There's no Reviewed-by, Acked-by or Signed-off-by from anyone at Intel
> > in the patch you posted.
> Must we get Intel's signature ?
> We have already got the following. Isn't this enough ?
> > Reviewed-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
>
> Though I haven't heard like the requirement,
> if Intel's signature is mandatory, I will request to Intel.
It's not mandatory, but the time Ben and myself have to review new
drivers is scarce, so it's in your own interest to have the code
reviewed by people with more time and more interest in the specific
hardware. I can only imagine that Intel wants Topcliff to be supported
as soon as possible by the Linux kernel, so they should certainly have
resources to allocate for the review and testing.
--
Jean Delvare
next prev parent reply other threads:[~2010-10-26 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 3:06 [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 Tomoya
2010-10-26 3:06 ` Tomoya
2010-10-26 8:20 ` Jean Delvare
2010-10-26 8:20 ` Jean Delvare
2010-10-26 9:05 ` Tomoya MORINAGA
2010-10-26 9:05 ` Tomoya MORINAGA
2010-10-26 9:13 ` Jean Delvare
2010-10-26 9:13 ` Jean Delvare
2010-10-26 9:47 ` Tomoya MORINAGA
2010-10-26 9:47 ` Tomoya MORINAGA
2010-10-26 11:26 ` Jean Delvare [this message]
2010-10-26 11:26 ` Jean Delvare
2010-10-26 23:57 ` Tomoya MORINAGA
2010-10-26 23:57 ` Tomoya MORINAGA
2010-10-27 13:15 ` Linus Walleij
2010-10-27 13:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026132649.623461f9@endymion.delvare \
--to=khali@linux-fr.org \
--cc=andrew.chih.howe.khor@intel.com \
--cc=ben-linux@fluff.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=ralf@linux-mips.org \
--cc=sameo@linux.intel.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=w.sang@pengutronix.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.