[U-Boot] GENERATED_GBL_DATA_SIZE problem

[U-Boot] GENERATED_GBL_DATA_SIZE problem

[Himanshu Chauhan]

Hi List,

Day before I reported the problem with declarations of CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR.

In the following patch GENERATED_GBL_DATA_SIZE is defined as #96. The pound size before the number is cauing
the assembler go mad. It doesn't compile. Remove the pound and its okay. Is the pound sign really required or
is this problem with the sed script being used for it?

diff --git a/include/configs/versatile.h b/include/configs/versatile.h
index 45d8434..5156589 100644
--- a/include/configs/versatile.h
+++ b/include/configs/versatile.h
@@ -231,4 +231,7 @@
 #define CONFIG_SYS_FLASH_PROTECTION    /* The devices have real protection */
 #define CONFIG_SYS_FLASH_EMPTY_INFO    /* flinfo indicates empty blocks */
 
+#define CONFIG_SYS_SDRAM_BASE          PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR        (CONFIG_SYS_TEXT_BASE - GENERATED_GBL_DATA_SIZE)
+
 #endif /* __CONFIG_H */


Thanks

Regards
Himanshu

[U-Boot] GENERATED_GBL_DATA_SIZE problem

[Wolfgang Denk]

Dear Himanshu Chauhan,

In message <20101028164616.GA3028@pnq-hchauhan-vm> you wrote:
> Hi List,
> 
> Day before I reported the problem with declarations of CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR.
> 
> In the following patch GENERATED_GBL_DATA_SIZE is defined as #96. The pound size before the number is cauing
> the assembler go mad. It doesn't compile. Remove the pound and its okay. Is the pound sign really required or
> is this problem with the sed script being used for it?

Please update your code. This has been fixed yesterday morning. Patch
is in mainline since last night.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a woman marries again it is because she detested her first  hus-
band.  When  a  man  marries again, it is because he adored his first
wife.                                                  -- Oscar Wilde

[U-Boot] GENERATED_GBL_DATA_SIZE problem

[Himanshu Chauhan]

On Thu, Oct 28, 2010 at 06:55:14PM +0200, Wolfgang Denk wrote:
> Dear Himanshu Chauhan,
> 
> In message <20101028164616.GA3028@pnq-hchauhan-vm> you wrote:
> > Hi List,
> > 
> > Day before I reported the problem with declarations of CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR.
> > 
> > In the following patch GENERATED_GBL_DATA_SIZE is defined as #96. The pound size before the number is cauing
> > the assembler go mad. It doesn't compile. Remove the pound and its okay. Is the pound sign really required or
> > is this problem with the sed script being used for it?
> 
> Please update your code. This has been fixed yesterday morning. Patch
> is in mainline since last night.
> 

Thanks Wolfgang, It works.

Regards
Himanshu