Re: [PATCH] Fix bug in FUSE where the attribute cache for a file was not cleared when a file is opened with O_TRUNC.

From: Andrew Morton <akpm@linux-foundation.org>
To: Ken Sumrall <ksumrall@android.com>
Cc: linux-kernel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
	Jens Axboe <jens.axboe@oracle.com>, Anfei <anfei.zhou@gmail.com>,
	"Anand V. Avati" <avati@gluster.com>,
	fuse-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix bug in FUSE where the attribute cache for a file was not cleared when a file is opened with O_TRUNC.
Date: Fri, 29 Oct 2010 17:02:09 -0700	[thread overview]
Message-ID: <20101029170209.0aced0ca.akpm@linux-foundation.org> (raw)
In-Reply-To: <1288395700-9527-1-git-send-email-ksumrall@android.com>

On Fri, 29 Oct 2010 16:41:40 -0700 Ken Sumrall <ksumrall@android.com> wrote:

> Signed-off-by: Ken Sumrall <ksumrall@android.com>
> ---
>  fs/fuse/file.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index c822458..4fbe62c 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -134,6 +134,7 @@ EXPORT_SYMBOL_GPL(fuse_do_open);
>  void fuse_finish_open(struct inode *inode, struct file *file)
>  {
>  	struct fuse_file *ff = file->private_data;
> +	struct fuse_conn *fc = get_fuse_conn(inode);
>  
>  	if (ff->open_flags & FOPEN_DIRECT_IO)
>  		file->f_op = &fuse_direct_io_file_operations;
> @@ -141,6 +142,8 @@ void fuse_finish_open(struct inode *inode, struct file *file)
>  		invalidate_inode_pages2(inode->i_mapping);
>  	if (ff->open_flags & FOPEN_NONSEEKABLE)
>  		nonseekable_open(inode, file);
> +	if (fc->atomic_o_trunc && (file->f_flags & O_TRUNC))
> +		fuse_invalidate_attr(inode);
>  }
>  
>  int fuse_open_common(struct inode *inode, struct file *file, bool isdir)

What were the user-visible effects of this bug?