From: Ken Sumrall <ksumrall@android.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jens.axboe@oracle.com, anfei.zhou@gmail.com, avati@gluster.com,
fuse-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix bug in FUSE where the attribute cache for a file was not cleared when a file is opened with O_TRUNC.
Date: Mon, 1 Nov 2010 16:38:55 -0700 [thread overview]
Message-ID: <AANLkTi=2friy7htn4qZGjanxwTSQ7P8Wc6kgB9B9O5PK@mail.gmail.com> (raw)
In-Reply-To: <E1PC9ed-00045m-LA@pomaz-ex.szeredi.hu>
I'm no FUSE expert, so I don't feel qualified to fully evaluate the
changes, but the
locking looks correct and non-blocking, and the code still passes our
test case and
doesn't crash, so it gets my vote of approval.
___
Ken
On Sat, Oct 30, 2010 at 4:31 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> Ken,
>
> Thanks for the patch.
>
> Here's a slightly updated one. Does this also look OK?
>
> Miklos
>
>
> ----
> Subject: fuse: fix attributes after open(O_TRUNC)
> From: Ken Sumrall <ksumrall@android.com>
>
> The attribute cache for a file was not being cleared when a file is
> opened with O_TRUNC.
>
> If the filesystem's open operation truncates the file
> ("atomic_o_trunc" feature flag is set) then the kernel should
> invalidate the cached st_mtime and st_ctime attributes.
>
> Also i_size should be explicitly be set to zero as it is used
> sometimes without refreshing the cache.
>
> Signed-off-by: Ken Sumrall <ksumrall@android.com>
> Cc: Anfei <anfei.zhou@gmail.com>
> Cc: "Anand V. Avati" <avati@gluster.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
> Cc: stable@kernel.org
> ---
>
> fs/fuse/file.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> Index: linux-2.6/fs/fuse/file.c
> ===================================================================
> --- linux-2.6.orig/fs/fuse/file.c 2010-10-27 14:04:02.000000000 +0200
> +++ linux-2.6/fs/fuse/file.c 2010-10-30 13:14:07.000000000 +0200
> @@ -134,6 +134,7 @@ EXPORT_SYMBOL_GPL(fuse_do_open);
> void fuse_finish_open(struct inode *inode, struct file *file)
> {
> struct fuse_file *ff = file->private_data;
> + struct fuse_conn *fc = get_fuse_conn(inode);
>
> if (ff->open_flags & FOPEN_DIRECT_IO)
> file->f_op = &fuse_direct_io_file_operations;
> @@ -141,6 +142,15 @@ void fuse_finish_open(struct inode *inod
> invalidate_inode_pages2(inode->i_mapping);
> if (ff->open_flags & FOPEN_NONSEEKABLE)
> nonseekable_open(inode, file);
> + if (fc->atomic_o_trunc && (file->f_flags & O_TRUNC)) {
> + struct fuse_inode *fi = get_fuse_inode(inode);
> +
> + spin_lock(&fc->lock);
> + fi->attr_version = ++fc->attr_version;
> + i_size_write(inode, 0);
> + spin_unlock(&fc->lock);
> + fuse_invalidate_attr(inode);
> + }
> }
>
> int fuse_open_common(struct inode *inode, struct file *file, bool isdir)
>
next prev parent reply other threads:[~2010-11-01 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 23:41 [PATCH] Fix bug in FUSE where the attribute cache for a file was not cleared when a file is opened with O_TRUNC Ken Sumrall
2010-10-30 0:02 ` Andrew Morton
[not found] ` <AANLkTimJWX5WnG6oiUfBxiD=BBJ=Q5iRc73iar=gPKCy@mail.gmail.com>
2010-10-30 0:37 ` Fwd: " Ken Sumrall
2010-10-30 11:31 ` Miklos Szeredi
2010-11-01 23:38 ` Ken Sumrall [this message]
2010-11-11 22:10 ` Andrew Morton
2010-11-12 9:37 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=2friy7htn4qZGjanxwTSQ7P8Wc6kgB9B9O5PK@mail.gmail.com' \
--to=ksumrall@android.com \
--cc=akpm@linux-foundation.org \
--cc=anfei.zhou@gmail.com \
--cc=avati@gluster.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.