All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipc: shm: fix information leak to userland
@ 2010-10-30  9:04 ` Vasiliy Kulikov
  0 siblings, 0 replies; 8+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30  9:04 UTC (permalink / raw)
  To: kernel-janitors
  Cc: Al Viro, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized.  It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
 Compile tested.

 ipc/shm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
 	    {
 		struct shmid_ds out;
 
+		memset(&out, 0, sizeof(out));
 		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
 		out.shm_segsz	= in->shm_segsz;
 		out.shm_atime	= in->shm_atime;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ipc: shm: fix information leak to userland
@ 2010-10-30  9:04 ` Vasiliy Kulikov
  0 siblings, 0 replies; 8+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30  9:04 UTC (permalink / raw)
  To: kernel-janitors
  Cc: Al Viro, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized.  It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
 Compile tested.

 ipc/shm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
 	    {
 		struct shmid_ds out;
 
+		memset(&out, 0, sizeof(out));
 		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
 		out.shm_segsz	= in->shm_segsz;
 		out.shm_atime	= in->shm_atime;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ipc: shm: fix information leak to userland
  2010-10-30  9:04 ` Vasiliy Kulikov
@ 2010-10-30  9:06   ` Al Viro
  -1 siblings, 0 replies; 8+ messages in thread
From: Al Viro @ 2010-10-30  9:06 UTC (permalink / raw)
  To: Vasiliy Kulikov
  Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

On Sat, Oct 30, 2010 at 01:04:37PM +0400, Vasiliy Kulikov wrote:
> Structure shmid_ds is copied to userland with shm_unused{,2,3}
> fields unitialized.  It leads to leaking of contents of kernel stack memory.
 
ACK; send to Linus and add Cc: stable@kernel.org

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ipc: shm: fix information leak to userland
@ 2010-10-30  9:06   ` Al Viro
  0 siblings, 0 replies; 8+ messages in thread
From: Al Viro @ 2010-10-30  9:06 UTC (permalink / raw)
  To: Vasiliy Kulikov
  Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

On Sat, Oct 30, 2010 at 01:04:37PM +0400, Vasiliy Kulikov wrote:
> Structure shmid_ds is copied to userland with shm_unused{,2,3}
> fields unitialized.  It leads to leaking of contents of kernel stack memory.
 
ACK; send to Linus and add Cc: stable@kernel.org

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ipc: shm: fix information leak to userland
  2010-10-30  9:06   ` Al Viro
@ 2010-10-30 14:22     ` Vasiliy Kulikov
  -1 siblings, 0 replies; 8+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 14:22 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized.  It leads to leaking of contents of kernel stack
memory.

Cc: stable@kernel.org
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
 Compile tested.

 ipc/shm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
 	    {
 		struct shmid_ds out;
 
+		memset(&out, 0, sizeof(out));
 		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
 		out.shm_segsz	= in->shm_segsz;
 		out.shm_atime	= in->shm_atime;
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ipc: shm: fix information leak to userland
@ 2010-10-30 14:22     ` Vasiliy Kulikov
  0 siblings, 0 replies; 8+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 14:22 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: kernel-janitors, Andrew Morton, Helge Deller, David Howells,
	Hugh Dickins, linux-kernel

Structure shmid_ds is copied to userland with shm_unused{,2,3}
fields unitialized.  It leads to leaking of contents of kernel stack
memory.

Cc: stable@kernel.org
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
 Compile tested.

 ipc/shm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index fd658a1..7d3bb22 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
 	    {
 		struct shmid_ds out;
 
+		memset(&out, 0, sizeof(out));
 		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
 		out.shm_segsz	= in->shm_segsz;
 		out.shm_atime	= in->shm_atime;
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ipc: shm: fix information leak to userland
  2010-10-30 15:00 ` Dan Rosenberg
@ 2010-10-30 15:40   ` Vasiliy Kulikov
  0 siblings, 0 replies; 8+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 15:40 UTC (permalink / raw)
  To: Dan Rosenberg; +Cc: linux-kernel

Hi Dan,

On Sat, Oct 30, 2010 at 11:00 -0400, Dan Rosenberg wrote:
> This one already got taken care of by Kees Cook:
> 
> http://lkml.org/lkml/2010/10/6/486

After 25 days it is still not in linux-next.  Also the second hunk is IMO odd
as all five fields are initialized:


	case IPC_OLD:
	    {
		struct shminfo out;

		if(in->shmmax > INT_MAX)
			out.shmmax = INT_MAX;
		else
			out.shmmax = (int)in->shmmax;

		out.shmmin	= in->shmmin;
		out.shmmni	= in->shmmni;
		out.shmseg	= in->shmseg;
		out.shmall	= in->shmall; 

		return copy_to_user(buf, &out, sizeof(out));
	    }

/* Obsolete, used only for backwards compatibility */
struct  shminfo {
        int shmmax;
        int shmmin;
        int shmmni;
        int shmseg;
        int shmall;
};

And I see no padding hole in shminfo.



> Thanks,
> Dan
> 
> > Structure shmid_ds is copied to userland with shm_unused{,2,3}
> > fields unitialized.  It leads to leaking of contents of kernel stack
> > memory.
> > Cc: stable@kernel.org
> > Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
> > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > ---
> >  Compile tested.
> >  ipc/shm.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > diff --git a/ipc/shm.c b/ipc/shm.c
> > index fd658a1..7d3bb22 100644
> > --- a/ipc/shm.c
> > +++ b/ipc/shm.c
> > @@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
> >  	    {
> >  		struct shmid_ds out;
> >  
> > +		memset(&out, 0, sizeof(out));
> >  		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
> >  		out.shm_segsz	= in->shm_segsz;
> >  		out.shm_atime	= in->shm_atime;
> 
> 

Thanks,

-- 
Vasiliy

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ipc: shm: fix information leak to userland
       [not found] <1288450677.3964.1.camel@dan>
@ 2010-10-30 15:00 ` Dan Rosenberg
  2010-10-30 15:40   ` Vasiliy Kulikov
  0 siblings, 1 reply; 8+ messages in thread
From: Dan Rosenberg @ 2010-10-30 15:00 UTC (permalink / raw)
  To: segooon; +Cc: linux-kernel

This one already got taken care of by Kees Cook:

http://lkml.org/lkml/2010/10/6/486

Thanks,
Dan

> Structure shmid_ds is copied to userland with shm_unused{,2,3}
> fields unitialized.  It leads to leaking of contents of kernel stack
> memory.
> Cc: stable@kernel.org
> Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
>  Compile tested.
>  ipc/shm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/ipc/shm.c b/ipc/shm.c
> index fd658a1..7d3bb22 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
>  	    {
>  		struct shmid_ds out;
>  
> +		memset(&out, 0, sizeof(out));
>  		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
>  		out.shm_segsz	= in->shm_segsz;
>  		out.shm_atime	= in->shm_atime;



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-30 15:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-30  9:04 [PATCH] ipc: shm: fix information leak to userland Vasiliy Kulikov
2010-10-30  9:04 ` Vasiliy Kulikov
2010-10-30  9:06 ` Al Viro
2010-10-30  9:06   ` Al Viro
2010-10-30 14:22   ` Vasiliy Kulikov
2010-10-30 14:22     ` Vasiliy Kulikov
     [not found] <1288450677.3964.1.camel@dan>
2010-10-30 15:00 ` Dan Rosenberg
2010-10-30 15:40   ` Vasiliy Kulikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.