All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs
Date: Thu, 04 Nov 2010 10:57:42 +0100	[thread overview]
Message-ID: <20101104095742.5C4AC12A81E3@gemini.denx.de> (raw)
In-Reply-To: <OF5324EC0A.37C044B2-ONC12577D1.0031F002-C12577D1.00326E3D@transmode.se>

Dear Joakim Tjernlund,

In message <OF5324EC0A.37C044B2-ONC12577D1.0031F002-C12577D1.00326E3D@transmode.se> you wrote:
>
> > 4 nops after _start does the trick, i.e. the board is up and running fine.
...
> How is this going? If nothing else I think you should send
> a patch for 83xx, adding the 4 nop's as your(and mine) board is
> broken otherwise. Freescale guys seems busy with other things so
> I think this is the best thing to do.

I don't like the idea of adding such code without any understanding
why it would be needed for some boards, while it is not needed for
others.

Is it really needed at _start?  Or can these NOPs be anywhere, and are
just needed to adjust some alignment?

When building for example for the MPC8315ERDB board, I see this
strange alignment here:

	-> grep _start_of_vectors System.map 
	fe0001a8 T _start_of_vectors

Adding 4 NOPs will move this nicely to the next exception vector
address at 0x200.

Eventually this is an alignment problem (but then, the
"STD_EXCEPTION(0x200, ...)" is supposed to align the respective code
to 0x200, and indeed we see

	fe0001a8 T _start_of_vectors
	fe000200 t MachineCheck
	fe000300 t DataStorage
	fe000400 t InstStorage
	...

Given the fact that _start_of_vectors is not used anywhere in the 83xx
code, all this is a pretty big mystery to me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The explanation requiring the fewest assumptions is the  most  likely
to be correct.                                    -- William of Occam

  reply	other threads:[~2010-11-04  9:57 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  9:51 [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs Joakim Tjernlund
2010-10-18 20:39 ` Wolfgang Denk
2010-10-24 20:08   ` Schwarz, Andre
2010-10-24 20:18     ` Wolfgang Denk
2010-10-24 20:33       ` Schwarz, Andre
2010-10-24 20:48         ` Joakim Tjernlund
2010-10-25  8:24           ` Schwarz, Andre
2010-10-25 13:50           ` Andre Schwarz
2010-10-25 14:32             ` Joakim Tjernlund
2010-10-25 14:46               ` Andre Schwarz
2010-10-25 15:36                 ` Joakim Tjernlund
2010-10-25 17:16             ` Wolfgang Denk
2010-10-25 17:45               ` Andre Schwarz
2010-10-25 19:14                 ` Wolfgang Denk
2010-10-26 10:28                   ` Andre Schwarz
2010-10-26 12:34                   ` Andre Schwarz
2010-10-26 12:49                     ` Joakim Tjernlund
2010-11-04  9:10             ` Joakim Tjernlund
2010-11-04  9:57               ` Wolfgang Denk [this message]
2010-11-04 10:47                 ` Joakim Tjernlund
2010-11-04 10:54                   ` Joakim Tjernlund
2010-11-04 11:16                     ` Wolfgang Denk
2010-11-04 12:19                       ` Joakim Tjernlund
2010-11-04 12:46                         ` Wolfgang Denk
2010-11-04 12:58                           ` Joakim Tjernlund
2010-11-04 13:07                             ` Wolfgang Denk
2010-11-04 13:11                               ` Joakim Tjernlund
2010-11-04 10:58                   ` Andy Pont
2010-11-04 11:04                     ` Joakim Tjernlund
2010-11-04 12:14                     ` Andre Schwarz
2010-11-04 12:18                       ` Joakim Tjernlund
2010-11-04 12:28                         ` Andre Schwarz
     [not found]                           ` <OF350A930F.C39462D9-ONC <4CD2B5DF.2080400@matrix-vision.de>
2010-11-04 13:01                           ` Joakim Tjernlund
2010-11-04 13:32                             ` Andre Schwarz
2010-11-04 14:06                               ` Joakim Tjernlund
2010-11-04 14:49                                 ` Andre Schwarz
2010-11-04 15:10                                   ` Joakim Tjernlund
2010-11-04 16:53                                     ` Andre Schwarz
2010-11-04 10:59                   ` Reinhard Meyer
2010-11-04 10:00               ` Andre Schwarz
2010-11-04  9:50             ` Wolfgang Denk
2010-11-04 10:21               ` Joakim Tjernlund
2010-10-24 20:44       ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101104095742.5C4AC12A81E3@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.