All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] kernel-range-fix-clean_sort_range-for-the-case-of-full-array.patch removed from -mm tree
@ 2010-11-16 19:30 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-11-16 19:30 UTC (permalink / raw)
  To: khoroshilov, geert, hpa, yinghai, mm-commits


The patch titled
     kernel/range.c: fix clean_sort_range() for the case of full array
has been removed from the -mm tree.  Its filename was
     kernel-range-fix-clean_sort_range-for-the-case-of-full-array.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: kernel/range.c: fix clean_sort_range() for the case of full array
From: Alexey Khoroshilov <khoroshilov@ispras.ru>

clean_sort_range() should return a number of nonempty elements of range
array, but if the array is full clean_sort_range() returns 0.

The problem is that the number of nonempty elements is evaluated by
finding the first empty element of the array.  If there is no such element
it returns an initial value of local variable nr_range that is zero.

The fix is trivial: it changes initial value of nr_range to size of the
array.

The bug can lead to loss of information regarding all ranges, since
typically returned value of clean_sort_range() is considered as an actual
number of ranges in the array after a series of add/subtract operations.

Found by Analytical Verification project of Linux Verification Center
(linuxtesting.org), thanks to Alexander Kolosov.

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/range.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/range.c~kernel-range-fix-clean_sort_range-for-the-case-of-full-array kernel/range.c
--- a/kernel/range.c~kernel-range-fix-clean_sort_range-for-the-case-of-full-array
+++ a/kernel/range.c
@@ -119,7 +119,7 @@ static int cmp_range(const void *x1, con
 
 int clean_sort_range(struct range *range, int az)
 {
-	int i, j, k = az - 1, nr_range = 0;
+	int i, j, k = az - 1, nr_range = az;
 
 	for (i = 0; i < k; i++) {
 		if (range[i].end)
_

Patches currently in -mm which might be from khoroshilov@ispras.ru are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-11-16 19:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-16 19:30 [merged] kernel-range-fix-clean_sort_range-for-the-case-of-full-array.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.