From: Greg KH <greg@kroah.com>
To: Yehuda Sadeh <yehuda@hq.newdream.net>
Cc: sage@newdream.net, yehudasa@gmail.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rbd: replace the rbd sysfs interface
Date: Wed, 17 Nov 2010 09:19:24 -0800 [thread overview]
Message-ID: <20101117171924.GC12050@kroah.com> (raw)
In-Reply-To: <1289953929-30896-1-git-send-email-yehuda@hq.newdream.net>
On Tue, Nov 16, 2010 at 04:32:09PM -0800, Yehuda Sadeh wrote:
> Hi Greg,
>
> Following is the new rbd sysfs interface. It lists devices in their own
> subdirectories, as well as their underlying snapshots. Please let us
> know if there's any issue you think we missed or did wrong.
>
> Thanks,
> Yehuda
>
> ---
>
> The new interface creates directories per mapped image
> and under each it creates a subdir per available snapshot.
> This allows keeping a cleaner interface within the sysfs
> guidelines. The ABI documentation was updated too.
>
> Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
> ---
> Documentation/ABI/testing/sysfs-class-rbd | 83 +++
> drivers/block/rbd.c | 775 +++++++++++++++++------------
> 2 files changed, 547 insertions(+), 311 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-rbd b/Documentation/ABI/testing/sysfs-class-rbd
> new file mode 100644
> index 0000000..4d96618
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-rbd
> @@ -0,0 +1,83 @@
> +What: /sys/class/rbd/
I thought I mentioned that you should not add new classes to the kernel.
Please don't do that, make it a bus_type instead.
Actually, that will solve some of your coding problems as well:
> @@ -193,6 +130,11 @@ struct rbd_device {
> int read_only;
>
> struct list_head node;
> +
> + struct device dev;
> + struct kobject snaps_kobj;
> + struct list_head snaps;
> + int kobj_ready;
> };
Woah, that's wrong. You can NEVER have two different reference counted
objects as part of a single structure. Your reference counting is
guaranteed to be wrong.
You should not need a kobject at all here, just use a device and be done
with it.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2010-11-17 17:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 0:32 [PATCH] rbd: replace the rbd sysfs interface Yehuda Sadeh
2010-11-17 17:19 ` Greg KH [this message]
2010-11-17 23:00 ` Yehuda Sadeh Weinraub
2010-11-17 23:00 ` Yehuda Sadeh Weinraub
2010-11-18 1:30 ` Greg KH
2010-11-18 22:53 ` Yehuda Sadeh Weinraub
2010-11-18 22:53 ` Yehuda Sadeh Weinraub
2010-11-19 2:08 ` Greg KH
2010-11-19 20:42 ` Yehuda Sadeh Weinraub
2010-11-19 20:42 ` Yehuda Sadeh Weinraub
2010-11-23 0:14 ` Greg KH
2010-11-23 0:14 ` Greg KH
2010-11-23 0:48 ` Yehuda Sadeh Weinraub
2010-11-23 0:48 ` Yehuda Sadeh Weinraub
2010-11-23 0:58 ` Greg KH
2010-11-23 0:58 ` Greg KH
2010-11-23 1:19 ` Yehuda Sadeh Weinraub
2010-11-23 1:19 ` Yehuda Sadeh Weinraub
2010-11-24 0:23 ` Yehuda Sadeh
2010-12-01 19:25 ` Sage Weil
2010-12-01 19:47 ` Greg KH
2010-12-01 20:08 ` Sage Weil
2010-12-01 20:23 ` Greg KH
2010-12-02 0:11 ` Sage Weil
2010-11-22 23:33 ` Yehuda Sadeh
2010-11-23 0:14 ` Greg KH
2010-11-23 0:45 ` Sage Weil
2010-11-23 0:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117171924.GC12050@kroah.com \
--to=greg@kroah.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=yehuda@hq.newdream.net \
--cc=yehudasa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.