From: Sage Weil <sage@newdream.net>
To: Greg KH <greg@kroah.com>
Cc: Yehuda Sadeh <yehuda@hq.newdream.net>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rbd: replace the rbd sysfs interface
Date: Wed, 1 Dec 2010 16:11:44 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.1012011601440.8183@cobra.newdream.net> (raw)
In-Reply-To: <20101201202350.GA1717@kroah.com>
On Wed, 1 Dec 2010, Greg KH wrote:
> On Wed, Dec 01, 2010 at 12:08:15PM -0800, Sage Weil wrote:
> > On Wed, 1 Dec 2010, Greg KH wrote:
> > > > /sys/bus/rbd/{add,remove}
> > > > /sys/bus/rbd/devices/<devid>/ <-- struct device
> > > > /sys/bus/rbd/devices/<devid>/{some dev attrs}
> > > > /sys/bus/rbd/devices/<devid>/snap_<snapid>/ <-- struct device
> > > > /sys/bus/rbd/devices/<devid>/snap_<snapid>/{some snap attrs}
> > > >
> > > > This works, and I is (I hope) using struct device properly. The only
> > > > problem, purely from a user interface standpoint, is that the snaps are
> > > > mixed in with attributes, so anybody wanting to iterate over snaps needs
> > > > to do something crufty like
> > > >
> > > > $ for snap in `ls /sys/bus/rbd/devices/$id | grep ^snap_ | cut -c 6-`; do ...
> > >
> > > What's wrong with:
> > > for snap in `ls /sys/bus/rbd/devices/$id/snap_*`; do ...
> > > instead?
> >
> > Yeah, it's really the 'cut -c 6-' bit that I was hoping to avoid. But it
> > snaps/ simply doesn't map onto the sysfs paradigm cleanly, that's fine.
> >
> > That being the case, can we get an Acked-by on the current approach/patch?
>
> Yes, please feel free to add:
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> to the patch.
Great. Thanks for all your time and help!
> > Then I can send something Linus and let him decide what to do for .37.
>
> It's pretty late for .37. Why not disable the option for now, and then
> get this patch in for .38 as it's quite a big change? I'd recommend
> doing that.
Yeah, it's late, but it would be nice to get RBD out there for people to
try sooner rather than later (it's already been a couple kernel cycles out
of tree). But I suspect Linus will agree with you... :)
Anyway, thanks again!
sage
next prev parent reply other threads:[~2010-12-02 0:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 0:32 [PATCH] rbd: replace the rbd sysfs interface Yehuda Sadeh
2010-11-17 17:19 ` Greg KH
2010-11-17 23:00 ` Yehuda Sadeh Weinraub
2010-11-17 23:00 ` Yehuda Sadeh Weinraub
2010-11-18 1:30 ` Greg KH
2010-11-18 22:53 ` Yehuda Sadeh Weinraub
2010-11-18 22:53 ` Yehuda Sadeh Weinraub
2010-11-19 2:08 ` Greg KH
2010-11-19 20:42 ` Yehuda Sadeh Weinraub
2010-11-19 20:42 ` Yehuda Sadeh Weinraub
2010-11-23 0:14 ` Greg KH
2010-11-23 0:14 ` Greg KH
2010-11-23 0:48 ` Yehuda Sadeh Weinraub
2010-11-23 0:48 ` Yehuda Sadeh Weinraub
2010-11-23 0:58 ` Greg KH
2010-11-23 0:58 ` Greg KH
2010-11-23 1:19 ` Yehuda Sadeh Weinraub
2010-11-23 1:19 ` Yehuda Sadeh Weinraub
2010-11-24 0:23 ` Yehuda Sadeh
2010-12-01 19:25 ` Sage Weil
2010-12-01 19:47 ` Greg KH
2010-12-01 20:08 ` Sage Weil
2010-12-01 20:23 ` Greg KH
2010-12-02 0:11 ` Sage Weil [this message]
2010-11-22 23:33 ` Yehuda Sadeh
2010-11-23 0:14 ` Greg KH
2010-11-23 0:45 ` Sage Weil
2010-11-23 0:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1012011601440.8183@cobra.newdream.net \
--to=sage@newdream.net \
--cc=ceph-devel@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.