All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
@ 2010-05-21 11:55 ` Launchpad Bug Tracker
  2010-06-02 20:12 ` Anthony Liguori
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-05-21 11:55 UTC (permalink / raw)
  To: qemu-devel

** Branch linked: lp:ubuntu/qemu-kvm

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
  2010-05-21 11:55 ` [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client Launchpad Bug Tracker
@ 2010-06-02 20:12 ` Anthony Liguori
  2010-11-17 23:52 ` Benjamin Drung
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Anthony Liguori @ 2010-06-02 20:12 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
       Status: New => Invalid

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
  2010-05-21 11:55 ` [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client Launchpad Bug Tracker
  2010-06-02 20:12 ` Anthony Liguori
@ 2010-11-17 23:52 ` Benjamin Drung
  2010-11-17 23:55 ` Benjamin Drung
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-17 23:52 UTC (permalink / raw)
  To: qemu-devel

I am reopening the bug for qemu-kvm, because the patch was dropped in
0.12.4+noroms-0ubuntu1.

** Changed in: qemu-kvm (Ubuntu)
       Status: Fix Released => New

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (2 preceding siblings ...)
  2010-11-17 23:52 ` Benjamin Drung
@ 2010-11-17 23:55 ` Benjamin Drung
  2010-11-18  1:50 ` Serge Hallyn
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-17 23:55 UTC (permalink / raw)
  To: qemu-devel

I modified qemu-kvm to show what keys it receives (patch attached). I am
using the German NEO layout and I get one press and one release event.
Here's the output, if I first press 'caps lock' and then '#':

sdl_process_key({type=0x2,which=0x0,state=0x1,keysym={scancode=0x42,sym=0x139,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

sdl_process_key({type=0x3,which=0x0,state=0x0,keysym={scancode=0x42,sym=0x139,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

sdl_process_key({type=0x2,which=0x0,state=0x1,keysym={scancode=0x33,sym=0x139,mod=0x0,unicode=0x0}})
keycode = 0x2b
kbd_put_keycode(0x2b)

sdl_process_key({type=0x3,which=0x0,state=0x0,keysym={scancode=0x33,sym=0x139,mod=0x0,unicode=0x0}})
keycode = 0x2b
kbd_put_keycode(0xab)


** Patch added: "kvm-showkeys.patch"
   https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1736687/+files/kvm-showkeys.patch

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (3 preceding siblings ...)
  2010-11-17 23:55 ` Benjamin Drung
@ 2010-11-18  1:50 ` Serge Hallyn
  2010-11-18  1:56 ` Serge Hallyn
                   ` (19 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-18  1:50 UTC (permalink / raw)
  To: qemu-devel

Capslock turning on:

sdl_process_key({type=0x2,which=0x0,state=0x1,keysym={scancode=0x42,sym=0x12d,mod=0x2000,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

capslock turning off:

sdl_process_key({type=0x3,which=0x0,state=0x0,keysym={scancode=0x42,sym=0x12d,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

Unlike other keys, everything gets dumped at once at keydown - nothing
new is generated at keyup.

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (4 preceding siblings ...)
  2010-11-18  1:50 ` Serge Hallyn
@ 2010-11-18  1:56 ` Serge Hallyn
  2010-11-18 23:46 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Benjamin Drung
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-18  1:56 UTC (permalink / raw)
  To: qemu-devel

Uh, but capslock works for me!  In the stock 0.12.5 maverick qemu-kvm
package.

(I hadn't noticed before, because I generally keep capslock set as an
additional control).

So this bug is, in fact fix committed.  It sounds like you have a differnet bug relating
to your keyboard layout.  Please do open a new bug for it.

** Changed in: qemu-kvm (Ubuntu)
       Status: New => Fix Released

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (5 preceding siblings ...)
  2010-11-18  1:56 ` Serge Hallyn
@ 2010-11-18 23:46 ` Benjamin Drung
  2010-11-19  3:20   ` [Qemu-devel] " Serge Hallyn
  2010-11-18 23:47 ` [Qemu-devel] " Benjamin Drung
                   ` (17 subsequent siblings)
  24 siblings, 1 reply; 33+ messages in thread
From: Benjamin Drung @ 2010-11-18 23:46 UTC (permalink / raw)
  To: qemu-devel

I am reopening the bug again, because I am the original bug reporter and
this bug depends on the keyboard layout.

** Summary changed:

- does not pass pressed caps lock to client
+ kvm sends caps lock key up event twice

** Changed in: qemu-kvm (Ubuntu)
       Status: Fix Released => New

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (6 preceding siblings ...)
  2010-11-18 23:46 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Benjamin Drung
@ 2010-11-18 23:47 ` Benjamin Drung
  2010-11-19  3:19   ` [Qemu-devel] " Serge Hallyn
  2010-11-19  9:26 ` [Qemu-devel] " Benjamin Drung
                   ` (16 subsequent siblings)
  24 siblings, 1 reply; 33+ messages in thread
From: Benjamin Drung @ 2010-11-18 23:47 UTC (permalink / raw)
  To: qemu-devel

libsdl1.2 does not send an key up event for the host caps lock key, but
does send the key up event if the physical caps lock key is mapped to
another key (like NEO2 does). qemu-kvm works around this bug by sending
a key up event for every caps lock key event. The attached patch fixes
the bug for me. Can you test, if the caps lock behavior still works for
you?

** Patch added: "caps-key-up-event.patch"
   https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1737741/+files/caps-key-up-event.patch

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] Re: [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-18 23:47 ` [Qemu-devel] " Benjamin Drung
@ 2010-11-19  3:19   ` Serge Hallyn
  0 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-19  3:19 UTC (permalink / raw)
  To: qemu-devel

Quoting Benjamin Drung (benjamin.drung@gmail.com):
> libsdl1.2 does not send an key up event for the host caps lock key, but
> does send the key up event if the physical caps lock key is mapped to
> another key (like NEO2 does).

Right, and when I have capslock mapped to control as I usually do, then
I do get a keyup event:

Capslock turning on:
sdl_process_key({type=0x2,which=0x0,state=0x1,keysym={scancode=0x42,sym=0x12d,mod=0x2000,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

capslock turning off:

sdl_process_key({type=0x3,which=0x0,state=0x0,keysym={scancode=0x42,sym=0x12d,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

> qemu-kvm works around this bug by sending
> a key up event for every caps lock key event. The attached patch fixes
> the bug for me. Can you test, if the caps lock behavior still works for
> you?

Actually, I may not get a chance for another two weeks.  Can we
get someone else to test?

thanks,
-serge

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] Re: [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-18 23:46 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Benjamin Drung
@ 2010-11-19  3:20   ` Serge Hallyn
  0 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-19  3:20 UTC (permalink / raw)
  To: qemu-devel

Quoting Benjamin Drung (benjamin.drung@gmail.com):
> I am reopening the bug again, because I am the original bug reporter and

Haha - then of course it's appropriate :)  Though the description might
then not be right.

> this bug depends on the keyboard layout.

-serge

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". It seems that the pressed caps lock is not passed to the client.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:
 
PccardctlStatus:
 
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (7 preceding siblings ...)
  2010-11-18 23:47 ` [Qemu-devel] " Benjamin Drung
@ 2010-11-19  9:26 ` Benjamin Drung
  2010-11-19 13:52 ` Serge Hallyn
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-19  9:26 UTC (permalink / raw)
  To: qemu-devel

You mean "press caps lock" with "capslock turning on" and "release caps
lock" with "capslock turning off"?

** Description changed:

  Binary package hint: qemu-kvm
  
  I have set the keyboard layout to German NEO 2 [1] in the host and the
  client (both current karmic). The caps lock is used as modifier (similar
  to shift) in NEO. When I press "caps lock" + "t", then the client prints
- a "t" instead of a "-". It seems that the pressed caps lock is not
- passed to the client.
+ a "t" instead of a "-". A caps lock key up event is sent to the client
+ before I release the caps lock key.
  
  [1] http://www.neo-layout.org/
  
  ProblemType: Bug
  Architecture: amd64
  Date: Fri Sep 11 01:38:58 2009
  DistroRelease: Ubuntu 9.10
  KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
  Package: qemu-kvm 0.11.0~rc2-0ubuntu2
  PccardctlIdent:
-  
+ 
  PccardctlStatus:
-  
+ 
  ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
  ProcEnviron:
-  LANG=de_DE.UTF-8
-  SHELL=/bin/bash
+  LANG=de_DE.UTF-8
+  SHELL=/bin/bash
  ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
  SourcePackage: qemu-kvm
  Uname: Linux 2.6.31-10-generic x86_64
  dmi.bios.date: 07/15/2009
  dmi.bios.vendor: Intel Corp.
  dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
  dmi.board.asset.tag: Base Board Asset Tag
  dmi.board.name: DG33TL
  dmi.board.vendor: Intel Corporation
  dmi.board.version: AAD89517-802
  dmi.chassis.type: 3
  dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (8 preceding siblings ...)
  2010-11-19  9:26 ` [Qemu-devel] " Benjamin Drung
@ 2010-11-19 13:52 ` Serge Hallyn
  2010-11-23  0:42 ` Benjamin Drung
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-19 13:52 UTC (permalink / raw)
  To: qemu-devel

Sorry, Benjamin, I cut-pasted the wrong bit.  When capslock is mapped to control on the
host, then I get:

key press:

sdl_process_key({type=0x2,which=0x0,state=0x1,keysym={scancode=0x42,sym=0x132,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

key up:

sdl_process_key({type=0x3,which=0x0,state=0x0,keysym={scancode=0x42,sym=0x132,mod=0x0,unicode=0x0}})
keycode = 0x3a
kbd_put_keycode(0x3a)
kbd_put_keycode(0xba)

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: Invalid
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (9 preceding siblings ...)
  2010-11-19 13:52 ` Serge Hallyn
@ 2010-11-23  0:42 ` Benjamin Drung
  2010-11-23 14:30   ` [Qemu-devel] " Serge Hallyn
  2010-11-23 19:03   ` [Qemu-devel] " Stefan Weil
  2010-11-23 14:53 ` Serge Hallyn
                   ` (13 subsequent siblings)
  24 siblings, 2 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-23  0:42 UTC (permalink / raw)
  To: qemu-devel

Attached the patch for qemu-kvm 0.13. This patch is tested on natty with
qemu-kvm 0.13.0+noroms-0ubuntu7 and the German and NEO2 keyboard layout.

** Patch added: "caps-lock-key-up-event.patch"
   https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1742131/+files/caps-lock-key-up-event.patch

** Changed in: qemu
       Status: Invalid => New

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] Re: [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-23  0:42 ` Benjamin Drung
@ 2010-11-23 14:30   ` Serge Hallyn
  2010-11-23 19:03   ` [Qemu-devel] " Stefan Weil
  1 sibling, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-23 14:30 UTC (permalink / raw)
  To: qemu-devel

Quoting Benjamin Drung (benjamin.drung@gmail.com):
> Attached the patch for qemu-kvm 0.13. This patch is tested on natty with
> qemu-kvm 0.13.0+noroms-0ubuntu7 and the German and NEO2 keyboard layout.

Thanks, Benjamin.  I will propose this patch for merge as soon as some
technical difficulties with the natty/qemu-kvm tree are straightened
out.  Hopefully tomorrow.

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (10 preceding siblings ...)
  2010-11-23  0:42 ` Benjamin Drung
@ 2010-11-23 14:53 ` Serge Hallyn
  2010-11-24 21:13 ` Launchpad Bug Tracker
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-23 14:53 UTC (permalink / raw)
  To: qemu-devel

Thanks, Benjamin.  I've pushed your fix to a ppa in
https://launchpad.net/~serge-hallyn/+archive/qemu-capslock
for testing.  I'd like someone with a standard keyboard with
capslock not remapped to give this a spin, then I'll propose the
fix for merge into the natty tree (after which it can be SRU'd into
maverick).

If noone gets to it before then, I can test it next week.  This week,
unfortunately, I can't do it myself.

** Changed in: qemu-kvm (Ubuntu)
       Status: New => In Progress

** Changed in: qemu-kvm (Ubuntu)
     Assignee: (unassigned) => Serge Hallyn (serge-hallyn)

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-23  0:42 ` Benjamin Drung
  2010-11-23 14:30   ` [Qemu-devel] " Serge Hallyn
@ 2010-11-23 19:03   ` Stefan Weil
  1 sibling, 0 replies; 33+ messages in thread
From: Stefan Weil @ 2010-11-23 19:03 UTC (permalink / raw)
  To: Bug 427612; +Cc: Benjamin Drung, qemu-devel

Am 23.11.2010 01:42, schrieb Benjamin Drung:
> Attached the patch for qemu-kvm 0.13. This patch is tested on natty with
> qemu-kvm 0.13.0+noroms-0ubuntu7 and the German and NEO2 keyboard layout.
>
> ** Patch added: "caps-lock-key-up-event.patch"
> https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1742131/+files/caps-lock-key-up-event.patch
>
> ** Changed in: qemu
> Status: Invalid => New
>

The patch might fix part of the problem, but there remain more issues:

* SDL also sends an SDL_KEYUP event for caps lock when the
   environment variable SDL_DISABLE_LOCK_KEYS is set.
   This mode is very useful but currently unsupported by qemu/kvm.

* Num lock and caps lock are handled in a similar way by SDL.
   The patch only handles caps lock. Maybe this is less important
   because keyboard layouts which remap num lock are rare
   (I don't know any).

* The keyboard status LEDs and the qemu client's keyboard status
   can become unsynchronized if the input focus changes from qemu
   to other applications.

Regards,

Stefan Weil

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (11 preceding siblings ...)
  2010-11-23 14:53 ` Serge Hallyn
@ 2010-11-24 21:13 ` Launchpad Bug Tracker
  2010-11-24 21:15 ` Benjamin Drung
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-11-24 21:13 UTC (permalink / raw)
  To: qemu-devel

** Branch linked: lp:~bdrung/qemu-kvm/caps-lock-key-up-event

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (12 preceding siblings ...)
  2010-11-24 21:13 ` Launchpad Bug Tracker
@ 2010-11-24 21:15 ` Benjamin Drung
  2010-11-24 21:23 ` Launchpad Bug Tracker
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-24 21:15 UTC (permalink / raw)
  To: qemu-devel

** Also affects: libsdl1.2 (Ubuntu Maverick)
   Importance: Undecided
       Status: New

** Also affects: qemu-kvm (Ubuntu Maverick)
   Importance: Undecided
       Status: New

** Changed in: libsdl1.2 (Ubuntu Maverick)
       Status: New => Invalid

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (13 preceding siblings ...)
  2010-11-24 21:15 ` Benjamin Drung
@ 2010-11-24 21:23 ` Launchpad Bug Tracker
  2010-11-24 21:44 ` Benjamin Drung
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-11-24 21:23 UTC (permalink / raw)
  To: qemu-devel

** Branch linked: lp:~bdrung/qemu-kvm/caps-lock-key-up-event.maverick

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (14 preceding siblings ...)
  2010-11-24 21:23 ` Launchpad Bug Tracker
@ 2010-11-24 21:44 ` Benjamin Drung
  2010-11-25 20:08   ` Stefan Weil
  2010-11-24 23:31 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Serge Hallyn
                   ` (8 subsequent siblings)
  24 siblings, 1 reply; 33+ messages in thread
From: Benjamin Drung @ 2010-11-24 21:44 UTC (permalink / raw)
  To: qemu-devel

Attached a new version of my patch. You find two branches linked to this
bug for maverick and natty. The patch sets SDL_DISABLE_LOCK_KEYS and get
rid of the complete workaround in qemu-kvm. This requires SDL >= 1.2.14.

Stefan Weil wrote:
>The patch might fix part of the problem, but there remain more issues:
> 
> * SDL also sends an SDL_KEYUP event for caps lock when the
>    environment variable SDL_DISABLE_LOCK_KEYS is set.
>    This mode is very useful but currently unsupported by qemu/kvm.

Addressed by new patch.

> * Num lock and caps lock are handled in a similar way by SDL.
>    The patch only handles caps lock. Maybe this is less important
>    because keyboard layouts which remap num lock are rare
>    (I don't know any).

Addressed by new patch.

> * The keyboard status LEDs and the qemu client's keyboard status
>    can become unsynchronized if the input focus changes from qemu
>    to other applications.

Is this a regression of my patch or is it the case for the unpatched
qemu too?

** Patch added: "caps-lock-key-up-event-v2.patch"
   https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1743919/+files/caps-lock-key-up-event-v2.patch

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (15 preceding siblings ...)
  2010-11-24 21:44 ` Benjamin Drung
@ 2010-11-24 23:31 ` Serge Hallyn
  2010-11-25 23:45 ` Launchpad Bug Tracker
                   ` (7 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Serge Hallyn @ 2010-11-24 23:31 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu-kvm (Ubuntu)
     Assignee: Serge Hallyn (serge-hallyn) => (unassigned)

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: In Progress
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: New
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-24 21:44 ` Benjamin Drung
@ 2010-11-25 20:08   ` Stefan Weil
  2010-11-27 23:48     ` Benjamin Drung
  0 siblings, 1 reply; 33+ messages in thread
From: Stefan Weil @ 2010-11-25 20:08 UTC (permalink / raw)
  To: Bug 427612; +Cc: Benjamin Drung, qemu-devel

Am 24.11.2010 22:44, schrieb Benjamin Drung:
> Attached a new version of my patch. You find two branches linked to this
> bug for maverick and natty. The patch sets SDL_DISABLE_LOCK_KEYS and get
> rid of the complete workaround in qemu-kvm. This requires SDL >= 1.2.14.

For newer versions of SDL (those which use SDL_DISABLE_LOCK_KEYS
to disable special handling of the lock keys), your patch looks ok.
It is a working solution for maintainers of the latest Ubuntu releases.

But what about older versions? For those, your patch will make QEMU's
keyboard emulation unusable. Most older versions don't know
SDL_DISABLE_LOCK_KEYS. As far as I know, some SDL versions (from Debian
and Ubuntu) even used SDL_DISABLE_LOCK_KEYS with an inverted meaning.

I don't think we can simply ignore old or incompatible versions of SDL.
Therefore I suggest adding a runtime version check, so the emulation
can either use the old code (SDL < 1.2.14) or your new code (SDL >= 1.2.14).

The crucial point is whether "old" versions must be supported or not.
This is something which the QEMU community should decide.

> Stefan Weil wrote:
>> The patch might fix part of the problem, but there remain more issues:
>>
>> * SDL also sends an SDL_KEYUP event for caps lock when the
>> environment variable SDL_DISABLE_LOCK_KEYS is set.
>> This mode is very useful but currently unsupported by qemu/kvm.
>
> Addressed by new patch.
>
>> * Num lock and caps lock are handled in a similar way by SDL.
>> The patch only handles caps lock. Maybe this is less important
>> because keyboard layouts which remap num lock are rare
>> (I don't know any).
>
> Addressed by new patch.
>
>> * The keyboard status LEDs and the qemu client's keyboard status
>> can become unsynchronized if the input focus changes from qemu
>> to other applications.
>
> Is this a regression of my patch or is it the case for the unpatched
> qemu too?

That is no regression, but a weakness which existed from the
beginning. Your patch neither makes it better nor makes it worse.

>
> ** Patch added: "caps-lock-key-up-event-v2.patch"
> https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1743919/+files/caps-lock-key-up-event-v2.patch

Just a small remark:
Inline patches (instead of links) are preferred on qemu-devel
because they make reading easier, and it's also easier for reviewers
to add comments.

Regards,
Stefan

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (16 preceding siblings ...)
  2010-11-24 23:31 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Serge Hallyn
@ 2010-11-25 23:45 ` Launchpad Bug Tracker
  2010-11-25 23:50 ` Benjamin Drung
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-11-25 23:45 UTC (permalink / raw)
  To: qemu-devel

This bug was fixed in the package qemu-kvm - 0.13.0+noroms-0ubuntu8

---------------
qemu-kvm (0.13.0+noroms-0ubuntu8) natty; urgency=low

  * Add caps-lock-key-up-event.patch to enable normal up/down events for
    Caps-Lock and Num-Lock keys by setting SDL_DISABLE_LOCK_KEYS (which
    requires SDL > 1.2.14). This fixes handling of capslock when capslock is
    mapped to something else in host system. (LP: #427612)
 -- Benjamin Drung <bdrung@ubuntu.com>   Wed, 24 Nov 2010 21:46:44 +0100

** Changed in: qemu-kvm (Ubuntu)
       Status: In Progress => Fix Released

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: Fix Committed
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (17 preceding siblings ...)
  2010-11-25 23:45 ` Launchpad Bug Tracker
@ 2010-11-25 23:50 ` Benjamin Drung
  2010-12-03 16:15 ` Martin Pitt
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-11-25 23:50 UTC (permalink / raw)
  To: qemu-devel

Attached the uploaded debdiff for maverick.

** Patch added: "qemu-kvm_0.12.5+noroms-0ubuntu7.1.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1745373/+files/qemu-kvm_0.12.5%2Bnoroms-0ubuntu7.1.debdiff

** Changed in: qemu-kvm (Ubuntu Maverick)
       Status: New => Fix Committed

-- 
kvm sends caps lock key up event twice
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “libsdl1.2” package in Ubuntu: Invalid
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “libsdl1.2” source package in Maverick: Invalid
Status in “qemu-kvm” source package in Maverick: Fix Committed
Status in “libsdl1.2” package in Debian: Fix Released

Bug description:
Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
  2010-11-25 20:08   ` Stefan Weil
@ 2010-11-27 23:48     ` Benjamin Drung
  2011-02-03 21:35       ` [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys Stefan Weil
  0 siblings, 1 reply; 33+ messages in thread
From: Benjamin Drung @ 2010-11-27 23:48 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 3196 bytes --]

Am Donnerstag, den 25.11.2010, 21:08 +0100 schrieb Stefan Weil:
> Am 24.11.2010 22:44, schrieb Benjamin Drung:
> > Attached a new version of my patch. You find two branches linked to this
> > bug for maverick and natty. The patch sets SDL_DISABLE_LOCK_KEYS and get
> > rid of the complete workaround in qemu-kvm. This requires SDL >= 1.2.14.
> 
> For newer versions of SDL (those which use SDL_DISABLE_LOCK_KEYS
> to disable special handling of the lock keys), your patch looks ok.
> It is a working solution for maintainers of the latest Ubuntu releases.
> 
> But what about older versions? For those, your patch will make QEMU's
> keyboard emulation unusable. Most older versions don't know
> SDL_DISABLE_LOCK_KEYS. As far as I know, some SDL versions (from Debian
> and Ubuntu) even used SDL_DISABLE_LOCK_KEYS with an inverted meaning.
> 
> I don't think we can simply ignore old or incompatible versions of SDL.
> Therefore I suggest adding a runtime version check, so the emulation
> can either use the old code (SDL < 1.2.14) or your new code (SDL >= 1.2.14).

Yes, that's better than not supporting older SDL versions.

> The crucial point is whether "old" versions must be supported or not.
> This is something which the QEMU community should decide.
> 
> > Stefan Weil wrote:
> >> The patch might fix part of the problem, but there remain more issues:
> >>
> >> * SDL also sends an SDL_KEYUP event for caps lock when the
> >> environment variable SDL_DISABLE_LOCK_KEYS is set.
> >> This mode is very useful but currently unsupported by qemu/kvm.
> >
> > Addressed by new patch.
> >
> >> * Num lock and caps lock are handled in a similar way by SDL.
> >> The patch only handles caps lock. Maybe this is less important
> >> because keyboard layouts which remap num lock are rare
> >> (I don't know any).
> >
> > Addressed by new patch.
> >
> >> * The keyboard status LEDs and the qemu client's keyboard status
> >> can become unsynchronized if the input focus changes from qemu
> >> to other applications.
> >
> > Is this a regression of my patch or is it the case for the unpatched
> > qemu too?
> 
> That is no regression, but a weakness which existed from the
> beginning. Your patch neither makes it better nor makes it worse.

I don't know if it can really fixed for all keyboard layout
combinations. Imagine using two keyboard layouts that have the caps lock
key mapped on different keys. How do you want to keep the caps lock
synchronized?

> > ** Patch added: "caps-lock-key-up-event-v2.patch"
> > https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/427612/+attachment/1743919/+files/caps-lock-key-up-event-v2.patch
> 
> Just a small remark:
> Inline patches (instead of links) are preferred on qemu-devel
> because they make reading easier, and it's also easier for reviewers
> to add comments.

You request a new feature for Launchpad, because I used Launchpad to
attach my patch. Look at https://launchpad.net/bugs/427612 . All
comments for bugs in the qemu-kvm Ubuntu package are forwarded to the
mailing list.

-- 
Benjamin Drung
Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (18 preceding siblings ...)
  2010-11-25 23:50 ` Benjamin Drung
@ 2010-12-03 16:15 ` Martin Pitt
  2010-12-03 17:51 ` Launchpad Bug Tracker
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Martin Pitt @ 2010-12-03 16:15 UTC (permalink / raw)
  To: qemu-devel

Accepted qemu-kvm into maverick-proposed, the package will build now and
be available in a few hours. Please test and give feedback here. See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed. Thank you in advance!

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  New
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Committed
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (19 preceding siblings ...)
  2010-12-03 16:15 ` Martin Pitt
@ 2010-12-03 17:51 ` Launchpad Bug Tracker
  2010-12-03 23:21 ` Benjamin Drung
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-12-03 17:51 UTC (permalink / raw)
  To: qemu-devel

** Branch linked: lp:ubuntu/maverick-proposed/qemu-kvm

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  New
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Committed
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (20 preceding siblings ...)
  2010-12-03 17:51 ` Launchpad Bug Tracker
@ 2010-12-03 23:21 ` Benjamin Drung
  2010-12-04 11:41 ` Jean-Baptiste Lallement
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 33+ messages in thread
From: Benjamin Drung @ 2010-12-03 23:21 UTC (permalink / raw)
  To: qemu-devel

I have installed the package from maverick-proposed and can confirm that
this bug is fixed by that version.

** Description changed:

  Binary package hint: qemu-kvm
  
  I have set the keyboard layout to German NEO 2 [1] in the host and the
  client (both current karmic). The caps lock is used as modifier (similar
  to shift) in NEO. When I press "caps lock" + "t", then the client prints
  a "t" instead of a "-". A caps lock key up event is sent to the client
  before I release the caps lock key.
  
  [1] http://www.neo-layout.org/
  
  ProblemType: Bug
  Architecture: amd64
  Date: Fri Sep 11 01:38:58 2009
  DistroRelease: Ubuntu 9.10
  KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
  Package: qemu-kvm 0.11.0~rc2-0ubuntu2
  PccardctlIdent:
  
  PccardctlStatus:
  
  ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
  ProcEnviron:
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
  SourcePackage: qemu-kvm
  Uname: Linux 2.6.31-10-generic x86_64
  dmi.bios.date: 07/15/2009
  dmi.bios.vendor: Intel Corp.
  dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
  dmi.board.asset.tag: Base Board Asset Tag
  dmi.board.name: DG33TL
  dmi.board.vendor: Intel Corporation
  dmi.board.version: AAD89517-802
  dmi.chassis.type: 3
  dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:
+ 
+ TEST CASE: Select NEO2 as keyboard layout in your guest system and press
+ 'caps lock' + 't'. A '-' should appear.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  New
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Committed
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

TEST CASE: Select NEO2 as keyboard layout in your guest system and press 'caps lock' + 't'. A '-' should appear.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (21 preceding siblings ...)
  2010-12-03 23:21 ` Benjamin Drung
@ 2010-12-04 11:41 ` Jean-Baptiste Lallement
  2010-12-09 10:55 ` Launchpad Bug Tracker
  2012-09-14  9:00 ` Paolo Bonzini
  24 siblings, 0 replies; 33+ messages in thread
From: Jean-Baptiste Lallement @ 2010-12-04 11:41 UTC (permalink / raw)
  To: qemu-devel

** Tags added: verification-done
** Tags removed: verification-needed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  New
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Committed
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

TEST CASE: Select NEO2 as keyboard layout in your guest system and press 'caps lock' + 't'. A '-' should appear.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (22 preceding siblings ...)
  2010-12-04 11:41 ` Jean-Baptiste Lallement
@ 2010-12-09 10:55 ` Launchpad Bug Tracker
  2012-09-14  9:00 ` Paolo Bonzini
  24 siblings, 0 replies; 33+ messages in thread
From: Launchpad Bug Tracker @ 2010-12-09 10:55 UTC (permalink / raw)
  To: qemu-devel

This bug was fixed in the package qemu-kvm - 0.12.5+noroms-0ubuntu7.1

---------------
qemu-kvm (0.12.5+noroms-0ubuntu7.1) maverick-proposed; urgency=low

  * Add caps-lock-key-up-event.patch to enable normal up/down events for
    Caps-Lock and Num-Lock keys by setting SDL_DISABLE_LOCK_KEYS (which
    requires SDL > 1.2.14). This fixes handling of capslock when capslock is
    mapped to something else in host system. (LP: #427612)
 -- Benjamin Drung <bdrung@ubuntu.com>   Wed, 24 Nov 2010 15:35:10 +0100

** Changed in: qemu-kvm (Ubuntu Maverick)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  New
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Released
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

I have set the keyboard layout to German NEO 2 [1] in the host and the client (both current karmic). The caps lock is used as modifier (similar to shift) in NEO. When I press "caps lock" + "t", then the client prints a "t" instead of a "-". A caps lock key up event is sent to the client before I release the caps lock key.

[1] http://www.neo-layout.org/

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 11 01:38:58 2009
DistroRelease: Ubuntu 9.10
KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
Package: qemu-kvm 0.11.0~rc2-0ubuntu2
PccardctlIdent:

PccardctlStatus:

ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
SourcePackage: qemu-kvm
Uname: Linux 2.6.31-10-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DG33TL
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD89517-802
dmi.chassis.type: 3
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

TEST CASE: Select NEO2 as keyboard layout in your guest system and press 'caps lock' + 't'. A '-' should appear.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys
  2010-11-27 23:48     ` Benjamin Drung
@ 2011-02-03 21:35       ` Stefan Weil
  2011-02-04 12:51         ` Anthony Liguori
  0 siblings, 1 reply; 33+ messages in thread
From: Stefan Weil @ 2011-02-03 21:35 UTC (permalink / raw)
  To: QEMU Developers; +Cc: Kevin Wolf, Anthony Liguori, Benjamin Drung

Starting with SDL version 1.2.14, caps lock and num lock keys
will send a SDL_KEYUP when SDL_DISABLE_LOCK_KEYS=1 is set in
the environment.

The new code sets the environment unconditionally
(it won't harm old versions which do not know it).

The workaround for SDL_KEYUP is only compiled with old SDL versions.

A similar patch without handling of old SDL versions was already
published by Benjamin Drung for Ubuntu.

Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Benjamin Drung <benjamin.drung@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 ui/sdl.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ui/sdl.c b/ui/sdl.c
index a1458ce..47ac49c 100644
--- a/ui/sdl.c
+++ b/ui/sdl.c
@@ -388,12 +388,16 @@ static void sdl_process_key(SDL_KeyboardEvent *ev)
         else
             modifiers_state[keycode] = 1;
         break;
+#define QEMU_SDL_VERSION ((SDL_MAJOR_VERSION << 8) + SDL_MINOR_VERSION)
+#if QEMU_SDL_VERSION < 0x102 || QEMU_SDL_VERSION == 0x102 && SDL_PATCHLEVEL < 14
+        /* SDL versions before 1.2.14 don't support key up for caps/num lock. */
     case 0x45: /* num lock */
     case 0x3a: /* caps lock */
         /* SDL does not send the key up event, so we generate it */
         kbd_put_keycode(keycode);
         kbd_put_keycode(keycode | SCANCODE_UP);
         return;
+#endif
     }
 
     /* now send the key code */
@@ -831,6 +835,10 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_frame)
         setenv("SDL_VIDEO_ALLOW_SCREENSAVER", "1", 0);
     }
 
+    /* Enable normal up/down events for Caps-Lock and Num-Lock keys.
+     * This requires SDL >= 1.2.14. */
+    setenv("SDL_DISABLE_LOCK_KEYS", "1", 1);
+
     flags = SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE;
     if (SDL_Init (flags)) {
         fprintf(stderr, "Could not initialize SDL(%s) - exiting\n",
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 33+ messages in thread

* Re: [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys
  2011-02-03 21:35       ` [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys Stefan Weil
@ 2011-02-04 12:51         ` Anthony Liguori
  0 siblings, 0 replies; 33+ messages in thread
From: Anthony Liguori @ 2011-02-04 12:51 UTC (permalink / raw)
  To: Stefan Weil; +Cc: Kevin Wolf, Anthony Liguori, Benjamin Drung, QEMU Developers

On 02/03/2011 03:35 PM, Stefan Weil wrote:
> Starting with SDL version 1.2.14, caps lock and num lock keys
> will send a SDL_KEYUP when SDL_DISABLE_LOCK_KEYS=1 is set in
> the environment.
>
> The new code sets the environment unconditionally
> (it won't harm old versions which do not know it).
>
> The workaround for SDL_KEYUP is only compiled with old SDL versions.
>
> A similar patch without handling of old SDL versions was already
> published by Benjamin Drung for Ubuntu.
>
> Cc: Anthony Liguori<aliguori@us.ibm.com>
> Cc: Kevin Wolf<kwolf@redhat.com>
> Cc: Benjamin Drung<benjamin.drung@gmail.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    

Applied to master, Thanks.

Regards,

Anthony Liguori
> ---
>   ui/sdl.c |    8 ++++++++
>   1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/ui/sdl.c b/ui/sdl.c
> index a1458ce..47ac49c 100644
> --- a/ui/sdl.c
> +++ b/ui/sdl.c
> @@ -388,12 +388,16 @@ static void sdl_process_key(SDL_KeyboardEvent *ev)
>           else
>               modifiers_state[keycode] = 1;
>           break;
> +#define QEMU_SDL_VERSION ((SDL_MAJOR_VERSION<<  8) + SDL_MINOR_VERSION)
> +#if QEMU_SDL_VERSION<  0x102 || QEMU_SDL_VERSION == 0x102&&  SDL_PATCHLEVEL<  14
> +        /* SDL versions before 1.2.14 don't support key up for caps/num lock. */
>       case 0x45: /* num lock */
>       case 0x3a: /* caps lock */
>           /* SDL does not send the key up event, so we generate it */
>           kbd_put_keycode(keycode);
>           kbd_put_keycode(keycode | SCANCODE_UP);
>           return;
> +#endif
>       }
>
>       /* now send the key code */
> @@ -831,6 +835,10 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_frame)
>           setenv("SDL_VIDEO_ALLOW_SCREENSAVER", "1", 0);
>       }
>
> +    /* Enable normal up/down events for Caps-Lock and Num-Lock keys.
> +     * This requires SDL>= 1.2.14. */
> +    setenv("SDL_DISABLE_LOCK_KEYS", "1", 1);
> +
>       flags = SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE;
>       if (SDL_Init (flags)) {
>           fprintf(stderr, "Could not initialize SDL(%s) - exiting\n",
>    

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice
       [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
                   ` (23 preceding siblings ...)
  2010-12-09 10:55 ` Launchpad Bug Tracker
@ 2012-09-14  9:00 ` Paolo Bonzini
  24 siblings, 0 replies; 33+ messages in thread
From: Paolo Bonzini @ 2012-09-14  9:00 UTC (permalink / raw)
  To: qemu-devel

Fixed in upstream commit 4e79bcbb96d3c189e50adbdac7b1e28d834ba43e.

** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/427612

Title:
  kvm sends caps lock key up event twice

Status in QEMU:
  Fix Released
Status in “libsdl1.2” package in Ubuntu:
  Invalid
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “libsdl1.2” source package in Maverick:
  Invalid
Status in “qemu-kvm” source package in Maverick:
  Fix Released
Status in “libsdl1.2” package in Debian:
  Fix Released

Bug description:
  Binary package hint: qemu-kvm

  I have set the keyboard layout to German NEO 2 [1] in the host and the
  client (both current karmic). The caps lock is used as modifier
  (similar to shift) in NEO. When I press "caps lock" + "t", then the
  client prints a "t" instead of a "-". A caps lock key up event is sent
  to the client before I release the caps lock key.

  [1] http://www.neo-layout.org/

  ProblemType: Bug
  Architecture: amd64
  Date: Fri Sep 11 01:38:58 2009
  DistroRelease: Ubuntu 9.10
  KvmCmdLine: Error: command ['ps', '-C', 'kvm', '-F'] failed with exit code 1: UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
  Package: qemu-kvm 0.11.0~rc2-0ubuntu2
  PccardctlIdent:

  PccardctlStatus:

  ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-10-generic root=UUID=37b01f5a-a578-49d6-a812-f166b103e68a ro quiet splash
  ProcEnviron:
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  ProcVersionSignature: Ubuntu 2.6.31-10.31-generic
  SourcePackage: qemu-kvm
  Uname: Linux 2.6.31-10-generic x86_64
  dmi.bios.date: 07/15/2009
  dmi.bios.vendor: Intel Corp.
  dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
  dmi.board.asset.tag: Base Board Asset Tag
  dmi.board.name: DG33TL
  dmi.board.vendor: Intel Corporation
  dmi.board.version: AAD89517-802
  dmi.chassis.type: 3
  dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svn:pn:pvr:rvnIntelCorporation:rnDG33TL:rvrAAD89517-802:cvn:ct3:cvr:

  TEST CASE: Select NEO2 as keyboard layout in your guest system and
  press 'caps lock' + 't'. A '-' should appear.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/427612/+subscriptions

^ permalink raw reply	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2012-09-14  9:05 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20090910235343.14184.29717.malonedeb@gangotri.canonical.com>
2010-05-21 11:55 ` [Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client Launchpad Bug Tracker
2010-06-02 20:12 ` Anthony Liguori
2010-11-17 23:52 ` Benjamin Drung
2010-11-17 23:55 ` Benjamin Drung
2010-11-18  1:50 ` Serge Hallyn
2010-11-18  1:56 ` Serge Hallyn
2010-11-18 23:46 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Benjamin Drung
2010-11-19  3:20   ` [Qemu-devel] " Serge Hallyn
2010-11-18 23:47 ` [Qemu-devel] " Benjamin Drung
2010-11-19  3:19   ` [Qemu-devel] " Serge Hallyn
2010-11-19  9:26 ` [Qemu-devel] " Benjamin Drung
2010-11-19 13:52 ` Serge Hallyn
2010-11-23  0:42 ` Benjamin Drung
2010-11-23 14:30   ` [Qemu-devel] " Serge Hallyn
2010-11-23 19:03   ` [Qemu-devel] " Stefan Weil
2010-11-23 14:53 ` Serge Hallyn
2010-11-24 21:13 ` Launchpad Bug Tracker
2010-11-24 21:15 ` Benjamin Drung
2010-11-24 21:23 ` Launchpad Bug Tracker
2010-11-24 21:44 ` Benjamin Drung
2010-11-25 20:08   ` Stefan Weil
2010-11-27 23:48     ` Benjamin Drung
2011-02-03 21:35       ` [Qemu-devel] [PATCH 0.14] ui/sdl: Fix handling of caps lock and num lock keys Stefan Weil
2011-02-04 12:51         ` Anthony Liguori
2010-11-24 23:31 ` [Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice Serge Hallyn
2010-11-25 23:45 ` Launchpad Bug Tracker
2010-11-25 23:50 ` Benjamin Drung
2010-12-03 16:15 ` Martin Pitt
2010-12-03 17:51 ` Launchpad Bug Tracker
2010-12-03 23:21 ` Benjamin Drung
2010-12-04 11:41 ` Jean-Baptiste Lallement
2010-12-09 10:55 ` Launchpad Bug Tracker
2012-09-14  9:00 ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.