[PATCH 5/6] ath5k: Update version string

[PATCH 5/6] ath5k: Update version string

[Nick Kossifidis]

 * Change version number, we've added various new features lately.
 We need to find a way to maintain this, maybe on each kernel release
 or something. Also remove "EXPERIMENTAL", we aren't experimental any
 more I think ;-)

 Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>

---
 drivers/net/wireless/ath/ath5k/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 6edfa9f..835ab3a 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis");
 MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards.");
 MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards");
 MODULE_LICENSE("Dual BSD/GPL");
-MODULE_VERSION("0.6.0 (EXPERIMENTAL)");
+MODULE_VERSION("0.7.0");
 
 static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
 								bool skip_pcu);

Re: [PATCH 5/6] ath5k: Update version string

[Luis R. Rodriguez]

On Thu, Dec 2, 2010 at 8:11 PM, Nick Kossifidis <mickflemm@gmail.com> wrote:
>  * Change version number, we've added various new features lately.
>  We need to find a way to maintain this, maybe on each kernel release
>  or something. Also remove "EXPERIMENTAL", we aren't experimental any
>  more I think ;-)
>
>  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>

> +MODULE_VERSION("0.7.0");

How about just remove this all together, the version should go by the
kernel or git describe.

Luis

Re: [PATCH 5/6] ath5k: Update version string

[Sedat Dilek]

Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

On Fri, Dec 3, 2010 at 5:11 AM, Nick Kossifidis <mickflemm@gmail.com> wrote:
>  * Change version number, we've added various new features lately.
>  We need to find a way to maintain this, maybe on each kernel release
>  or something. Also remove "EXPERIMENTAL", we aren't experimental any
>  more I think ;-)
>
>  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>
> ---
>  drivers/net/wireless/ath/ath5k/base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 6edfa9f..835ab3a 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis");
>  MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards.");
>  MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards");
>  MODULE_LICENSE("Dual BSD/GPL");
> -MODULE_VERSION("0.6.0 (EXPERIMENTAL)");
> +MODULE_VERSION("0.7.0");
>
>  static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
>                                                                bool skip_pcu);
>

Re: [PATCH 5/6] ath5k: Update version string

[Sedat Dilek]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On Fri, Dec 3, 2010 at 5:11 AM, Nick Kossifidis <mickflemm@gmail.com> wrote:
>  * Change version number, we've added various new features lately.
>  We need to find a way to maintain this, maybe on each kernel release
>  or something. Also remove "EXPERIMENTAL", we aren't experimental any
>  more I think ;-)
>
>  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>
> ---
>  drivers/net/wireless/ath/ath5k/base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 6edfa9f..835ab3a 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis");
>  MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards.");
>  MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards");
>  MODULE_LICENSE("Dual BSD/GPL");
> -MODULE_VERSION("0.6.0 (EXPERIMENTAL)");
> +MODULE_VERSION("0.7.0");
>
>  static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
>                                                                bool skip_pcu);
>

Against linux-next (next-20101203) this patch needs a refresh (see attached v2).
Guess you created your patchset from wireless-testing.

- Sedat -

[-- Attachment #2: 5-6-ath5k-Update-version-string-v2.patch --]
[-- Type: plain/text, Size: 650 bytes --]

Re: [PATCH 5/6] ath5k: Update version string

[John W. Linville]

On Thu, Dec 02, 2010 at 08:17:41PM -0800, Luis R. Rodriguez wrote:
> On Thu, Dec 2, 2010 at 8:11 PM, Nick Kossifidis <mickflemm@gmail.com> wrote:
> >  * Change version number, we've added various new features lately.
> >  We need to find a way to maintain this, maybe on each kernel release
> >  or something. Also remove "EXPERIMENTAL", we aren't experimental any
> >  more I think ;-)
> >
> >  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
> 
> > +MODULE_VERSION("0.7.0");
> 
> How about just remove this all together, the version should go by the
> kernel or git describe.

ACK -- any objections?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 5/6] ath5k: Update version string

[Nick Kossifidis]

2010/12/3 John W. Linville <linville@tuxdriver.com>:
> On Thu, Dec 02, 2010 at 08:17:41PM -0800, Luis R. Rodriguez wrote:
>> On Thu, Dec 2, 2010 at 8:11 PM, Nick Kossifidis <mickflemm@gmail.com> wrote:
>> >  * Change version number, we've added various new features lately.
>> >  We need to find a way to maintain this, maybe on each kernel release
>> >  or something. Also remove "EXPERIMENTAL", we aren't experimental any
>> >  more I think ;-)
>> >
>> >  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>>
>> > +MODULE_VERSION("0.7.0");
>>
>> How about just remove this all together, the version should go by the
>> kernel or git describe.
>
> ACK -- any objections?
>
> John

I'm OK with it, seems reasonable, after all we track changes on the
wiki page per date with links to commits on git so there is no need to
maintain the version field...
http://wireless.kernel.org/en/users/Drivers/ath5k

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

[PATCH] ath5k: remove MODULE_VERSION

[John W. Linville]

Since this is updated manually and sporadically, it is fairly useless
anyway.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/ath/ath5k/base.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 380ff2f..15d6b6c 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -76,7 +76,6 @@ MODULE_AUTHOR("Nick Kossifidis");
 MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards.");
 MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards");
 MODULE_LICENSE("Dual BSD/GPL");
-MODULE_VERSION("0.6.0 (EXPERIMENTAL)");
 
 static int ath5k_init(struct ieee80211_hw *hw);
 static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
-- 
1.7.3.2