* [PATCH] arm: ecard: Fix compilation warning.
@ 2010-12-06 14:04 ` Marek Belisko
0 siblings, 0 replies; 6+ messages in thread
From: Marek Belisko @ 2010-12-06 14:04 UTC (permalink / raw)
To: Russell King; +Cc: linux-arm-kernel, linux-kernel, Marek Belisko
Fix following compilation warning:
arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
'device_register', declared with attribute warn_unused_result
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
arch/arm/kernel/ecard.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index eed2f79..da882b1 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
*ecp = ec;
slot_to_expcard[slot] = ec;
- device_register(&ec->dev);
-
+ rc = device_register(&ec->dev);
+ if (rc)
+ goto nodev;
+
return 0;
nodev:
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm: ecard: Fix compilation warning.
@ 2010-12-06 14:04 ` Marek Belisko
0 siblings, 0 replies; 6+ messages in thread
From: Marek Belisko @ 2010-12-06 14:04 UTC (permalink / raw)
To: linux-arm-kernel
Fix following compilation warning:
arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
'device_register', declared with attribute warn_unused_result
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
arch/arm/kernel/ecard.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index eed2f79..da882b1 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
*ecp = ec;
slot_to_expcard[slot] = ec;
- device_register(&ec->dev);
-
+ rc = device_register(&ec->dev);
+ if (rc)
+ goto nodev;
+
return 0;
nodev:
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: ecard: Fix compilation warning.
2010-12-06 14:04 ` Marek Belisko
@ 2010-12-06 14:05 ` Russell King - ARM Linux
-1 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2010-12-06 14:05 UTC (permalink / raw)
To: Marek Belisko; +Cc: linux-arm-kernel, linux-kernel
On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
> Fix following compilation warning:
> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
> 'device_register', declared with attribute warn_unused_result
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> arch/arm/kernel/ecard.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
> index eed2f79..da882b1 100644
> --- a/arch/arm/kernel/ecard.c
> +++ b/arch/arm/kernel/ecard.c
> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
> *ecp = ec;
> slot_to_expcard[slot] = ec;
>
> - device_register(&ec->dev);
> -
> + rc = device_register(&ec->dev);
> + if (rc)
> + goto nodev;
> +
> return 0;
No. It is important that cards which are actually there remain present
even if device_register fails. In other words, we _really_ don't care
what device_register() returns.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: ecard: Fix compilation warning.
@ 2010-12-06 14:05 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2010-12-06 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
> Fix following compilation warning:
> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
> 'device_register', declared with attribute warn_unused_result
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> arch/arm/kernel/ecard.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
> index eed2f79..da882b1 100644
> --- a/arch/arm/kernel/ecard.c
> +++ b/arch/arm/kernel/ecard.c
> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
> *ecp = ec;
> slot_to_expcard[slot] = ec;
>
> - device_register(&ec->dev);
> -
> + rc = device_register(&ec->dev);
> + if (rc)
> + goto nodev;
> +
> return 0;
No. It is important that cards which are actually there remain present
even if device_register fails. In other words, we _really_ don't care
what device_register() returns.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: ecard: Fix compilation warning.
2010-12-06 14:05 ` Russell King - ARM Linux
@ 2010-12-06 19:11 ` Belisko Marek
-1 siblings, 0 replies; 6+ messages in thread
From: Belisko Marek @ 2010-12-06 19:11 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-arm-kernel, linux-kernel
On Mon, Dec 6, 2010 at 3:05 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
>> Fix following compilation warning:
>> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
>> 'device_register', declared with attribute warn_unused_result
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>> arch/arm/kernel/ecard.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
>> index eed2f79..da882b1 100644
>> --- a/arch/arm/kernel/ecard.c
>> +++ b/arch/arm/kernel/ecard.c
>> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
>> *ecp = ec;
>> slot_to_expcard[slot] = ec;
>>
>> - device_register(&ec->dev);
>> -
>> + rc = device_register(&ec->dev);
>> + if (rc)
>> + goto nodev;
>> +
>> return 0;
>
> No. It is important that cards which are actually there remain present
> even if device_register fails. In other words, we _really_ don't care
> what device_register() returns.
OK understand but anyway to stop compiler bark following could be OK and
maybe other people saw error and try to send same patch so keep them informed.
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index eed2f79..d3dcb1a 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -1062,8 +1062,12 @@ ecard_probe(int slot, card_type_t type)
*ecp = ec;
slot_to_expcard[slot] = ec;
-
- device_register(&ec->dev);
+ /*
+ * Return value not checked. It is important that cards
+ * which are actually there remain present even if
+ * device_register fails.
+ */
+ rc = device_register(&ec->dev);
return 0;
>
thanks,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm: ecard: Fix compilation warning.
@ 2010-12-06 19:11 ` Belisko Marek
0 siblings, 0 replies; 6+ messages in thread
From: Belisko Marek @ 2010-12-06 19:11 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Dec 6, 2010 at 3:05 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
>> Fix following compilation warning:
>> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
>> 'device_register', declared with attribute warn_unused_result
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>> ?arch/arm/kernel/ecard.c | ? ?6 ++++--
>> ?1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
>> index eed2f79..da882b1 100644
>> --- a/arch/arm/kernel/ecard.c
>> +++ b/arch/arm/kernel/ecard.c
>> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
>> ? ? ? *ecp = ec;
>> ? ? ? slot_to_expcard[slot] = ec;
>>
>> - ? ? device_register(&ec->dev);
>> -
>> + ? ? rc = device_register(&ec->dev);
>> + ? ? if (rc)
>> + ? ? ? ? ? ? goto nodev;
>> +
>> ? ? ? return 0;
>
> No. ?It is important that cards which are actually there remain present
> even if device_register fails. ?In other words, we _really_ don't care
> what device_register() returns.
OK understand but anyway to stop compiler bark following could be OK and
maybe other people saw error and try to send same patch so keep them informed.
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index eed2f79..d3dcb1a 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -1062,8 +1062,12 @@ ecard_probe(int slot, card_type_t type)
*ecp = ec;
slot_to_expcard[slot] = ec;
-
- device_register(&ec->dev);
+ /*
+ * Return value not checked. It is important that cards
+ * which are actually there remain present even if
+ * device_register fails.
+ */
+ rc = device_register(&ec->dev);
return 0;
>
thanks,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-06 19:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-06 14:04 [PATCH] arm: ecard: Fix compilation warning Marek Belisko
2010-12-06 14:04 ` Marek Belisko
2010-12-06 14:05 ` Russell King - ARM Linux
2010-12-06 14:05 ` Russell King - ARM Linux
2010-12-06 19:11 ` Belisko Marek
2010-12-06 19:11 ` Belisko Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.