From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: "Maciej W. Rozycki" <macro-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: Matt Turner <mattst88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org"
<linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts
Date: Tue, 7 Dec 2010 06:41:50 -0800 [thread overview]
Message-ID: <20101207144150.GA21872@ericsson.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1012070740130.17185-FBDaDh2CBnQu/uO211tRtWD2FQJk+8+b@public.gmane.org>
On Tue, Dec 07, 2010 at 09:30:27AM -0500, Maciej W. Rozycki wrote:
> On Mon, 6 Dec 2010, Guenter Roeck wrote:
>
> > A quick look through sb1250 vs. sb1480 code shows that the 1480 uses different
> > interrupt numbers. The patch assigns the sb1250 interrupt numbers, so unless
> > I am missing something the code as written can not work for sb1480.
>
> That well could be -- I never had access to a BigSur board. The
> board-specific interrupt numbers should either be available from the board
> manual (I haven't checked if one has been released; I certainly have one
> for my SWARM) or quoted somewhere in our tree. Otherwise figuring them
> out by trial and error should be a trivial exercise for someone with
> actual hardware at hand.
>
I already sent a reply to the original patch - I confirmed that the interrupts are different.
Those are SOC interrupts, so they are CPU specific, not board specific. Code started working
after I replaced the sb1250 interrupts with bcm1480 interrupts.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Matt Turner <mattst88@gmail.com>,
Jean Delvare <khali@linux-fr.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts
Date: Tue, 7 Dec 2010 06:41:50 -0800 [thread overview]
Message-ID: <20101207144150.GA21872@ericsson.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1012070740130.17185@eddie.linux-mips.org>
On Tue, Dec 07, 2010 at 09:30:27AM -0500, Maciej W. Rozycki wrote:
> On Mon, 6 Dec 2010, Guenter Roeck wrote:
>
> > A quick look through sb1250 vs. sb1480 code shows that the 1480 uses different
> > interrupt numbers. The patch assigns the sb1250 interrupt numbers, so unless
> > I am missing something the code as written can not work for sb1480.
>
> That well could be -- I never had access to a BigSur board. The
> board-specific interrupt numbers should either be available from the board
> manual (I haven't checked if one has been released; I certainly have one
> for my SWARM) or quoted somewhere in our tree. Otherwise figuring them
> out by trial and error should be a trivial exercise for someone with
> actual hardware at hand.
>
I already sent a reply to the original patch - I confirmed that the interrupts are different.
Those are SOC interrupts, so they are CPU specific, not board specific. Code started working
after I replaced the sb1250 interrupts with bcm1480 interrupts.
Guenter
next prev parent reply other threads:[~2010-12-07 14:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 6:38 [PATCH] I2C: SiByte: Convert the driver to make use of interrupts Matt Turner
[not found] ` <1291617494-18430-1-git-send-email-mattst88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-12-06 14:59 ` Guenter Roeck
2010-12-06 14:59 ` Guenter Roeck
2010-12-06 17:30 ` Guenter Roeck
2010-12-06 17:30 ` Guenter Roeck
[not found] ` <20101206173040.GA18372-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-12-06 17:40 ` Matt Turner
2010-12-06 17:40 ` Matt Turner
[not found] ` <AANLkTikGgfBuj086eRvy4VzzyE2suJCL9z=SfmOiFiPx-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-06 18:02 ` Guenter Roeck
2010-12-06 18:02 ` Guenter Roeck
2010-12-06 18:04 ` Matt Turner
2010-12-06 17:56 ` Maciej W. Rozycki
[not found] ` <alpine.LFD.2.00.1012061739200.17185-FBDaDh2CBnQu/uO211tRtWD2FQJk+8+b@public.gmane.org>
2010-12-06 18:02 ` Matt Turner
2010-12-06 18:02 ` Matt Turner
[not found] ` <AANLkTikWRsgHao_eb4W47b=E4vm6z=hi36JE_VBtD6Rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-07 2:26 ` Maciej W. Rozycki
2010-12-07 2:26 ` Maciej W. Rozycki
[not found] ` <alpine.LFD.2.00.1012070148050.17185-FBDaDh2CBnQu/uO211tRtWD2FQJk+8+b@public.gmane.org>
2010-12-07 5:14 ` Guenter Roeck
2010-12-07 5:14 ` Guenter Roeck
[not found] ` <20101207051438.GA20144-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-12-07 14:30 ` Maciej W. Rozycki
2010-12-07 14:30 ` Maciej W. Rozycki
[not found] ` <alpine.LFD.2.00.1012070740130.17185-FBDaDh2CBnQu/uO211tRtWD2FQJk+8+b@public.gmane.org>
2010-12-07 14:41 ` Guenter Roeck [this message]
2010-12-07 14:41 ` Guenter Roeck
2010-12-07 6:23 ` Guenter Roeck
2010-12-07 6:23 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2011-08-18 23:43 Matt Turner
2011-08-18 23:43 ` Matt Turner
[not found] ` <1313710991-3596-1-git-send-email-mattst88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-22 20:02 ` Guenter Roeck
2011-08-22 20:02 ` Guenter Roeck
2011-08-24 15:36 ` Matt Turner
2011-08-24 15:36 ` Matt Turner
[not found] ` <CAEdQ38E6qqVAKC1MkAWto5yeU9N2uoyGY1Y5431kNUNL_yc8EA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-02 13:21 ` Jean Delvare
2011-09-02 13:21 ` Jean Delvare
2011-09-02 13:35 ` Maciej W. Rozycki
2011-09-03 8:30 ` Jean Delvare
2011-09-03 8:30 ` Jean Delvare
[not found] ` <20110903103036.161616a5-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-10-31 9:53 ` Jean Delvare
2011-10-31 9:53 ` Jean Delvare
2011-10-31 9:53 ` Jean Delvare
[not found] ` <20111031105354.4b888e44-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-10 14:38 ` Jean Delvare
2012-01-10 14:38 ` Jean Delvare
2012-01-10 15:31 ` Maciej W. Rozycki
[not found] ` <20120110153834.531664db-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-12 21:19 ` Matt Turner
2012-01-12 21:19 ` Matt Turner
[not found] ` <CAEdQ38FpG11m50pwg2=tu1fJRRg=zixFKLsPmVPOzWNBCjbNBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-31 6:23 ` Jean Delvare
2012-03-31 6:23 ` Jean Delvare
[not found] ` <20120331082346.26cc95cb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-03-31 12:11 ` Matt Turner
2012-03-31 12:11 ` Matt Turner
[not found] ` <CAEdQ38Ez+8DudAaJY7HZu9jbisk_KMbBO5h=s+P4pjJ0Va-zWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-03 12:26 ` Maciej W. Rozycki
2012-04-03 12:26 ` Maciej W. Rozycki
2012-06-30 16:35 ` Matt Turner
2012-06-30 16:35 ` Matt Turner
[not found] ` <CAEdQ38EDKndUcdBu1tZ_dOuhweVRW6aA=YKb6kUE3gUQJiwWoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-19 21:01 ` Maciej W. Rozycki
2012-07-19 21:01 ` Maciej W. Rozycki
[not found] ` <alpine.LFD.2.00.1207160208570.12288-FBDaDh2CBnQu/uO211tRtWD2FQJk+8+b@public.gmane.org>
2012-12-18 12:08 ` Jean Delvare
2012-12-18 12:08 ` Jean Delvare
2012-12-18 12:08 ` Jean Delvare
2008-05-13 3:28 Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207144150.GA21872@ericsson.com \
--to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=macro-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=mattst88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.