All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable
@ 2010-12-07 15:27 Justin M. Forbes
  2011-01-09 17:33 ` [Qemu-devel] [Bug 686613] " Stefan Hajnoczi
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Justin M. Forbes @ 2010-12-07 15:27 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

 Filed from Fedora bug:
https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as
removable.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  New

Bug description:
   Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as removable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
@ 2011-01-09 17:33 ` Stefan Hajnoczi
  2011-01-11 10:07 ` Stefan Hajnoczi
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Stefan Hajnoczi @ 2011-01-09 17:33 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Confirmed

Bug description:
   Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as removable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
  2011-01-09 17:33 ` [Qemu-devel] [Bug 686613] " Stefan Hajnoczi
@ 2011-01-11 10:07 ` Stefan Hajnoczi
  2011-01-11 10:07 ` Stefan Hajnoczi
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Stefan Hajnoczi @ 2011-01-11 10:07 UTC (permalink / raw)
  To: qemu-devel

danpb has mentioned that Linux gets this information from SCSI INQUIRY
response.  So it's up to the USB Mass Storage Device to decide whether
or not it wants to have a removable medium.

The SCSI INQUIRY RMB (removable medium bit) tends to be set on modern
USB Mass Storage Devices.  Of course they don't actually have a
removable medium.

One side-effect of setting this bit is that Windows Auto-Run will work
if RMB=0 but not work if RMB=0.  Also, on RMB=1 devices only the first
partition is displayed by Windows - you can't have more than one
partition on the device.

For more information, see:
http://www.microsoft.com/whdc/connect/usb/usbfaq.mspx

So at the end of the day, it's up to QEMU whether or not to mark USB
MSDs as having removable media.  Since modern devices tend to set RMB=1,
we probably should too.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Confirmed

Bug description:
   Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as removable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
  2011-01-09 17:33 ` [Qemu-devel] [Bug 686613] " Stefan Hajnoczi
  2011-01-11 10:07 ` Stefan Hajnoczi
@ 2011-01-11 10:07 ` Stefan Hajnoczi
  2011-01-11 15:15 ` Stefan Hajnoczi
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Stefan Hajnoczi @ 2011-01-11 10:07 UTC (permalink / raw)
  To: qemu-devel

"One side-effect of setting this bit is that Windows Auto-Run will work
if RMB=0 but not work if RMB=0" should read "but not work if RMB=1".

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Confirmed

Bug description:
   Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as removable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
                   ` (2 preceding siblings ...)
  2011-01-11 10:07 ` Stefan Hajnoczi
@ 2011-01-11 15:15 ` Stefan Hajnoczi
  2011-01-11 16:22   ` Christoph Hellwig
  2012-07-02 15:04 ` Sebastian Malcolm
  2017-03-20 22:49 ` Thomas Huth
  5 siblings, 1 reply; 9+ messages in thread
From: Stefan Hajnoczi @ 2011-01-11 15:15 UTC (permalink / raw)
  To: qemu-devel

A sampling of physical USB devices:
1. Noname 2GB USB stick: RMB=1
2. Nexus One USB storage: RMB=1
3. LaCie USB harddisk: RMB=0

I suspect there's no setting that will satisfy everyone here.  It makes
sense for a USB harddisk to set RMB=0 because that allows you to put on
more than one partition under Windows.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Confirmed

Bug description:
   Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130

Guests can access USB Mass Storage Device, but fail to mark them as removable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2011-01-11 15:15 ` Stefan Hajnoczi
@ 2011-01-11 16:22   ` Christoph Hellwig
  0 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2011-01-11 16:22 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel

On Tue, Jan 11, 2011 at 03:15:46PM -0000, Stefan Hajnoczi wrote:
> A sampling of physical USB devices:
> 1. Noname 2GB USB stick: RMB=1
> 2. Nexus One USB storage: RMB=1
> 3. LaCie USB harddisk: RMB=0
> 
> I suspect there's no setting that will satisfy everyone here.  It makes
> sense for a USB harddisk to set RMB=0 because that allows you to put on
> more than one partition under Windows.

We can make it a qdev property.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
                   ` (3 preceding siblings ...)
  2011-01-11 15:15 ` Stefan Hajnoczi
@ 2012-07-02 15:04 ` Sebastian Malcolm
  2012-07-02 19:53   ` Stefan Hajnoczi
  2017-03-20 22:49 ` Thomas Huth
  5 siblings, 1 reply; 9+ messages in thread
From: Sebastian Malcolm @ 2012-07-02 15:04 UTC (permalink / raw)
  To: qemu-devel

Stefan, you fixed this  in QEMU 24 Jan 2011 so this bug can be marked as
Fixed Released?

SEE: http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg02425.html
Append ",removable=on" to a device definition for USB Mass Storage Devices to override the removable bit (but off by default):
> qemu -usb
>     -drive if=none,file=test.img,cache=none,id=disk0
>     -device usb-storage,drive=disk0,removable=on

However, I cannot see a way to set "removable=on" for usb-storage
devices started via libvirt (in 12.04, with libvirt-bin
0.9.8-2ubuntu17.1 and virt-manager 0.9.1-1ubuntu5.1).

So, is a feature request required for virt-manager to expose this option
for virtual disks (default to 'on' for bus='usb') and add support to
libvirt's XML to set "removable=on" ?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Confirmed

Bug description:
   Filed from Fedora bug:
  https://bugzilla.redhat.com/show_bug.cgi?id=589130

  Guests can access USB Mass Storage Device, but fail to mark them as
  removable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/686613/+subscriptions

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2012-07-02 15:04 ` Sebastian Malcolm
@ 2012-07-02 19:53   ` Stefan Hajnoczi
  0 siblings, 0 replies; 9+ messages in thread
From: Stefan Hajnoczi @ 2012-07-02 19:53 UTC (permalink / raw)
  To: Bug 686613; +Cc: qemu-devel

On Mon, Jul 2, 2012 at 4:04 PM, Sebastian Malcolm
<686613@bugs.launchpad.net> wrote:
> Stefan, you fixed this  in QEMU 24 Jan 2011 so this bug can be marked as
> Fixed Released?

Yes

> However, I cannot see a way to set "removable=on" for usb-storage
> devices started via libvirt (in 12.04, with libvirt-bin
> 0.9.8-2ubuntu17.1 and virt-manager 0.9.1-1ubuntu5.1).
>
> So, is a feature request required for virt-manager to expose this option
> for virtual disks (default to 'on' for bus='usb') and add support to
> libvirt's XML to set "removable=on" ?

Yes, I just checked libvirt.git/master and cannot see a way to set the
removable option.  I'm afraid libvirt also needs changes.

Stefan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable
  2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
                   ` (4 preceding siblings ...)
  2012-07-02 15:04 ` Sebastian Malcolm
@ 2017-03-20 22:49 ` Thomas Huth
  5 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2017-03-20 22:49 UTC (permalink / raw)
  To: qemu-devel

Setting status to "Fix released" according to comment #5 (if there is
something left to do for libvirt, please consult their bugtracker
instead)

** Changed in: qemu
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/686613

Title:
  USB MSD are not marked as removable

Status in QEMU:
  Fix Released

Bug description:
   Filed from Fedora bug:
  https://bugzilla.redhat.com/show_bug.cgi?id=589130

  Guests can access USB Mass Storage Device, but fail to mark them as
  removable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/686613/+subscriptions

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-03-20 22:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-07 15:27 [Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable Justin M. Forbes
2011-01-09 17:33 ` [Qemu-devel] [Bug 686613] " Stefan Hajnoczi
2011-01-11 10:07 ` Stefan Hajnoczi
2011-01-11 10:07 ` Stefan Hajnoczi
2011-01-11 15:15 ` Stefan Hajnoczi
2011-01-11 16:22   ` Christoph Hellwig
2012-07-02 15:04 ` Sebastian Malcolm
2012-07-02 19:53   ` Stefan Hajnoczi
2017-03-20 22:49 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.