All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP1: SRAM: fix size for OMAP1611 SoCs
@ 2010-12-08  1:02 ` Kevin Hilman
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2010-12-08  1:02 UTC (permalink / raw)
  To: linux-omap; +Cc: Santosh Shilimkar, Tim Bird, linux-arm-kernel

Kernel was failing to boot on omap1611 based OSK boards due to
mis-configured SRAM size.  Existing code was using a hard-coded value
for 250k, which was then rounded down by PAGE_SIZE.  Increasing this to
256k allows kernel to boot on omap1611 SoCs.

Problem reported by and initial fix suggested by Tim Bird.

Thanks to Tony Lindgren for helping diagnose the problem to being
specific to OMAP1611 and not affecting OMAP1610/OMAP1623.

Reported-by: Tim Bird <tim.bird@am.sony.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
Applies to Tony's omap-fixes branch, and should probably be 
targetted for .37-rc.

 arch/arm/plat-omap/sram.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index e2c8eeb..74dac41 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -166,7 +166,7 @@ static void __init omap_detect_sram(void)
 		     cpu_is_omap1710())
 			omap_sram_size = 0x4000;	/* 16K */
 		else if (cpu_is_omap1611())
-			omap_sram_size = 0x3e800;	/* 250K */
+			omap_sram_size = SZ_256K;
 		else {
 			printk(KERN_ERR "Could not detect SRAM size\n");
 			omap_sram_size = 0x4000;
-- 
1.7.2.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] OMAP1: SRAM: fix size for OMAP1611 SoCs
@ 2010-12-08  1:02 ` Kevin Hilman
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2010-12-08  1:02 UTC (permalink / raw)
  To: linux-arm-kernel

Kernel was failing to boot on omap1611 based OSK boards due to
mis-configured SRAM size.  Existing code was using a hard-coded value
for 250k, which was then rounded down by PAGE_SIZE.  Increasing this to
256k allows kernel to boot on omap1611 SoCs.

Problem reported by and initial fix suggested by Tim Bird.

Thanks to Tony Lindgren for helping diagnose the problem to being
specific to OMAP1611 and not affecting OMAP1610/OMAP1623.

Reported-by: Tim Bird <tim.bird@am.sony.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
Applies to Tony's omap-fixes branch, and should probably be 
targetted for .37-rc.

 arch/arm/plat-omap/sram.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index e2c8eeb..74dac41 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -166,7 +166,7 @@ static void __init omap_detect_sram(void)
 		     cpu_is_omap1710())
 			omap_sram_size = 0x4000;	/* 16K */
 		else if (cpu_is_omap1611())
-			omap_sram_size = 0x3e800;	/* 250K */
+			omap_sram_size = SZ_256K;
 		else {
 			printk(KERN_ERR "Could not detect SRAM size\n");
 			omap_sram_size = 0x4000;
-- 
1.7.2.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] OMAP1: SRAM: fix size for OMAP1611 SoCs
  2010-12-08  1:02 ` Kevin Hilman
@ 2010-12-10  0:30   ` Tony Lindgren
  -1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-12-10  0:30 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: linux-omap, Santosh Shilimkar, Tim Bird, linux-arm-kernel

* Kevin Hilman <khilman@deeprootsystems.com> [101207 17:06]:
> Kernel was failing to boot on omap1611 based OSK boards due to
> mis-configured SRAM size.  Existing code was using a hard-coded value
> for 250k, which was then rounded down by PAGE_SIZE.  Increasing this to
> 256k allows kernel to boot on omap1611 SoCs.
> 
> Problem reported by and initial fix suggested by Tim Bird.
> 
> Thanks to Tony Lindgren for helping diagnose the problem to being
> specific to OMAP1611 and not affecting OMAP1610/OMAP1623.

Thanks, will queue this fix.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] OMAP1: SRAM: fix size for OMAP1611 SoCs
@ 2010-12-10  0:30   ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-12-10  0:30 UTC (permalink / raw)
  To: linux-arm-kernel

* Kevin Hilman <khilman@deeprootsystems.com> [101207 17:06]:
> Kernel was failing to boot on omap1611 based OSK boards due to
> mis-configured SRAM size.  Existing code was using a hard-coded value
> for 250k, which was then rounded down by PAGE_SIZE.  Increasing this to
> 256k allows kernel to boot on omap1611 SoCs.
> 
> Problem reported by and initial fix suggested by Tim Bird.
> 
> Thanks to Tony Lindgren for helping diagnose the problem to being
> specific to OMAP1611 and not affecting OMAP1610/OMAP1623.

Thanks, will queue this fix.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-12-10  0:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-08  1:02 [PATCH] OMAP1: SRAM: fix size for OMAP1611 SoCs Kevin Hilman
2010-12-08  1:02 ` Kevin Hilman
2010-12-10  0:30 ` Tony Lindgren
2010-12-10  0:30   ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.