From: "G, Manjunath Kondaiah" <manjugk@ti.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode
Date: Tue, 14 Dec 2010 07:18:22 +0530 [thread overview]
Message-ID: <20101214014822.GA3858@manju-desktop> (raw)
In-Reply-To: <4CF8E03A.4010000@ti.com>
Paul/Benoit,
On Fri, Dec 03, 2010 at 01:19:06PM +0100, Cousson, Benoit wrote:
> On 12/3/2010 10:47 AM, G, Manjunath Kondaiah wrote:
> >* Cousson, Benoit<b-cousson@ti.com> [2010-12-03 09:38:35 +0100]:
>
> [...]
>
> >>>v7: replaced mutex lock with spin lock. Added use count for controlling
> >>>access to sysconfig registers in case if overlapping request/release API's
> >>>are used.
> >>
> >>I'm not sure it should be done here. I'd rather keep that code in
> >>the DMA, since this is the only user of that feature.
> >
> >Are you referring to spin lock or usage count?
>
> The spinlock is needed, I was referring to the usage count.
>
> That being said, the API proposed by Paul (request/release
> ) sound like a get/put, so maybe he had that kind of usage in mind.
>
> I'm still not convince it should be done at hwmod API level.
>
>
> Paul,
> Any thoughts on that?
How do we proceed further?
-Manjunath
WARNING: multiple messages have this Message-ID (diff)
From: manjugk@ti.com (G, Manjunath Kondaiah)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode
Date: Tue, 14 Dec 2010 07:18:22 +0530 [thread overview]
Message-ID: <20101214014822.GA3858@manju-desktop> (raw)
In-Reply-To: <4CF8E03A.4010000@ti.com>
Paul/Benoit,
On Fri, Dec 03, 2010 at 01:19:06PM +0100, Cousson, Benoit wrote:
> On 12/3/2010 10:47 AM, G, Manjunath Kondaiah wrote:
> >* Cousson, Benoit<b-cousson@ti.com> [2010-12-03 09:38:35 +0100]:
>
> [...]
>
> >>>v7: replaced mutex lock with spin lock. Added use count for controlling
> >>>access to sysconfig registers in case if overlapping request/release API's
> >>>are used.
> >>
> >>I'm not sure it should be done here. I'd rather keep that code in
> >>the DMA, since this is the only user of that feature.
> >
> >Are you referring to spin lock or usage count?
>
> The spinlock is needed, I was referring to the usage count.
>
> That being said, the API proposed by Paul (request/release
> ) sound like a get/put, so maybe he had that kind of usage in mind.
>
> I'm still not convince it should be done at hwmod API level.
>
>
> Paul,
> Any thoughts on that?
How do we proceed further?
-Manjunath
next prev parent reply other threads:[~2010-12-14 1:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 13:59 [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode G, Manjunath Kondaiah
2010-12-02 14:23 ` G, Manjunath Kondaiah
2010-12-02 14:23 ` G, Manjunath Kondaiah
2010-12-03 8:38 ` Cousson, Benoit
2010-12-03 8:38 ` Cousson, Benoit
2010-12-03 9:47 ` G, Manjunath Kondaiah
2010-12-03 9:47 ` G, Manjunath Kondaiah
2010-12-03 12:19 ` Cousson, Benoit
2010-12-03 12:19 ` Cousson, Benoit
2010-12-14 1:48 ` G, Manjunath Kondaiah [this message]
2010-12-14 1:48 ` G, Manjunath Kondaiah
2011-01-24 9:33 ` G, Manjunath Kondaiah
2011-01-24 9:33 ` G, Manjunath Kondaiah
2011-01-26 0:41 ` G, Manjunath Kondaiah
2011-01-26 0:41 ` G, Manjunath Kondaiah
2011-01-26 19:05 ` Paul Walmsley
2011-01-26 19:05 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214014822.GA3858@manju-desktop \
--to=manjugk@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.