All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mlx4: Change a warning message to debug
@ 2010-12-08  8:06 Eli Cohen
  2010-12-08 19:03 ` Roland Dreier
  2011-01-04 22:24 ` Roland Dreier
  0 siblings, 2 replies; 6+ messages in thread
From: Eli Cohen @ 2010-12-08  8:06 UTC (permalink / raw)
  To: Roland Dreier; +Cc: RDMA list

This workaround presented in 58d74bb is not something we should alert the user
on.  Debug level message is enough.

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
---
 drivers/net/mlx4/fw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/fw.c b/drivers/net/mlx4/fw.c
index 7a7e18b..9f415df 100644
--- a/drivers/net/mlx4/fw.c
+++ b/drivers/net/mlx4/fw.c
@@ -290,7 +290,7 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
 		dev_cap->bf_reg_size = 1 << (field & 0x1f);
 		MLX4_GET(field, outbox, QUERY_DEV_CAP_LOG_MAX_BF_REGS_PER_PAGE_OFFSET);
 		if ((1 << (field & 0x3f)) > (PAGE_SIZE / dev_cap->bf_reg_size)) {
-			mlx4_warn(dev, "firmware bug: log2 # of blue flame regs is invalid (%d), forcing 3\n", field & 0x1f);
+			mlx4_dbg(dev, "firmware bug: log2 # of blue flame regs is invalid (%d), forcing 3\n", field & 0x1f);
 			field = 3;
 		}
 		dev_cap->bf_regs_per_page = 1 << (field & 0x3f);
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] mlx4: Change a warning message to debug
  2010-12-08  8:06 [PATCH] mlx4: Change a warning message to debug Eli Cohen
@ 2010-12-08 19:03 ` Roland Dreier
       [not found]   ` <adaipz4jddc.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
  2011-01-04 22:24 ` Roland Dreier
  1 sibling, 1 reply; 6+ messages in thread
From: Roland Dreier @ 2010-12-08 19:03 UTC (permalink / raw)
  To: Eli Cohen; +Cc: RDMA list

 > This workaround presented in 58d74bb is not something we should alert the user
 > on.  Debug level message is enough.

Not sure I agree ... surely the point of this message is for the user to
see it and know to update firmware?  Otherwise why print anything at
all, since I'm sure you guys have already fixed the firmware and have a
regression test so this bug doesn't reappear?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mlx4: Change a warning message to debug
       [not found]   ` <adaipz4jddc.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
@ 2010-12-10 12:27     ` Eli Cohen
  2010-12-13 21:55       ` Roland Dreier
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Cohen @ 2010-12-10 12:27 UTC (permalink / raw)
  To: Roland Dreier; +Cc: RDMA list

On Wed, Dec 08, 2010 at 11:03:43AM -0800, Roland Dreier wrote:
>  > This workaround presented in 58d74bb is not something we should alert the user
>  > on.  Debug level message is enough.
> 
> Not sure I agree ... surely the point of this message is for the user to
> see it and know to update firmware?  Otherwise why print anything at
> all, since I'm sure you guys have already fixed the firmware and have a
> regression test so this bug doesn't reappear?
> 
Right :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mlx4: Change a warning message to debug
  2010-12-10 12:27     ` Eli Cohen
@ 2010-12-13 21:55       ` Roland Dreier
       [not found]         ` <adazks9gwwy.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Roland Dreier @ 2010-12-13 21:55 UTC (permalink / raw)
  To: Eli Cohen; +Cc: RDMA list

 > > Not sure I agree ... surely the point of this message is for the user to
 > > see it and know to update firmware?  Otherwise why print anything at
 > > all, since I'm sure you guys have already fixed the firmware and have a
 > > regression test so this bug doesn't reappear?

 > Right :-)

So what do you think -- remove the message entirely or leave it?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mlx4: Change a warning message to debug
       [not found]         ` <adazks9gwwy.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
@ 2010-12-14 11:26           ` Eli Cohen
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Cohen @ 2010-12-14 11:26 UTC (permalink / raw)
  To: Roland Dreier; +Cc: RDMA list

On Mon, Dec 13, 2010 at 01:55:41PM -0800, Roland Dreier wrote:
> 
> So what do you think -- remove the message entirely or leave it?
> 

I prefer to remove the message.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mlx4: Change a warning message to debug
  2010-12-08  8:06 [PATCH] mlx4: Change a warning message to debug Eli Cohen
  2010-12-08 19:03 ` Roland Dreier
@ 2011-01-04 22:24 ` Roland Dreier
  1 sibling, 0 replies; 6+ messages in thread
From: Roland Dreier @ 2011-01-04 22:24 UTC (permalink / raw)
  To: Eli Cohen; +Cc: RDMA list

OK, I just got rid of the message entirely.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-04 22:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-08  8:06 [PATCH] mlx4: Change a warning message to debug Eli Cohen
2010-12-08 19:03 ` Roland Dreier
     [not found]   ` <adaipz4jddc.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-12-10 12:27     ` Eli Cohen
2010-12-13 21:55       ` Roland Dreier
     [not found]         ` <adazks9gwwy.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-12-14 11:26           ` Eli Cohen
2011-01-04 22:24 ` Roland Dreier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.