Re: [PATCH] am: Allow passing exclude and include args to apply

From: maximilian attems <max@stro.at>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>, klibc@zytor.com
Subject: Re: [PATCH] am: Allow passing exclude and include args to apply
Date: Sun, 19 Dec 2010 17:13:13 +0000	[thread overview]
Message-ID: <20101219171313.GI17034@vostochny.stro.at> (raw)
In-Reply-To: <AANLkTik5-oJYsfEoeYjy8E9v4T4_7VBsoGnqg7oXwnbC@mail.gmail.com>

On Sun, Dec 19, 2010 at 02:56:58PM -0200, Thiago Farina wrote:
> On Sun, Dec 19, 2010 at 2:17 PM, maximilian attems <max@stro.at> wrote:
> > When porting patches from dash git to klibc git,
> > where dash has a different directory structure those
> > switches are handy:
> > Exported with format-patch on dash side and used am
> > as import for klibc side.
> >
> 
> I don't know, but this commit message doesn't look good. Can you be
> more specific about what the patch does, and what it's trying to fix.

hmm, it does what the subject says. (:
have you ever used `git am'?

> Describing a use case is good, but in this case it isn't help me much
> (maybe for others the issue here is clear, but for my taste no).

when one wants to promote a specific new feature, it is much better to
come up with it's use case, as burden is on Maintainer to keep it working.

Please be more specific on what's missing? Your personal taste is
unknown to me and not of importance.

thank you.

-- 
maks