All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: maximilian attems <max@stro.at>
Cc: Thiago Farina <tfransosi@gmail.com>,
	klibc@zytor.com, Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [klibc] [PATCH] am: Allow passing exclude and include args to apply
Date: Sun, 19 Dec 2010 18:26:57 +0100	[thread overview]
Message-ID: <20101219172657.GA9564@merkur.ravnborg.org> (raw)
In-Reply-To: <20101219171313.GI17034@vostochny.stro.at>

On Sun, Dec 19, 2010 at 05:13:13PM +0000, maximilian attems wrote:
> On Sun, Dec 19, 2010 at 02:56:58PM -0200, Thiago Farina wrote:
> > On Sun, Dec 19, 2010 at 2:17 PM, maximilian attems <max@stro.at> wrote:
> > > When porting patches from dash git to klibc git,
> > > where dash has a different directory structure those
> > > switches are handy:
> > > Exported with format-patch on dash side and used am
> > > as import for klibc side.
> > >
> > 
> > I don't know, but this commit message doesn't look good. Can you be
> > more specific about what the patch does, and what it's trying to fix.
> 
> hmm, it does what the subject says. (:
> have you ever used `git am'?
> 
...
> Please be more specific on what's missing? Your personal taste is
> unknown to me and not of importance.

I had to read it twice to get it..
Most likely because I read the changelog without reading the title first.

	Sam

  reply	other threads:[~2010-12-19 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-19 16:17 [PATCH] am: Allow passing exclude and include args to apply maximilian attems
2010-12-19 16:56 ` Thiago Farina
2010-12-19 17:13   ` maximilian attems
2010-12-19 17:26     ` Sam Ravnborg [this message]
2010-12-19 18:27       ` [klibc] " maximilian attems
2010-12-19 20:13     ` Junio C Hamano
2011-01-29 19:31       ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101219172657.GA9564@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=klibc@zytor.com \
    --cc=max@stro.at \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.