* [patch -next] vmxnet3: locking problems in xmit
@ 2010-12-20 13:03 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-12-20 13:03 UTC (permalink / raw)
To: Shreyas Bhatewara; +Cc: VMware, Inc., netdev, kernel-janitors
There were several paths that didn't release their locks.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 23154cf..939e546 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
}
} else {
tq->stats.drop_hdr_inspect_err++;
- goto drop_pkt;
+ goto unlock_drop_pkt;
}
/* fill tx descs related to addr & len */
@@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
hdr_too_big:
tq->stats.drop_oversized_hdr++;
+unlock_drop_pkt:
+ spin_unlock_irqrestore(&tq->tx_lock, flags);
drop_pkt:
tq->stats.drop_total++;
dev_kfree_skb(skb);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch -next] vmxnet3: locking problems in xmit
@ 2010-12-20 13:03 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-12-20 13:03 UTC (permalink / raw)
To: Shreyas Bhatewara; +Cc: VMware, Inc., netdev, kernel-janitors
There were several paths that didn't release their locks.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 23154cf..939e546 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
}
} else {
tq->stats.drop_hdr_inspect_err++;
- goto drop_pkt;
+ goto unlock_drop_pkt;
}
/* fill tx descs related to addr & len */
@@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
hdr_too_big:
tq->stats.drop_oversized_hdr++;
+unlock_drop_pkt:
+ spin_unlock_irqrestore(&tq->tx_lock, flags);
drop_pkt:
tq->stats.drop_total++;
dev_kfree_skb(skb);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [Pv-drivers] [patch -next] vmxnet3: locking problems in xmit
2010-12-20 13:03 ` Dan Carpenter
@ 2010-12-20 17:09 ` Bhavesh Davda
-1 siblings, 0 replies; 6+ messages in thread
From: Bhavesh Davda @ 2010-12-20 17:09 UTC (permalink / raw)
To: Dan Carpenter, Shreyas Bhatewara; +Cc: VMware, Inc., netdev, kernel-janitors
Indeed, indeed. Thanks for catching that and fixing it!
>
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 23154cf..939e546 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
> }
> } else {
> tq->stats.drop_hdr_inspect_err++;
> - goto drop_pkt;
> + goto unlock_drop_pkt;
> }
>
> /* fill tx descs related to addr & len */
> @@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
>
> hdr_too_big:
> tq->stats.drop_oversized_hdr++;
> +unlock_drop_pkt:
> + spin_unlock_irqrestore(&tq->tx_lock, flags);
> drop_pkt:
> tq->stats.drop_total++;
> dev_kfree_skb(skb);
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Pv-drivers] [patch -next] vmxnet3: locking problems in xmit
@ 2010-12-20 17:09 ` Bhavesh Davda
0 siblings, 0 replies; 6+ messages in thread
From: Bhavesh Davda @ 2010-12-20 17:09 UTC (permalink / raw)
To: Dan Carpenter, Shreyas Bhatewara; +Cc: VMware, Inc., netdev, kernel-janitors
Indeed, indeed. Thanks for catching that and fixing it!
>
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 23154cf..939e546 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
> }
> } else {
> tq->stats.drop_hdr_inspect_err++;
> - goto drop_pkt;
> + goto unlock_drop_pkt;
> }
>
> /* fill tx descs related to addr & len */
> @@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
>
> hdr_too_big:
> tq->stats.drop_oversized_hdr++;
> +unlock_drop_pkt:
> + spin_unlock_irqrestore(&tq->tx_lock, flags);
> drop_pkt:
> tq->stats.drop_total++;
> dev_kfree_skb(skb);
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] vmxnet3: locking problems in xmit
2010-12-20 13:03 ` Dan Carpenter
@ 2010-12-20 18:44 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-12-20 18:44 UTC (permalink / raw)
To: error27; +Cc: sbhatewara, pv-drivers, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Mon, 20 Dec 2010 16:03:15 +0300
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] vmxnet3: locking problems in xmit
@ 2010-12-20 18:44 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-12-20 18:44 UTC (permalink / raw)
To: error27; +Cc: sbhatewara, pv-drivers, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Mon, 20 Dec 2010 16:03:15 +0300
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-20 18:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-20 13:03 [patch -next] vmxnet3: locking problems in xmit Dan Carpenter
2010-12-20 13:03 ` Dan Carpenter
2010-12-20 17:09 ` [Pv-drivers] " Bhavesh Davda
2010-12-20 17:09 ` Bhavesh Davda
2010-12-20 18:44 ` David Miller
2010-12-20 18:44 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.