* [PATCH 2 of 4] LVM: cleanup 2
@ 2011-01-10 20:56 Jonathan Brassow
2011-01-11 10:32 ` Zdenek Kabelac
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Brassow @ 2011-01-10 20:56 UTC (permalink / raw)
To: lvm-devel
Patch name: lvm-cleanup-2.patch
The check for segtype_is_virtual is done at the top of the function,
no need to do it again at the bottom.
Index: LVM2/lib/metadata/lv_manip.c
===================================================================
--- LVM2.orig/lib/metadata/lv_manip.c
+++ LVM2/lib/metadata/lv_manip.c
@@ -1557,8 +1557,7 @@ struct alloc_handle *allocate_extents(st
parallel_areas)))
return_NULL;
- if (!segtype_is_virtual(segtype) &&
- !_allocate(ah, vg, lv, 1, allocatable_pvs)) {
+ if (!_allocate(ah, vg, lv, 1, allocatable_pvs)) {
alloc_destroy(ah);
return_NULL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2 of 4] LVM: cleanup 2
2011-01-10 20:56 [PATCH 2 of 4] LVM: cleanup 2 Jonathan Brassow
@ 2011-01-11 10:32 ` Zdenek Kabelac
0 siblings, 0 replies; 2+ messages in thread
From: Zdenek Kabelac @ 2011-01-11 10:32 UTC (permalink / raw)
To: lvm-devel
Dne 10.1.2011 21:56, Jonathan Brassow napsal(a):
> Patch name: lvm-cleanup-2.patch
>
> The check for segtype_is_virtual is done at the top of the function,
> no need to do it again at the bottom.
>
>
> Index: LVM2/lib/metadata/lv_manip.c
> ===================================================================
> --- LVM2.orig/lib/metadata/lv_manip.c
> +++ LVM2/lib/metadata/lv_manip.c
> @@ -1557,8 +1557,7 @@ struct alloc_handle *allocate_extents(st
> parallel_areas)))
> return_NULL;
>
> - if (!segtype_is_virtual(segtype) &&
> - !_allocate(ah, vg, lv, 1, allocatable_pvs)) {
> + if (!_allocate(ah, vg, lv, 1, allocatable_pvs)) {
> alloc_destroy(ah);
> return_NULL;
> }
>
Ack
Zdenek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-11 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-10 20:56 [PATCH 2 of 4] LVM: cleanup 2 Jonathan Brassow
2011-01-11 10:32 ` Zdenek Kabelac
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.