All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] mpq101: initial support for Mercury Computer Systems MPQ101 board
Date: Mon, 10 Jan 2011 23:56:22 +0100	[thread overview]
Message-ID: <20110110225622.7C383150A4A@gemini.denx.de> (raw)
In-Reply-To: <294951.51594.qm@web37601.mail.mud.yahoo.com>

Dear Alex Dubov,

In message <294951.51594.qm@web37601.mail.mud.yahoo.com> you wrote:
> Mpq101 is a RapidIO development board in AMC form factor, featuring MPC8548
> processor, 512MB of hardwired DDR2 RAM, 128MB of hardwired NAND flash
> memory, real time clock and additional serial EEPROM on i2c bus (enabled).
> USB controller is available, but not presently enabled.
> 
> Additional board information is available at:
> http://www.mc.com/products/boards/ensemble_mpq101_rapidio_powerquicc_iii.aspx
> 
> Environment is configured to preceed the actual u-boot image so that it's
> located at the beginning of flash erase block (made necessary by the recent
> changes to the embedded environment handling).
> 
> Signed-off-by: Alex Dubov <oakad@yahoo.com>
> ---
>  MAINTAINERS                    |    3 +
>  board/mercury/mpq101/Makefile  |   53 +++++
>  board/mercury/mpq101/config.mk |    6 +
>  board/mercury/mpq101/law.c     |   55 ++++++
>  board/mercury/mpq101/mpq101.c  |  146 ++++++++++++++
>  board/mercury/mpq101/tlb.c     |   82 ++++++++
>  boards.cfg                     |    1 +
>  include/configs/mpq101.h       |  410 ++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 756 insertions(+), 0 deletions(-)
>  create mode 100644 board/mercury/mpq101/Makefile
>  create mode 100644 board/mercury/mpq101/config.mk
>  create mode 100644 board/mercury/mpq101/law.c
>  create mode 100644 board/mercury/mpq101/mpq101.c
>  create mode 100644 board/mercury/mpq101/tlb.c
>  create mode 100644 include/configs/mpq101.h

I'm not going to review this again.  Why don't you explain what was
changed compared to the previous version?  Please see the second
bullet at
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
for a detailed explanation.

And you still have a board/mercury/mpq101/config.mk even though I
asked you to get rid of it.

Please also run your patch through checkpatch.pl, remove C++
comments, remove deads code, do not #undef variables that are not
#defined, use TAB for vertical alignment and fix other Coding Style
issues.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?

  reply	other threads:[~2011-01-10 22:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27  6:22 [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board Alex Dubov
2010-12-27 12:12 ` Wolfgang Denk
2010-12-28  4:42   ` Alex Dubov
2011-01-10 22:43     ` Wolfgang Denk
2011-01-11  3:14       ` Alex Dubov
2011-01-11  5:43         ` Wolfgang Denk
2011-01-11  7:32           ` Alex Dubov
2011-01-17 22:38             ` Wolfgang Denk
2011-01-18  4:32               ` Kumar Gala
2010-12-28  5:53   ` Alex Dubov
2011-01-10 22:49     ` Wolfgang Denk
2011-01-07  7:16   ` [U-Boot] [PATCH v3] " Alex Dubov
2011-01-10 22:56     ` Wolfgang Denk [this message]
2011-01-11  2:44       ` Alex Dubov
2011-01-11  7:43         ` Wolfgang Denk
2011-01-13  2:42           ` Alex Dubov
2011-01-14  9:10       ` [U-Boot] [PATCH v4] " Alex Dubov
2011-01-14 11:49         ` Kumar Gala
2011-01-17  3:07           ` Alex Dubov
2011-01-17  7:26           ` [U-Boot] [PATCH v5] " Alex Dubov
2011-01-18  5:15             ` Kumar Gala
2011-01-18  8:03               ` [U-Boot] [PATCH v6] " Alex Dubov
2011-01-18  9:42                 ` Kumar Gala
2011-01-19  9:50                   ` Alex Dubov
2011-01-20  5:02                   ` [U-Boot] [PATCH v7] " Alex Dubov
2011-01-20  7:50                     ` Kumar Gala
2011-01-24  5:59                       ` [U-Boot] [PATCH v8] " Alex Dubov
2011-01-27  5:45                         ` Kumar Gala
2011-01-27  8:41                           ` Alex Dubov
2011-01-20  8:46                     ` [U-Boot] [PATCH v7] " Wolfgang Denk
2011-01-22  7:27                       ` Alex Dubov
2011-01-14 11:51         ` [U-Boot] [PATCH v4] " Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110110225622.7C383150A4A@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.