All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] scons: add EXTRA_OESCONS
@ 2011-01-10 14:12 Víctor Manuel Jáquez Leal
  2011-01-10 14:28 ` Koen Kooi
  0 siblings, 1 reply; 3+ messages in thread
From: Víctor Manuel Jáquez Leal @ 2011-01-10 14:12 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Koen Kooi, Michael Lauer

It's similar to EXTRA_OEMAKE, which appends arguments to the scons
command

v2:
* initialise the EXTRA_OECONS if it is not defined

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
---
 classes/scons.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/classes/scons.bbclass b/classes/scons.bbclass
index 2a935e4..c19f8d4 100644
--- a/classes/scons.bbclass
+++ b/classes/scons.bbclass
@@ -1,5 +1,7 @@
 DEPENDS += "python-scons-native"
 
+EXTRA_OESCONS ?= ""
+
 export TARGET_LINK_HASH_STYLE
 
 scons_do_compile() {
@@ -11,7 +13,7 @@ scons_do_compile() {
         fi
     fi
 
-    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} || \
+    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} ${EXTRA_OESCONS} || \
     oefatal "scons build execution failed."
 }
 
-- 
1.7.2.3




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] scons: add EXTRA_OESCONS
  2011-01-10 14:12 [PATCH v2] scons: add EXTRA_OESCONS Víctor Manuel Jáquez Leal
@ 2011-01-10 14:28 ` Koen Kooi
  2011-01-11  9:59   ` Víctor M. Jáquez L.
  0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2011-01-10 14:28 UTC (permalink / raw)
  To: Víctor Manuel Jáquez Leal; +Cc: openembedded-devel


Op 10 jan 2011, om 15:12 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

> It's similar to EXTRA_OEMAKE, which appends arguments to the scons
> command
> 
> v2:
> * initialise the EXTRA_OECONS if it is not defined
> 
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>

Acked-by: Koen Kooi <koen@openembedded.org>


> ---
> classes/scons.bbclass |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/classes/scons.bbclass b/classes/scons.bbclass
> index 2a935e4..c19f8d4 100644
> --- a/classes/scons.bbclass
> +++ b/classes/scons.bbclass
> @@ -1,5 +1,7 @@
> DEPENDS += "python-scons-native"
> 
> +EXTRA_OESCONS ?= ""
> +
> export TARGET_LINK_HASH_STYLE
> 
> scons_do_compile() {
> @@ -11,7 +13,7 @@ scons_do_compile() {
>         fi
>     fi
> 
> -    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} || \
> +    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} ${EXTRA_OESCONS} || \
>     oefatal "scons build execution failed."
> }
> 
> -- 
> 1.7.2.3
> 




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] scons: add EXTRA_OESCONS
  2011-01-10 14:28 ` Koen Kooi
@ 2011-01-11  9:59   ` Víctor M. Jáquez L.
  0 siblings, 0 replies; 3+ messages in thread
From: Víctor M. Jáquez L. @ 2011-01-11  9:59 UTC (permalink / raw)
  To: openembedded-devel

On Mon, Jan 10, 2011 at 03:28:29PM +0100, Koen Kooi wrote:
> 
> Op 10 jan 2011, om 15:12 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
> 
> > It's similar to EXTRA_OEMAKE, which appends arguments to the scons
> > command
> > 
> > v2:
> > * initialise the EXTRA_OECONS if it is not defined
> > 
> > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
> 
> Acked-by: Koen Kooi <koen@openembedded.org>

Do I need another ack in order to push this patch?

vmjl

> 
> 
> > ---
> > classes/scons.bbclass |    4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/classes/scons.bbclass b/classes/scons.bbclass
> > index 2a935e4..c19f8d4 100644
> > --- a/classes/scons.bbclass
> > +++ b/classes/scons.bbclass
> > @@ -1,5 +1,7 @@
> > DEPENDS += "python-scons-native"
> > 
> > +EXTRA_OESCONS ?= ""
> > +
> > export TARGET_LINK_HASH_STYLE
> > 
> > scons_do_compile() {
> > @@ -11,7 +13,7 @@ scons_do_compile() {
> >         fi
> >     fi
> > 
> > -    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} || \
> > +    ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} CXX="${CXX}" PREFIX=${prefix} prefix=${prefix} ${EXTRA_OESCONS} || \
> >     oefatal "scons build execution failed."
> > }
> > 
> > -- 
> > 1.7.2.3
> > 
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-01-11 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-10 14:12 [PATCH v2] scons: add EXTRA_OESCONS Víctor Manuel Jáquez Leal
2011-01-10 14:28 ` Koen Kooi
2011-01-11  9:59   ` Víctor M. Jáquez L.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.