Re: [PATCH 5/7] xen-gntdev: Add reference counting to maps

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"jeremy@goop.org" <jeremy@goop.org>
Subject: Re: [PATCH 5/7] xen-gntdev: Add reference counting to maps
Date: Tue, 11 Jan 2011 12:46:13 -0500	[thread overview]
Message-ID: <20110111174613.GF14017@dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101111107260.7277@kaball-desktop>

On Tue, Jan 11, 2011 at 11:10:23AM +0000, Stefano Stabellini wrote:
> On Mon, 10 Jan 2011, Konrad Rzeszutek Wilk wrote:
> > > -static void gntdev_free_map(struct grant_map *map)
> > > -{
> > > -	unsigned i;
> > > +	atomic_sub(map->count, &pages_mapped);
> > >  
> > > -	if (!map)
> > > -		return;
> > > +	if (!use_ptemod)
> > > +		unmap_grant_pages(map, 0, map->count);
> > >  
> > >  	for (i = 0; i < map->count; i++) {
> > >  		if (map->pages[i])
> > >  			__free_page(map->pages[i]);
> > >  	}
> > > +	kfree(map->pages);
> > 
> > Can you roll that in the previous patch that introduced the map->pages code?
> > 
> 
> map->pages is actually introduced by "xen gntdev: use gnttab_map_refs
> and gnttab_unmap_refs" in my patch series and it already has a

Right. But I meant his patch that collapsed all of the different kzalloc's in just one.

> kfree(map->pages) in gntdev_free_map.
> In fact I think reading this chuck of the patch on its own is misleading
> because as you can see the whole gntdev_free_map function has been
> removed...