From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com,
Ian.Campbell@citrix.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH libxc] Remove set_max_grants in linux
Date: Wed, 12 Jan 2011 12:57:46 -0500 [thread overview]
Message-ID: <4D2DEB9A.9070500@tycho.nsa.gov> (raw)
In-Reply-To: <19757.57897.295979.150921@mariner.uk.xensource.com>
On 01/12/2011 12:17 PM, Ian Jackson wrote:
> Daniel De Graaf writes ("[Xen-devel] [PATCH libxc] Remove set_max_grants in linux"):
>> I just removed the linux version, because I didn't want to prevent its use
>> in minios where it is needed to resize the array of grants.
>>
>> ------------------------------------------------------------------->8
>>
>> The maximum number of grants is now constrained domain-wide in linux,
>> so set_max_grants should be a noop there. Previously, this constraint
>> was per-file-description.
>
> Is this unconditional change suitable for putting into xen-unstable.hg
> for the 4.1 release ? In particular, will it break compatibility with
> "traditional Xen" kernels ?
>
> Ian.
>
It won't break compatibility; Linux has never required that you set the
limit in order to use grants. The default limit is set to the maximum
possible limit, so existing users cannot have been increasing it;
changing a possible decrease to a noop shouldn't break anything sane.
--
Daniel De Graaf
National Security Agency
next prev parent reply other threads:[~2011-01-12 17:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 0:17 [PATCH v3] Userspace grant communication Daniel De Graaf
2010-12-17 0:17 ` [PATCH 1/7] xen-gntdev: Fix circular locking dependency Daniel De Graaf
2010-12-17 0:17 ` [PATCH 2/7] xen-gntdev: Change page limit to be global instead of per-open Daniel De Graaf
2011-01-10 21:52 ` Konrad Rzeszutek Wilk
2011-01-11 12:45 ` Daniel De Graaf
2011-01-11 17:51 ` Konrad Rzeszutek Wilk
2011-01-11 18:18 ` Daniel De Graaf
2011-01-11 18:21 ` Konrad Rzeszutek Wilk
2011-01-11 18:49 ` [PATCH libxc] Remove set_max_grants in linux Daniel De Graaf
2011-01-12 17:17 ` Ian Jackson
2011-01-12 17:57 ` Daniel De Graaf [this message]
2011-01-13 12:09 ` Ian Jackson
2011-01-13 12:48 ` Daniel De Graaf
2011-01-17 17:29 ` Ian Jackson
2010-12-17 0:17 ` [PATCH 3/7] xen-gntdev: Remove unneeded structures from grant_map tracking data Daniel De Graaf
2011-01-10 22:14 ` Konrad Rzeszutek Wilk
2011-01-11 13:02 ` Daniel De Graaf
2010-12-17 0:17 ` [PATCH 4/7] xen-gntdev: Use find_vma rather than iterating our vma list manually Daniel De Graaf
2010-12-17 0:17 ` [PATCH 5/7] xen-gntdev: Add reference counting to maps Daniel De Graaf
2010-12-17 0:49 ` Jeremy Fitzhardinge
2010-12-17 15:11 ` Daniel De Graaf
2010-12-17 0:51 ` Jeremy Fitzhardinge
2010-12-17 15:22 ` [PATCH 5/7 v2] " Daniel De Graaf
2011-01-10 22:28 ` Konrad Rzeszutek Wilk
2011-01-10 22:24 ` [PATCH 5/7] " Konrad Rzeszutek Wilk
2011-01-11 11:10 ` Stefano Stabellini
2011-01-11 17:46 ` Konrad Rzeszutek Wilk
2011-01-12 11:58 ` Stefano Stabellini
2010-12-17 0:17 ` [PATCH 6/7] xen-gntdev: Support mapping in HVM domains Daniel De Graaf
2010-12-17 15:22 ` [PATCH 6/7 v2] " Daniel De Graaf
2011-01-10 22:41 ` [PATCH 6/7] " Konrad Rzeszutek Wilk
2011-01-11 13:15 ` Daniel De Graaf
2011-01-11 14:52 ` Daniel De Graaf
2011-01-11 18:00 ` c/s 22402 ("86 hvm: Refuse to perform __hvm_copy() work in atomic context.") breaks HVM, race possible in other code - any ideas? Konrad Rzeszutek Wilk
2011-01-11 18:24 ` Daniel De Graaf
2010-12-17 0:17 ` [PATCH 7/7] xen-gntalloc: Userspace grant allocation driver Daniel De Graaf
2011-01-07 11:56 ` [PATCH v3] Userspace grant communication Stefano Stabellini
2011-01-14 15:18 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2DEB9A.9070500@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.