All of lore.kernel.org
 help / color / mirror / Atom feed
* [folded] gpio-ml_ioh_gpio-ml7213-gpio-driver-fix.patch removed from -mm tree
@ 2011-01-13  0:23 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2011-01-13  0:23 UTC (permalink / raw)
  To: tomoya-linux, akpm, broonie, linus.walleij, maz, rabin.vincent, sameo


The patch titled
     drivers/gpio/ml_ioh_gpio.c: fix resource leak
has been removed from the -mm tree.  Its filename was
     gpio-ml_ioh_gpio-ml7213-gpio-driver-fix.patch

This patch was dropped because it was folded into gpio-ml_ioh_gpio-ml7213-gpio-driver.patch

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: drivers/gpio/ml_ioh_gpio.c: fix resource leak
From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>

- add gpiochip_remove processing in case gpiochip_add fails.

- for readability, move variable initialization to outside for-condition.

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: Marc Zyngier <maz@misterjones.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/gpio/ml_ioh_gpio.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff -puN drivers/gpio/ml_ioh_gpio.c~gpio-ml_ioh_gpio-ml7213-gpio-driver-fix drivers/gpio/ml_ioh_gpio.c
--- a/drivers/gpio/ml_ioh_gpio.c~gpio-ml_ioh_gpio-ml7213-gpio-driver-fix
+++ a/drivers/gpio/ml_ioh_gpio.c
@@ -208,7 +208,8 @@ static int __devinit ioh_gpio_probe(stru
 		goto err_kzalloc;
 	}
 
-	for (i = 0, chip = chip_save; i < 8; i++, chip++) {
+	chip = chip_save;
+	for (i = 0; i < 8; i++, chip++) {
 		chip->dev = &pdev->dev;
 		chip->base = base;
 		chip->reg = chip->base;
@@ -228,6 +229,12 @@ static int __devinit ioh_gpio_probe(stru
 	return 0;
 
 err_gpiochip_add:
+	for (; i != 0; i--) {
+		chip--;
+		ret = gpiochip_remove(&chip->gpio);
+		if (ret)
+			dev_err(&pdev->dev, "Failed gpiochip_remove(%d)\n", i);
+	}
 	kfree(chip_save);
 
 err_kzalloc:
_

Patches currently in -mm which might be from tomoya-linux@dsn.okisemi.com are

origin.patch
gpio-ml_ioh_gpio-ml7213-gpio-driver.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-01-13  0:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-13  0:23 [folded] gpio-ml_ioh_gpio-ml7213-gpio-driver-fix.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.