* [patch] [SCSI] target: checking for NULL instead of IS_ERR
@ 2011-01-15 14:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-01-15 14:03 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: James Bottomley, linux-kernel, linux-scsi, kernel-janitors
blkdev_get_by_path() returns an ERR_PTR() or error and it doesn't return
a NULL. It looks like this bug would be easy to trigger by mistake.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c6e0d75..3456135 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -154,7 +154,7 @@ static struct se_device *iblock_create_virtdevice(
bd = blkdev_get_by_path(ib_dev->ibd_udev_path,
FMODE_WRITE|FMODE_READ|FMODE_EXCL, ib_dev);
- if (!(bd))
+ if (IS_ERR(bd))
goto failed;
/*
* Setup the local scope queue_limits from struct request_queue->limits
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] [SCSI] target: checking for NULL instead of IS_ERR
@ 2011-01-15 14:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-01-15 14:03 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: James Bottomley, linux-kernel, linux-scsi, kernel-janitors
blkdev_get_by_path() returns an ERR_PTR() or error and it doesn't return
a NULL. It looks like this bug would be easy to trigger by mistake.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c6e0d75..3456135 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -154,7 +154,7 @@ static struct se_device *iblock_create_virtdevice(
bd = blkdev_get_by_path(ib_dev->ibd_udev_path,
FMODE_WRITE|FMODE_READ|FMODE_EXCL, ib_dev);
- if (!(bd))
+ if (IS_ERR(bd))
goto failed;
/*
* Setup the local scope queue_limits from struct request_queue->limits
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] [SCSI] target: checking for NULL instead of IS_ERR
2011-01-15 14:03 ` Dan Carpenter
@ 2011-01-15 20:52 ` Nicholas A. Bellinger
-1 siblings, 0 replies; 4+ messages in thread
From: Nicholas A. Bellinger @ 2011-01-15 20:52 UTC (permalink / raw)
To: Dan Carpenter; +Cc: James Bottomley, linux-kernel, linux-scsi, kernel-janitors
On Sat, 2011-01-15 at 17:03 +0300, Dan Carpenter wrote:
> blkdev_get_by_path() returns an ERR_PTR() or error and it doesn't return
> a NULL. It looks like this bug would be easy to trigger by mistake.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Good catch here Dan.. This was added after a linux-next build failure
over the holidays, but I completely missed the fact that it returns
ERR_PTR.. Thanks for spotting this one!
The same problem exists in target_core_pscsi.c:pscsi_create_type_disk()
as well.. Committed both fixes as 862ede4cbaf in
lio-core-2.6.git/linus-38-rc1 against the .38 mainline target merge, and
cherry picked into scsi-post-merge-2.6.git/for-jejb..
James, please make sure this fix is included in your next pull to Linus.
--nab
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index c6e0d75..3456135 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -154,7 +154,7 @@ static struct se_device *iblock_create_virtdevice(
>
> bd = blkdev_get_by_path(ib_dev->ibd_udev_path,
> FMODE_WRITE|FMODE_READ|FMODE_EXCL, ib_dev);
> - if (!(bd))
> + if (IS_ERR(bd))
> goto failed;
> /*
> * Setup the local scope queue_limits from struct request_queue->limits
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] [SCSI] target: checking for NULL instead of IS_ERR
@ 2011-01-15 20:52 ` Nicholas A. Bellinger
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas A. Bellinger @ 2011-01-15 20:52 UTC (permalink / raw)
To: Dan Carpenter; +Cc: James Bottomley, linux-kernel, linux-scsi, kernel-janitors
On Sat, 2011-01-15 at 17:03 +0300, Dan Carpenter wrote:
> blkdev_get_by_path() returns an ERR_PTR() or error and it doesn't return
> a NULL. It looks like this bug would be easy to trigger by mistake.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Good catch here Dan.. This was added after a linux-next build failure
over the holidays, but I completely missed the fact that it returns
ERR_PTR.. Thanks for spotting this one!
The same problem exists in target_core_pscsi.c:pscsi_create_type_disk()
as well.. Committed both fixes as 862ede4cbaf in
lio-core-2.6.git/linus-38-rc1 against the .38 mainline target merge, and
cherry picked into scsi-post-merge-2.6.git/for-jejb..
James, please make sure this fix is included in your next pull to Linus.
--nab
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index c6e0d75..3456135 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -154,7 +154,7 @@ static struct se_device *iblock_create_virtdevice(
>
> bd = blkdev_get_by_path(ib_dev->ibd_udev_path,
> FMODE_WRITE|FMODE_READ|FMODE_EXCL, ib_dev);
> - if (!(bd))
> + if (IS_ERR(bd))
> goto failed;
> /*
> * Setup the local scope queue_limits from struct request_queue->limits
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-15 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-15 14:03 [patch] [SCSI] target: checking for NULL instead of IS_ERR Dan Carpenter
2011-01-15 14:03 ` Dan Carpenter
2011-01-15 20:52 ` Nicholas A. Bellinger
2011-01-15 20:52 ` Nicholas A. Bellinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.