* [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
@ 2011-01-15 13:01 Mark Brown
2011-01-15 13:25 ` Koul, Vinod
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2011-01-15 13:01 UTC (permalink / raw)
To: Liam Girdwood, Harsha Priya, Vinod Koul; +Cc: alsa-devel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/mid-x86/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/mid-x86/Kconfig b/sound/soc/mid-x86/Kconfig
index e0123a4..8adbc1e 100644
--- a/sound/soc/mid-x86/Kconfig
+++ b/sound/soc/mid-x86/Kconfig
@@ -1,5 +1,6 @@
config SND_MFLD_MACHINE
tristate "SOC Machine Audio driver for Intel Medfield MID platform"
+ depends on X86
select SND_SOC_SN95031
select SND_SST_PLATFORM
help
--
1.7.2.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-15 13:01 [PATCH] ASoC: Add dependency on X86 for Intel MID drivers Mark Brown
@ 2011-01-15 13:25 ` Koul, Vinod
2011-01-15 13:28 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Koul, Vinod @ 2011-01-15 13:25 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood, Harsha, Priya; +Cc: alsa-devel, patches, Alan Cox
> config SND_MFLD_MACHINE
> tristate "SOC Machine Audio driver for Intel Medfield MID platform"
> + depends on X86
> select SND_SOC_SN95031
> select SND_SST_PLATFORM
> help
Mark,
X86 specifies generic x86 devices, pc's netbooks.....
The MID class of devices are quite different, so IMO it should rather depend
on X86_MRST which is for MID devices.
CC Alan:
Alan would X86_MRST be apt or any other option for MID drivers vs X86?
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-15 13:25 ` Koul, Vinod
@ 2011-01-15 13:28 ` Mark Brown
2011-01-17 10:15 ` Alan Cox
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2011-01-15 13:28 UTC (permalink / raw)
To: Koul, Vinod; +Cc: alsa-devel, Harsha, Priya, patches, Alan Cox, Liam Girdwood
On Sat, Jan 15, 2011 at 06:55:57PM +0530, Koul, Vinod wrote:
> X86 specifies generic x86 devices, pc's netbooks.....
> The MID class of devices are quite different, so IMO it should rather depend
> on X86_MRST which is for MID devices.
> CC Alan:
> Alan would X86_MRST be apt or any other option for MID drivers vs X86?
Quite possibly, given that you hadn't specified any dependencies at all
I was going for something as inclusive as possible on x86 platforms.
Were this a normal embedded system on Linux the machine driver would
depend on the specific machine that's being supported.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-15 13:28 ` Mark Brown
@ 2011-01-17 10:15 ` Alan Cox
2011-01-18 13:21 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Alan Cox @ 2011-01-17 10:15 UTC (permalink / raw)
To: Mark Brown; +Cc: Koul, Vinod, alsa-devel, Harsha, Priya, patches, Liam Girdwood
On Sat, 15 Jan 2011 13:28:42 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Sat, Jan 15, 2011 at 06:55:57PM +0530, Koul, Vinod wrote:
>
> > X86 specifies generic x86 devices, pc's netbooks.....
> > The MID class of devices are quite different, so IMO it should
> > rather depend on X86_MRST which is for MID devices.
>
> > CC Alan:
> > Alan would X86_MRST be apt or any other option for MID drivers vs
> > X86?
That depends what it needs - you want to specify the minimum needed to
make it buildable really, which is probably INTEL_SCU_IPC in this case
- you use the IPC I/O so you need the IPC, and the rest follows.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-17 10:15 ` Alan Cox
@ 2011-01-18 13:21 ` Mark Brown
2011-01-18 13:30 ` Koul, Vinod
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2011-01-18 13:21 UTC (permalink / raw)
To: Alan Cox; +Cc: Koul, Vinod, alsa-devel, Harsha, Priya, patches, Liam Girdwood
On Mon, Jan 17, 2011 at 10:15:30AM +0000, Alan Cox wrote:
> That depends what it needs - you want to specify the minimum needed to
> make it buildable really, which is probably INTEL_SCU_IPC in this case
> - you use the IPC I/O so you need the IPC, and the rest follows.
Ping? I don't care what dependency is most appropriate but clearly
there's no way this should be showing up on things that aren't even
x86.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-18 13:21 ` Mark Brown
@ 2011-01-18 13:30 ` Koul, Vinod
2011-01-18 13:31 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Koul, Vinod @ 2011-01-18 13:30 UTC (permalink / raw)
To: Mark Brown, Alan Cox; +Cc: alsa-devel, Harsha, Priya, patches, Liam Girdwood
> > That depends what it needs - you want to specify the minimum needed to
> > make it buildable really, which is probably INTEL_SCU_IPC in this case
> > - you use the IPC I/O so you need the IPC, and the rest follows.
>
> Ping? I don't care what dependency is most appropriate but clearly
> there's no way this should be showing up on things that aren't even
> x86.
I will send the patch now, sorry been little tied up with few other stuff
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: Add dependency on X86 for Intel MID drivers
2011-01-18 13:30 ` Koul, Vinod
@ 2011-01-18 13:31 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2011-01-18 13:31 UTC (permalink / raw)
To: Koul, Vinod; +Cc: Harsha, Priya, alsa-devel, Liam Girdwood, patches, Alan Cox
On Tue, Jan 18, 2011 at 07:00:46PM +0530, Koul, Vinod wrote:
> > Ping? I don't care what dependency is most appropriate but clearly
> > there's no way this should be showing up on things that aren't even
> > x86.
> I will send the patch now, sorry been little tied up with few other stuff
No problem - I'd just like to get this sorted before the merge window
closes and this appears in -next.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-18 13:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-15 13:01 [PATCH] ASoC: Add dependency on X86 for Intel MID drivers Mark Brown
2011-01-15 13:25 ` Koul, Vinod
2011-01-15 13:28 ` Mark Brown
2011-01-17 10:15 ` Alan Cox
2011-01-18 13:21 ` Mark Brown
2011-01-18 13:30 ` Koul, Vinod
2011-01-18 13:31 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.