From: Felipe Balbi <balbi@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/7] arm: mach-omap1: board-voiceblue: add missing include
Date: Tue, 18 Jan 2011 10:11:56 +0200 [thread overview]
Message-ID: <20110118081156.GI2436@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1295337165-22934-8-git-send-email-aaro.koskinen@iki.fi>
On Tue, Jan 18, 2011 at 09:52:45AM +0200, Aaro Koskinen wrote:
> Eliminates the following sparse warnings:
>
> arch/arm/mach-omap1/board-voiceblue.c:253:6: warning: symbol 'voiceblue_wdt_enable' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:261:6: warning: symbol 'voiceblue_wdt_disable' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:269:6: warning: symbol 'voiceblue_wdt_ping' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:278:6: warning: symbol 'voiceblue_reset' was not declared. Should it be static?
wasn't this caused by previous patch ?
--
balbi
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] arm: mach-omap1: board-voiceblue: add missing include
Date: Tue, 18 Jan 2011 10:11:56 +0200 [thread overview]
Message-ID: <20110118081156.GI2436@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1295337165-22934-8-git-send-email-aaro.koskinen@iki.fi>
On Tue, Jan 18, 2011 at 09:52:45AM +0200, Aaro Koskinen wrote:
> Eliminates the following sparse warnings:
>
> arch/arm/mach-omap1/board-voiceblue.c:253:6: warning: symbol 'voiceblue_wdt_enable' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:261:6: warning: symbol 'voiceblue_wdt_disable' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:269:6: warning: symbol 'voiceblue_wdt_ping' was not declared. Should it be static?
> arch/arm/mach-omap1/board-voiceblue.c:278:6: warning: symbol 'voiceblue_reset' was not declared. Should it be static?
wasn't this caused by previous patch ?
--
balbi
next prev parent reply other threads:[~2011-01-18 8:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 7:52 [PATCH 0/7] omap1 sparse warning fixes Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 1/7] arm: plat-omap: dma: make omap_dma_in_1510_mode() static Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 2/7] arm: mach-omap1: board-h2: make h2_nand_platdata static Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 3/7] arm: mach-omap1: board-innovator: make innovator_mmc_init() static Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 4/7] arm: mach-omap1: board-htcherald: make htcpld_chips and htcpld_pfdata static Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 5/7] arm: mach-omap1: board-h3: make nand_platdata static Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 7:52 ` [PATCH 6/7] arm: plat-omap: system.h: move voiceblue definitions into the board header Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 9:22 ` Russell King - ARM Linux
2011-01-18 9:22 ` Russell King - ARM Linux
2011-01-20 1:26 ` Tony Lindgren
2011-01-20 1:26 ` Tony Lindgren
2011-01-18 7:52 ` [PATCH 7/7] arm: mach-omap1: board-voiceblue: add missing include Aaro Koskinen
2011-01-18 7:52 ` Aaro Koskinen
2011-01-18 8:11 ` Felipe Balbi [this message]
2011-01-18 8:11 ` Felipe Balbi
2011-01-18 8:21 ` Felipe Balbi
2011-01-18 8:21 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118081156.GI2436@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.