All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices
Date: Tue, 18 Jan 2011 13:48:06 +0100	[thread overview]
Message-ID: <20110118124806.GA28638@lst.de> (raw)
In-Reply-To: <20110118103539.131ee08a@doriath>

On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote:
> Well, what happens is this: we screwed up with that interface and we
> should replace it soon.
> 
> I see you're not adding the new command in QMP (only in the human monitor),
> is that intentional? (qmp commands are added to the qmp-commands.hx file).
> 
> If it's intentional, then using only error_report() should be ok. If you
> plan to have a qmp version, then we'll have to choose between reporting
> a generic error version to the client, which is what's going to happen if
> you use error_report(), or add the QERR_ macros.

No, I hoped this would also add the QMP interface.  Why do we need to
declare the commands twice?  Especially as hmp-commands.hx is full of
magic that makes little sense only for human readable commands.

Any help on how to define the QERR_ macros?

  reply	other threads:[~2011-01-18 12:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 16:20 [Qemu-devel] [PATCH 0/3] allow online resizing of block devices Christoph Hellwig
2011-01-14 16:20 ` [Qemu-devel] [PATCH 1/3] block: add resize monitor command Christoph Hellwig
2011-01-17 11:28   ` Stefan Hajnoczi
2011-01-17 15:59     ` Christoph Hellwig
2011-01-17 17:36   ` Kevin Wolf
2011-01-18 12:28     ` Christoph Hellwig
2011-01-19 15:35     ` Christoph Hellwig
2011-01-19 15:49       ` Kevin Wolf
2011-01-19 15:52         ` Christoph Hellwig
2011-01-19 16:01           ` Kevin Wolf
2011-01-19 16:31             ` Christoph Hellwig
2011-01-14 16:21 ` [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize Christoph Hellwig
2011-01-14 21:06   ` Ryan Harper
2011-01-17  9:14     ` Christoph Hellwig
2011-01-14 16:21 ` [Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes Christoph Hellwig
2011-01-18 12:35 ` [Qemu-devel] [PATCH 0/3] allow online resizing of block devices Luiz Capitulino
2011-01-18 12:48   ` Christoph Hellwig [this message]
2011-01-18 13:17     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110118124806.GA28638@lst.de \
    --to=hch@lst.de \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.