* [PATCH] fs/partitions/check.c: make local symbols static
@ 2011-01-18 21:02 H Hartley Sweeten
0 siblings, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-01-18 21:02 UTC (permalink / raw)
To: Linux Kernel; +Cc: jaxboe, tj, davem, isimatu.yasuaki, adobriyan
The symbols part_alignment_offset_show and part_discard_alignment_show
are only used locally in this file and should be declared static.
Signed-off-by: H Hartley sweeten <hsweeten@visionengravers.com>
Cc: Jens Axboe <jaxboe@fusionio.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
---
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index 9c21119..de5a995 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -244,14 +244,14 @@ ssize_t part_ro_show(struct device *dev,
return sprintf(buf, "%d\n", p->policy ? 1 : 0);
}
-ssize_t part_alignment_offset_show(struct device *dev,
+static ssize_t part_alignment_offset_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset);
}
-ssize_t part_discard_alignment_show(struct device *dev,
+static ssize_t part_discard_alignment_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/partitions/check.c: make local symbols static
2011-06-10 22:26 H Hartley Sweeten
2011-06-11 12:22 ` Tejun Heo
@ 2011-06-13 9:47 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2011-06-13 9:47 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, isimatu.yasuaki, adobriyan, tj
On 2011-06-11 00:26, H Hartley Sweeten wrote:
> The symbols part_ro_show, part_alignment_offset_show, and
> part_discard_alignment_show are not used outside this file and
> should be marked static.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/partitions/check.c: make local symbols static
2011-06-10 22:26 H Hartley Sweeten
@ 2011-06-11 12:22 ` Tejun Heo
2011-06-13 9:47 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2011-06-11 12:22 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, jaxboe, isimatu.yasuaki, adobriyan
On Fri, Jun 10, 2011 at 03:26:59PM -0700, H Hartley Sweeten wrote:
> The symbols part_ro_show, part_alignment_offset_show, and
> part_discard_alignment_show are not used outside this file and
> should be marked static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jens Axboe <jaxboe@fusionio.com>
> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Tejun Heo <tj@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fs/partitions/check.c: make local symbols static
@ 2011-06-10 22:26 H Hartley Sweeten
2011-06-11 12:22 ` Tejun Heo
2011-06-13 9:47 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-06-10 22:26 UTC (permalink / raw)
To: Linux Kernel; +Cc: jaxboe, isimatu.yasuaki, adobriyan, tj
The symbols part_ro_show, part_alignment_offset_show, and
part_discard_alignment_show are not used outside this file and
should be marked static.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jens Axboe <jaxboe@fusionio.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
---
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index d545e97..e3c63d1 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -237,22 +237,22 @@ ssize_t part_size_show(struct device *dev,
return sprintf(buf, "%llu\n",(unsigned long long)p->nr_sects);
}
-ssize_t part_ro_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_ro_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%d\n", p->policy ? 1 : 0);
}
-ssize_t part_alignment_offset_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_alignment_offset_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset);
}
-ssize_t part_discard_alignment_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_discard_alignment_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%u\n", p->discard_alignment);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-13 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-18 21:02 [PATCH] fs/partitions/check.c: make local symbols static H Hartley Sweeten
2011-06-10 22:26 H Hartley Sweeten
2011-06-11 12:22 ` Tejun Heo
2011-06-13 9:47 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.