[PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

[PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

[Aurelien Jarno]

Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
the virtio code there. Used to enable the virtio drivers under QEMU.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 arch/mips/Kconfig |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index f489ec3..f9d6a83 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2400,4 +2400,20 @@ source "security/Kconfig"
 
 source "crypto/Kconfig"
 
+menuconfig VIRTUALIZATION
+	bool "Virtualization"
+	default n
+	---help---
+	  Say Y here to get to see options for using your Linux host to run other
+	  operating systems inside virtual machines (guests).
+	  This option alone does not add any kernel code.
+
+	  If you say N, all options in this submenu will be skipped and disabled.
+
+if VIRTUALIZATION
+
+source drivers/virtio/Kconfig
+
+endif # VIRTUALIZATION
+
 source "lib/Kconfig"
-- 
1.7.2.3

[PATCH 2/2] MIPS: Malta: enable Cirrus FB console

[Aurelien Jarno]

While most users of a physical Malta board are using the serial port
as the console, a lot of QEMU users would prefer to interact with a
graphical console. Enable the Cirrus FB support in the Malta default
configuration to make that possible. Note that the default console will
still be the serial port, users have to pass "console=tty0" to the
kernel to use the Cirrus FB.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 arch/mips/configs/malta_defconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
index b455d0f..9d03b68 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -369,7 +369,10 @@ CONFIG_VT_HW_CONSOLE_BINDING=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 # CONFIG_HWMON is not set
+CONFIG_FB=y
+CONFIG_FB_CIRRUS=y
 # CONFIG_VGA_CONSOLE is not set
+CONFIG_FRAMEBUFFER_CONSOLE=y
 CONFIG_HID=m
 CONFIG_LEDS_CLASS=m
 CONFIG_LEDS_TRIGGER_TIMER=m
-- 
1.7.2.3

Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

[Ralf Baechle]

On Tue, Jan 18, 2011 at 12:20:44PM +0100, Aurelien Jarno wrote:

> Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
> the virtio code there. Used to enable the virtio drivers under QEMU.

Good one.  Even though a "feature" it may deserve backporting to -stable.

Applied,

  Ralf

  Ralf

Re: [PATCH 2/2] MIPS: Malta: enable Cirrus FB console

[Ralf Baechle]

On Tue, Jan 18, 2011 at 12:20:45PM +0100, Aurelien Jarno wrote:

> While most users of a physical Malta board are using the serial port
> as the console, a lot of QEMU users would prefer to interact with a
> graphical console. Enable the Cirrus FB support in the Malta default
> configuration to make that possible. Note that the default console will
> still be the serial port, users have to pass "console=tty0" to the
> kernel to use the Cirrus FB.

Thanks for sorting this out.  Applied,

  Ralf

Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

[Christoph Hellwig]

On Tue, Jan 18, 2011 at 12:20:44PM +0100, Aurelien Jarno wrote:
> Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
> the virtio code there. Used to enable the virtio drivers under QEMU.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/mips/Kconfig |   16 ++++++++++++++++

> +menuconfig VIRTUALIZATION
> +	bool "Virtualization"
> +	default n
> +	---help---
> +	  Say Y here to get to see options for using your Linux host to run other
> +	  operating systems inside virtual machines (guests).
> +	  This option alone does not add any kernel code.
> +
> +	  If you say N, all options in this submenu will be skipped and disabled.

This item seems rather misleading as you're using virtio drivers as a
guest.  I think the right fix is to just remove the VIRTUALIZATION
dependency for the qemu drivers and just include them from
drivers/Kconfig for all architectures.  There aren't a whole lot Linux
architectures that don't have a qemu emulation these days.

Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

[Aurelien Jarno]

On Wed, Jan 19, 2011 at 03:30:49PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 18, 2011 at 12:20:44PM +0100, Aurelien Jarno wrote:
> > Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
> > the virtio code there. Used to enable the virtio drivers under QEMU.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  arch/mips/Kconfig |   16 ++++++++++++++++
> 
> > +menuconfig VIRTUALIZATION
> > +	bool "Virtualization"
> > +	default n
> > +	---help---
> > +	  Say Y here to get to see options for using your Linux host to run other
> > +	  operating systems inside virtual machines (guests).
> > +	  This option alone does not add any kernel code.
> > +
> > +	  If you say N, all options in this submenu will be skipped and disabled.
> 
> This item seems rather misleading as you're using virtio drivers as a
> guest.  I think the right fix is to just remove the VIRTUALIZATION
> dependency for the qemu drivers and just include them from
> drivers/Kconfig for all architectures.  There aren't a whole lot Linux
> architectures that don't have a qemu emulation these days.
> 

Pulling drivers/Kconfig from drivers may not be the best option either,
as it only pulls "PCI driver for virtio devices" and "Virtio balloon
driver", which actually doesn't really belong to drivers, but maybe to 
"Bus options (PCI etc.)" and "Processor type and features".

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net