All of lore.kernel.org
 help / color / mirror / Atom feed
* XFS - issues with writes using sync
@ 2011-01-20  5:04 Amit Sahrawat
  2011-01-20  5:17 ` Dave Chinner
  0 siblings, 1 reply; 8+ messages in thread
From: Amit Sahrawat @ 2011-01-20  5:04 UTC (permalink / raw)
  To: Dave Chinner, xfs


[-- Attachment #1.1: Type: text/plain, Size: 7967 bytes --]

Hi,

I am facing issues in XFS for a simple test case.
*Target:* ARM
*Kernel version:* 2.6.35.9

*Test case:*
mkfs.xfs -f /dev/sda2
mount -t xfs /dev/sda2 /mnt/usb/sda2
(Run script - trying to fragment the XFS formatted partition)
#!/bin/sh
index=0
while [ "$?" == 0 ]
do
index=$((index+1))
sync
cp /mnt/usb/sda1/setupfile /mnt/usb/sda2/setupfile.$index
done

Partition Size on which files are being created - 1GB(I need to fragment
this first to run other cases)
Size of *'setupfile'*  - 16K

There used be no such issues till *2.6.34*(last XFS version where we tried
to create setup). There is no reset involved this time, just simple running
the script caused this issue.

*Back Trace:*
#> ./createsetup.sh
kernel BUG at fs/buffer.c:396!
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = c0004000
[00000000] *pgd=00000000
Internal error: Oops: 817 [#1] PREEMPT
last sysfs file:
/sys/devices/platform/ehci-sdp.1/usb2/2-1/2-1.3/2-1.3:1.0/host0/target0:0:0/0:0:0:0/model
Modules linked in:
CPU: 0    Not tainted  (2.6.35.9 #4)
PC is at __bug+0x24/0x30
LR is at walk_stackframe+0x24/0x40
pc : [<c04483e8>]    lr : [<c04481b8>]    psr: 60000013
sp : c35cfee0  ip : c35cfdd0  fp : c35cfeec
r10: c05c7b64  r9 : c35896a8  r8 : c35c07f0
r7 : c7856688  r6 : c78585e0  r5 : c402a960  r4 : c78566c8
r3 : 00000000  r2 : c35cfe30  r1 : c35cfe00  r0 : 00000025
Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
Control: 10c53c7d  Table: 83c28059  DAC: 00000017
Process xfsdatad/0 (pid: 340, stack limit = 0xc35ce2e8)
Stack: (0xc35cfee0 to 0xc35d0000)
fee0: c35cff2c c35cfef0 c05126e4 c04483d0 00000004 c78584c0 c78585e0
c05c78b4
ff00: c35cff2c c35cff10 c05a51cc c05c0220 c78584c0 c35c07c8 c78584c0
c78585e0
ff20: c35cff4c c35cff30 c05c7a50 c05125fc c35c07c8 c35c07f0 c35c07f4
c3d264a0
ff40: c35cff74 c35cff50 c05c7c4c c05c7a28 c35cff74 c35cff60 c35ce000
c35896a0
ff60: c35c07f4 c3d264a0 c35cffc4 c35cff78 c0482874 c05c7b70 c35cff9c
c35cff88
ff80: c06f7158 00000000 c3d264a0 c0486820 c35cff90 c35cff90 c06f2bb4
c3c1fec0
ffa0: c35cffcc c048268c c35896a0 00000000 00000000 00000000 c35cfff4
c35cffc8
ffc0: c0486380 c0482698 00000000 00000000 c35cffd0 c35cffd0 c3c1fec0
c04862fc
ffe0: c046eeb8 00000013 00000000 c35cfff8 c046eeb8 c0486308 00000000
00000000
Backtrace:
[<c04483c4>] (__bug+0x0/0x30) from [<c05126e4>]
(end_buffer_async_write+0xf4/0x1c8)
[<c05125f0>] (end_buffer_async_write+0x0/0x1c8) from [<c05c7a50>]
(xfs_destroy_ioend+0x34/0x84)
 r6:c78585e0 r5:c78584c0 r4:c35c07c8
[<c05c7a1c>] (xfs_destroy_ioend+0x0/0x84) from [<c05c7c4c>]
(xfs_end_io+0xe8/0xf0)
 r7:c3d264a0 r6:c35c07f4 r5:c35c07f0 r4:c35c07c8
[<c05c7b64>] (xfs_end_io+0x0/0xf0) from [<c0482874>]
(worker_thread+0x1e8/0x294)
 r7:c3d264a0 r6:c35c07f4 r5:c35896a0 r4:c35ce000
[<c048268c>] (worker_thread+0x0/0x294) from [<c0486380>] (kthread+0x84/0x8c)
[<c04862fc>] (kthread+0x0/0x8c) from [<c046eeb8>] (do_exit+0x0/0x6cc)
 r7:00000013 r6:c046eeb8 r5:c04862fc r4:c3c1fec0
Code: e59f0010 e1a01003 eb0aa878 e3a03000 (e5833000)
---[ end trace 016e72fe751b35ae ]---
^C^Z[1] + Stopped                    ./createsetup.sh

After this I tried to unmount the XFS partition,

#umount /mnt/usb/sda2 (This command hangs and never returns)

Then, I did a reset of the target to check the state of XFS partition on
next mount.

*Back trace:*
#> mount /dev/sda2 /mnt/
XFS mounting filesystem sda2
Starting XFS recovery on filesystem: sda2 (logdev: internal)
Filesystem "sda2": XFS internal error xlog_valid_rec_header(1) at line 3431
of file fs/xfs/xfs_log_recover.c.  Caller 0xc05b95d8

Backtrace:
[<c04486ac>] (dump_backtrace+0x0/0x110) from [<c06f24e0>]
(dump_stack+0x18/0x1c)
 r6:c324e000 r5:00000000 r4:000012bb r3:c3629be0
[<c06f24c8>] (dump_stack+0x0/0x1c) from [<c05a07e8>]
(xfs_error_report+0x4c/0x5c)
[<c05a079c>] (xfs_error_report+0x0/0x5c) from [<c05b5870>]
(xlog_valid_rec_header+0xe4/0x10c)
[<c05b578c>] (xlog_valid_rec_header+0x0/0x10c) from [<c05b95d8>]
(xlog_do_recovery_pass+0x80/0x650)
 r7:00000000 r6:c324e000 r5:c36d2440 r4:c3044220
[<c05b9558>] (xlog_do_recovery_pass+0x0/0x650) from [<c05b9bf4>]
(xlog_do_log_recovery+0x4c/0x90)
[<c05b9ba8>] (xlog_do_log_recovery+0x0/0x90) from [<c05b9c58>]
(xlog_do_recover+0x20/0x120)
 r9:00000000 r8:0001e91e r7:00000000 r6:000012bb r5:00000000
r4:c3044220
[<c05b9c38>] (xlog_do_recover+0x0/0x120) from [<c05b9de0>]
(xlog_recover+0x88/0xa8)
 r9:00000000 r8:0001e91e r7:00000000 r6:000012bb r5:00000000
r4:c3044220
[<c05b9d58>] (xlog_recover+0x0/0xa8) from [<c05b2888>]
(xfs_log_mount+0xec/0x17c)
 r7:00000000 r6:00000000 r4:c300fc00
[<c05b279c>] (xfs_log_mount+0x0/0x17c) from [<c05bc6a4>]
(xfs_mountfs+0x310/0x674)
 r9:00000000 r8:0001e91e r7:000004b0 r6:00002580 r5:c05d4f84
r4:c300fc00
[<c05bc394>] (xfs_mountfs+0x0/0x674) from [<c05d4f84>]
(xfs_fs_fill_super+0x1f8/0x36c)
 r9:00000040 r8:00000400 r7:c05d4d8c r6:00000000 r5:c36fd600
r4:c300fc00
[<c05d4d8c>] (xfs_fs_fill_super+0x0/0x36c) from [<c04ee600>]
(get_sb_bdev+0x114/0x170)
[<c04ee4ec>] (get_sb_bdev+0x0/0x170) from [<c05d2f44>]
(xfs_fs_get_sb+0x24/0x30)
[<c05d2f20>] (xfs_fs_get_sb+0x0/0x30) from [<c04ed138>]
(vfs_kern_mount+0x64/0x114)
[<c04ed0d4>] (vfs_kern_mount+0x0/0x114) from [<c04ed244>]
(do_kern_mount+0x3c/0xe0)
 r8:00008000 r7:c31db500 r6:c32eb000 r5:c365bf20 r4:c07f6a6c
[<c04ed208>] (do_kern_mount+0x0/0xe0) from [<c0506594>]
(do_mount+0x700/0x77c)
 r8:00008000 r7:00000000 r6:00000000 r5:c31db500 r4:00000020
r3:c32eb000
[<c0505e94>] (do_mount+0x0/0x77c) from [<c050669c>] (sys_mount+0x8c/0xcc)
[<c0506610>] (sys_mount+0x0/0xcc) from [<c04449a0>]
(ret_fast_syscall+0x0/0x30)
 r7:00000015 r6:001854e0 r5:bee32780 r4:00186028
XFS: log mount/recovery failed: error 117
XFS: log mount failed
mount: mounting /dev/sda2 on /mnt/ failed: Structure needs cleaning


Tried to us xfs_repair on the device
#> xfs_repair /dev/sda2
Phase 1 - find and verify superblock...
Phase 2 - using internal log
        - zero log...
ERROR: The filesystem has valuable metadata changes in a log which needs to
be replayed.  Mount the filesystem to replay the log, and unmount it before
re-running xfs_repair.  If you are unable to mount the filesystem, then use
the -L option to destroy the log and attempt a repair.
Note that destroying the log may cause corruption -- please attempt a mount
of the filesystem before doing this.

#> xfs_repair -L /dev/sda2
Phase 1 - find and verify superblock...
Phase 2 - using internal log
        - zero log...
ALERT: The filesystem has valuable metadata changes in a log which is being
destroyed because the -L option was used.
        - scan filesystem freespace and inode maps...
        - found root inode chunk
Phase 3 - for each AG...
        - scan and clear agi unlinked lists...
        - process known inodes and perform inode discovery...
        - agno = 0
bad hash ordering in block 8388617 of directory inode 128
imap claims a free inode 200248 is in use, correcting imap and clearing
inode
cleared inode 200248
        - agno = 1
        - agno = 2
        - agno = 3
        - process newly discovered inodes...
Phase 4 - check for duplicate blocks...
        - setting up duplicate extent list...
        - check for inodes claiming duplicate blocks...
        - agno = 0
entry "setupfile.3126" at block 22 offset 2576 in directory inode 128
references free inode 200248
        clearing inode number in entry at offset 2576...
        - agno = 1
        - agno = 2
        - agno = 3
Phase 5 - rebuild AG headers and trees...
        - reset superblock...
Phase 6 - check inode connectivity...
        - resetting contents of realtime bitmap and summary inodes
        - traversing filesystem ...
rebuilding directory inode 128
        - traversal finished ...
        - moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
done

Please let me know if there is anything i have missed. Also, if it is good
enough to 2.6.35.9 for product?

Thanks & Regards,
Amit Sahrawat

[-- Attachment #1.2: Type: text/html, Size: 9394 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  5:04 XFS - issues with writes using sync Amit Sahrawat
@ 2011-01-20  5:17 ` Dave Chinner
  2011-01-20  6:07   ` Amit Sahrawat
  0 siblings, 1 reply; 8+ messages in thread
From: Dave Chinner @ 2011-01-20  5:17 UTC (permalink / raw)
  To: Amit Sahrawat; +Cc: xfs

On Thu, Jan 20, 2011 at 10:34:30AM +0530, Amit Sahrawat wrote:
> Hi,
> 
> I am facing issues in XFS for a simple test case.
> *Target:* ARM
> *Kernel version:* 2.6.35.9
> 
> *Test case:*
> mkfs.xfs -f /dev/sda2
> mount -t xfs /dev/sda2 /mnt/usb/sda2
> (Run script - trying to fragment the XFS formatted partition)
> #!/bin/sh
> index=0
> while [ "$?" == 0 ]
> do
> index=$((index+1))
> sync
> cp /mnt/usb/sda1/setupfile /mnt/usb/sda2/setupfile.$index
> done
> 
> Partition Size on which files are being created - 1GB(I need to fragment
> this first to run other cases)
> Size of *'setupfile'*  - 16K
> 
> There used be no such issues till *2.6.34*(last XFS version where we tried
> to create setup). There is no reset involved this time, just simple running
> the script caused this issue.

You have a known good version, a known bad version and a
reproducable test case. i.e. everything you need to run a git bisect
and find the commit introduced the regression. Can you do this and
tell us what that commit is?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  5:17 ` Dave Chinner
@ 2011-01-20  6:07   ` Amit Sahrawat
  2011-01-20  6:38     ` Amit Sahrawat
  2011-01-20  6:41     ` Dave Chinner
  0 siblings, 2 replies; 8+ messages in thread
From: Amit Sahrawat @ 2011-01-20  6:07 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 1481 bytes --]

Hi,

I will try to find out the cause for this.
Meanwhile, just a small request/suggestion - in the past this type of
testcases have helped us in finding many problems in XFS.
Can something like this be added to xfstests? This might help.

Thanks,
Amit Sahrawat
On Thu, Jan 20, 2011 at 10:47 AM, Dave Chinner <david@fromorbit.com> wrote:

> On Thu, Jan 20, 2011 at 10:34:30AM +0530, Amit Sahrawat wrote:
> > Hi,
> >
> > I am facing issues in XFS for a simple test case.
> > *Target:* ARM
> > *Kernel version:* 2.6.35.9
> >
> > *Test case:*
> > mkfs.xfs -f /dev/sda2
> > mount -t xfs /dev/sda2 /mnt/usb/sda2
> > (Run script - trying to fragment the XFS formatted partition)
> > #!/bin/sh
> > index=0
> > while [ "$?" == 0 ]
> > do
> > index=$((index+1))
> > sync
> > cp /mnt/usb/sda1/setupfile /mnt/usb/sda2/setupfile.$index
> > done
> >
> > Partition Size on which files are being created - 1GB(I need to fragment
> > this first to run other cases)
> > Size of *'setupfile'*  - 16K
> >
> > There used be no such issues till *2.6.34*(last XFS version where we
> tried
> > to create setup). There is no reset involved this time, just simple
> running
> > the script caused this issue.
>
> You have a known good version, a known bad version and a
> reproducable test case. i.e. everything you need to run a git bisect
> and find the commit introduced the regression. Can you do this and
> tell us what that commit is?
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>

[-- Attachment #1.2: Type: text/html, Size: 2049 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  6:07   ` Amit Sahrawat
@ 2011-01-20  6:38     ` Amit Sahrawat
  2011-01-20 10:49       ` Dave Chinner
  2011-01-20  6:41     ` Dave Chinner
  1 sibling, 1 reply; 8+ messages in thread
From: Amit Sahrawat @ 2011-01-20  6:38 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 5116 bytes --]

Hi,
I tried with the same test case - just removed 'sync' command from the
script(please check script below) to check the behaviour.

Please find the logs:
#> ./createsetup.sh
------------[ cut here ]------------
WARNING: at lib/list_debug.c:30 __list_add+0x6c/0x90()
list_add corruption. prev->next should be next (c78699c0), but was c78299c0.
(prev=c78699c0).
Modules linked in:
Backtrace:
[<c04486ac>] (dump_backtrace+0x0/0x110) from [<c06ee0e0>]
(dump_stack+0x18/0x1c)
 r6:c07bc5e1 r5:0000001e r4:c7c01d38 r3:00000000
[<c06ee0c8>] (dump_stack+0x0/0x1c) from [<c046b5fc>]
(warn_slowpath_common+0x54/0x6c)
[<c046b5a8>] (warn_slowpath_common+0x0/0x6c) from [<c046b6b8>]
(warn_slowpath_fmt+0x38/0x40)
 r8:00000000 r7:c05cabd8 r6:c7c01d80 r5:c78699c0 r4:c78699c0
r3:00000009
[<c046b680>] (warn_slowpath_fmt+0x0/0x40) from [<c060b89c>]
(__list_add+0x6c/0x90)
 r3:c78699c0 r2:c07bc6b3
[<c060b830>] (__list_add+0x0/0x90) from [<c06f0710>]
(__down_write_nested+0xbc/0x10c)
 r6:c78699bc r5:60000013 r4:c302d820
[<c06f0654>] (__down_write_nested+0x0/0x10c) from [<c06f0774>]
(__down_write+0x14/0x18)
 r6:c31324a0 r5:00000005 r4:c78699bc
[<c06f0760>] (__down_write+0x0/0x18) from [<c06efd50>]
(down_write+0x28/0x30)
[<c06efd28>] (down_write+0x0/0x30) from [<c05a21ac>] (xfs_ilock+0x28/0xe8)
 r4:c7869940 r3:00000000
[<c05a2184>] (xfs_ilock+0x0/0xe8) from [<c05cabd8>]
(xfs_file_aio_write+0x1d4/0x8cc)
 r7:00000001 r6:c31324a0 r5:00000001 r4:c7869940
[<c05caa04>] (xfs_file_aio_write+0x0/0x8cc) from [<c04eb404>]
(do_sync_write+0xa0/0xe0)
[<c04eb364>] (do_sync_write+0x0/0xe0) from [<c04ec028>]
(vfs_write+0xbc/0x178)
 r6:bee925a0 r5:c31324a0 r4:00000f38
[<c04ebf6c>] (vfs_write+0x0/0x178) from [<c04ec1ac>] (sys_write+0x44/0x70)
 r7:00000004 r6:00000f38 r5:bee925a0 r4:c31324a0
[<c04ec168>] (sys_write+0x0/0x70) from [<c04449a0>]
(ret_fast_syscall+0x0/0x30)
 r9:c7c00000 r8:c0444b48 r6:bee925a0 r5:00000f38 r4:001854e0
---[ end trace 8124d49a241e0763 ]---
INFO: task cp:5445 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
cp            D c06ee75c     0  5445   2173 0x00000000
Backtrace:
[<c06ee398>] (schedule+0x0/0x454) from [<c06f0748>]
(__down_write_nested+0xf4/0x10c)
 r9:c7869a60 r8:00000000 r7:c05cabd8 r6:c78699bc r5:60000013
r4:c302d820
[<c06f0654>] (__down_write_nested+0x0/0x10c) from [<c06f0774>]
(__down_write+0x14/0x18)
 r6:c31324a0 r5:00000005 r4:c78699bc
[<c06f0760>] (__down_write+0x0/0x18) from [<c06efd50>]
(down_write+0x28/0x30)
[<c06efd28>] (down_write+0x0/0x30) from [<c05a21ac>] (xfs_ilock+0x28/0xe8)
 r4:c7869940 r3:00000000
[<c05a2184>] (xfs_ilock+0x0/0xe8) from [<c05cabd8>]
(xfs_file_aio_write+0x1d4/0x8cc)
 r7:00000001 r6:c31324a0 r5:00000001 r4:c7869940
[<c05caa04>] (xfs_file_aio_write+0x0/0x8cc) from [<c04eb404>]
(do_sync_write+0xa0/0xe0)
[<c04eb364>] (do_sync_write+0x0/0xe0) from [<c04ec028>]
(vfs_write+0xbc/0x178)
 r6:bee925a0 r5:c31324a0 r4:00000f38
[<c04ebf6c>] (vfs_write+0x0/0x178) from [<c04ec1ac>] (sys_write+0x44/0x70)
 r7:00000004 r6:00000f38 r5:bee925a0 r4:c31324a0
[<c04ec168>] (sys_write+0x0/0x70) from [<c04449a0>]
(ret_fast_syscall+0x0/0x30)
 r9:c7c00000 r8:c0444b48 r6:bee925a0 r5:00000f38 r4:001854e0
^C^Z[1] + Stopped                    ./createsetup.sh
I really doubt about the stability of 2.6.35.9, it is not passing our basic
tests. Checking few more things, before deciding about the patches which got
introduced between 2.6.34 ~ 2.6.35.9(around 102).

Thanks,
Amit Sahrawat
On Thu, Jan 20, 2011 at 11:37 AM, Amit Sahrawat
<amit.sahrawat83@gmail.com>wrote:

> Hi,
>
> I will try to find out the cause for this.
> Meanwhile, just a small request/suggestion - in the past this type of
> testcases have helped us in finding many problems in XFS.
> Can something like this be added to xfstests? This might help.
>
> Thanks,
> Amit Sahrawat
>   On Thu, Jan 20, 2011 at 10:47 AM, Dave Chinner <david@fromorbit.com>wrote:
>
>> On Thu, Jan 20, 2011 at 10:34:30AM +0530, Amit Sahrawat wrote:
>> > Hi,
>> >
>> > I am facing issues in XFS for a simple test case.
>> > *Target:* ARM
>> > *Kernel version:* 2.6.35.9
>> >
>> > *Test case:*
>> > mkfs.xfs -f /dev/sda2
>> > mount -t xfs /dev/sda2 /mnt/usb/sda2
>> > (Run script - trying to fragment the XFS formatted partition)
>> > #!/bin/sh
>> > index=0
>> > while [ "$?" == 0 ]
>> > do
>> > index=$((index+1))
>> > sync
>> > cp /mnt/usb/sda1/setupfile /mnt/usb/sda2/setupfile.$index
>> > done
>> >
>> > Partition Size on which files are being created - 1GB(I need to fragment
>> > this first to run other cases)
>> > Size of *'setupfile'*  - 16K
>> >
>> > There used be no such issues till *2.6.34*(last XFS version where we
>> tried
>> > to create setup). There is no reset involved this time, just simple
>> running
>> > the script caused this issue.
>>
>> You have a known good version, a known bad version and a
>> reproducable test case. i.e. everything you need to run a git bisect
>> and find the commit introduced the regression. Can you do this and
>> tell us what that commit is?
>>
>> Cheers,
>>
>> Dave.
>> --
>> Dave Chinner
>> david@fromorbit.com
>>
>
>

[-- Attachment #1.2: Type: text/html, Size: 6558 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  6:07   ` Amit Sahrawat
  2011-01-20  6:38     ` Amit Sahrawat
@ 2011-01-20  6:41     ` Dave Chinner
  2011-01-20  7:09       ` Amit Sahrawat
  1 sibling, 1 reply; 8+ messages in thread
From: Dave Chinner @ 2011-01-20  6:41 UTC (permalink / raw)
  To: Amit Sahrawat; +Cc: xfs

On Thu, Jan 20, 2011 at 11:37:44AM +0530, Amit Sahrawat wrote:
> Hi,
> 
> I will try to find out the cause for this.
> Meanwhile, just a small request/suggestion - in the past this type of
> testcases have helped us in finding many problems in XFS.
> Can something like this be added to xfstests? This might help.

Definitely.  We're always looking for more people to add tests that
expose problems to xfstests. :) We try to keep individual test
runtime to as little as possible - under 5 minutes for the auto
group, under 15s for the quick group, but by the looks of it the
test you are running doesn't take that long to run.

FWIW, there are already tests that cause worst case filesystem
fragmentation as part of their test setup (e.g. test 042) but the
coverage of such issues could definitely be improved. Also, the way
we generate fragmented filesystems - by writing files and then
removing a subset - could be greatly sped up by preallocation and
hole punching. There's no need to write data when we could just use
unwritten extents to do the same thing...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  6:41     ` Dave Chinner
@ 2011-01-20  7:09       ` Amit Sahrawat
  0 siblings, 0 replies; 8+ messages in thread
From: Amit Sahrawat @ 2011-01-20  7:09 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 1864 bytes --]

On Thu, Jan 20, 2011 at 12:11 PM, Dave Chinner <david@fromorbit.com> wrote:

> On Thu, Jan 20, 2011 at 11:37:44AM +0530, Amit Sahrawat wrote:
> > Hi,
> >
> > I will try to find out the cause for this.
> > Meanwhile, just a small request/suggestion - in the past this type of
> > testcases have helped us in finding many problems in XFS.
> > Can something like this be added to xfstests? This might help.
>
> Definitely.  We're always looking for more people to add tests that
> expose problems to xfstests. :) We try to keep individual test
> runtime to as little as possible - under 5 minutes for the auto
> group, under 15s for the quick group, but by the looks of it the
> test you are running doesn't take that long to run.
>


> >> Yes, the test case we are using is not taking much time this time to
> cause issue - around 3-4 minutes.
>


> FWIW, there are already tests that cause worst case filesystem
> fragmentation as part of their test setup (e.g. test 042) but the
> coverage of such issues could definitely be improved. Also, the way
> we generate fragmented filesystems - by writing files and then
> removing a subset - could be greatly sped up by preallocation and
> hole punching. There's no need to write data when we could just use
> unwritten extents to do the same thing...
>
>


>  >> We basically fragment by doing following steps:
>
 Full the disk with same size files (in this case it is 16k)
Then, randomly remove files from the disk.
Doing so, allows us to create files as per our requirement - complete
control when we need - single extent, multiple extent files, Btree format
file, single leaf file, multiple leaf file - It allows us ease to use XFS.
I hope you are getting what I am trying to say.

But, in this case - it starts causing issue at the very first stage - just
copying 16k file to make disk full.

Thanks,
Amit Sahrawat

[-- Attachment #1.2: Type: text/html, Size: 2853 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20  6:38     ` Amit Sahrawat
@ 2011-01-20 10:49       ` Dave Chinner
  2011-01-20 11:34         ` Amit Sahrawat
  0 siblings, 1 reply; 8+ messages in thread
From: Dave Chinner @ 2011-01-20 10:49 UTC (permalink / raw)
  To: Amit Sahrawat; +Cc: xfs

On Thu, Jan 20, 2011 at 12:08:21PM +0530, Amit Sahrawat wrote:
> Hi,
> I tried with the same test case - just removed 'sync' command from the
> script(please check script below) to check the behaviour.
....
> I really doubt about the stability of 2.6.35.9, it is not passing our basic
> tests. Checking few more things, before deciding about the patches which got
> introduced between 2.6.34 ~ 2.6.35.9(around 102).

2.6.35 is perfectly fine on x86, so I suspect that it is something
ARM specific. Most likely it is related to the VIVT platform support
changes, but you really need to bisect so we know exactly waht
change has broken such basic functionality on your platform.

Note that the bug may not even be in XFS, so you really need to do a
full bisect, not just of the changes in xfs in that time...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: XFS - issues with writes using sync
  2011-01-20 10:49       ` Dave Chinner
@ 2011-01-20 11:34         ` Amit Sahrawat
  0 siblings, 0 replies; 8+ messages in thread
From: Amit Sahrawat @ 2011-01-20 11:34 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]

On Thu, Jan 20, 2011 at 4:19 PM, Dave Chinner <david@fromorbit.com> wrote:

> On Thu, Jan 20, 2011 at 12:08:21PM +0530, Amit Sahrawat wrote:
> > Hi,
> > I tried with the same test case - just removed 'sync' command from the
> > script(please check script below) to check the behaviour.
> ....
> > I really doubt about the stability of 2.6.35.9, it is not passing our
> basic
> > tests. Checking few more things, before deciding about the patches which
> got
> > introduced between 2.6.34 ~ 2.6.35.9(around 102).
>
> 2.6.35 is perfectly fine on x86, so I suspect that it is something
> ARM specific. Most likely it is related to the VIVT platform support
> changes, but you really need to bisect so we know exactly waht
> change has broken such basic functionality on your platform.
>
> >> yes, this is quite possible - last time, we found an issue like this on
MIPS(related with flushing).


> Note that the bug may not even be in XFS, so you really need to do a
> full bisect, not just of the changes in xfs in that time...
>
>> if other activities are not assigned in the mean time :), I will verify
the exact reason for this issue. I do have working and issue causing setups
- so will check with both and update.

Thanks,
Amit Sahrawat

[-- Attachment #1.2: Type: text/html, Size: 1811 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-01-20 11:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-20  5:04 XFS - issues with writes using sync Amit Sahrawat
2011-01-20  5:17 ` Dave Chinner
2011-01-20  6:07   ` Amit Sahrawat
2011-01-20  6:38     ` Amit Sahrawat
2011-01-20 10:49       ` Dave Chinner
2011-01-20 11:34         ` Amit Sahrawat
2011-01-20  6:41     ` Dave Chinner
2011-01-20  7:09       ` Amit Sahrawat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.