All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662
@ 2011-01-21 14:45 Anisse Astier
  2011-01-21 15:36 ` Paul Menzel
  0 siblings, 1 reply; 5+ messages in thread
From: Anisse Astier @ 2011-01-21 14:45 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai



---
 sound/pci/hda/patch_realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7262980..a72c8bd 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -18292,6 +18292,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
 					ALC662_3ST_6ch_DIG),
 	SND_PCI_QUIRK_MASK(0x1854, 0xf000, 0x2000, "ASUS H13-200x",
 			   ALC663_ASUS_H13),
+	SND_PCI_QUIRK(0x1991, 0x5628, "Ordissimo EVE", ALC662_LENOVO_101E),
 	{}
 };
 
-- 
1.7.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662
  2011-01-21 14:45 [PATCH] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662 Anisse Astier
@ 2011-01-21 15:36 ` Paul Menzel
  2011-01-24 13:35   ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2011-01-21 15:36 UTC (permalink / raw)
  To: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 501 bytes --]

Dear Anisse,


Am Freitag, den 21.01.2011, 15:45 +0100 schrieb Anisse Astier:

[…]

without your Signed-off-by line [1] your patch cannot be committed.

Additionally it would be great if you could add more detail. What did
not work with your sound card and had it ever worked before?


Thanks,

Paul


[1] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD
    see section 12

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662
  2011-01-21 15:36 ` Paul Menzel
@ 2011-01-24 13:35   ` Takashi Iwai
       [not found]     ` <20110124174300.079c8cb7@destiny.ordissimo>
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2011-01-24 13:35 UTC (permalink / raw)
  To: Anisse Astier; +Cc: alsa-devel, Paul Menzel

At Fri, 21 Jan 2011 16:36:28 +0100,
Paul Menzel wrote:
> 
> Dear Anisse,
> 
> 
> Am Freitag, den 21.01.2011, 15:45 +0100 schrieb Anisse Astier:
> 
> […]
> 
> without your Signed-off-by line [1] your patch cannot be committed.
> 
> Additionally it would be great if you could add more detail. What did
> not work with your sound card and had it ever worked before?

Right, could you repost your patch with the fix Paul suggested?


thanks,

Takashi

> 
> 
> Thanks,
> 
> Paul
> 
> 
> [1] http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD
>     see section 12
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH resend] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662
       [not found]     ` <20110124174300.079c8cb7@destiny.ordissimo>
@ 2011-02-10 12:14       ` Anisse Astier
  2011-02-11  7:53         ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Anisse Astier @ 2011-02-10 12:14 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai, Paul Menzel


This netbook has a only one jack output and an internal mic.

By default, mic and jack sense aren't working. Using lenovo-101e
parameters makes both work.

The device seems based on a Sharetronic Q70, so this should fix audio for
this model too.

Signed-off-by: Anisse Astier <anisse@astier.eu>
---
Hi,

Sorry for the delay. As usual, this is based on sound-2.6/for-next.

Regards,

Anisse
---
 sound/pci/hda/patch_realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1e092b3..6a43c1c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -18934,6 +18934,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
 					ALC662_3ST_6ch_DIG),
 	SND_PCI_QUIRK_MASK(0x1854, 0xf000, 0x2000, "ASUS H13-200x",
 			   ALC663_ASUS_H13),
+	SND_PCI_QUIRK(0x1991, 0x5628, "Ordissimo EVE", ALC662_LENOVO_101E),
 	{}
 };
 
-- 
1.7.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH resend] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662
  2011-02-10 12:14       ` [PATCH resend] " Anisse Astier
@ 2011-02-11  7:53         ` Takashi Iwai
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2011-02-11  7:53 UTC (permalink / raw)
  To: Anisse Astier; +Cc: alsa-devel, Paul Menzel

At Thu, 10 Feb 2011 13:14:44 +0100,
Anisse Astier wrote:
> 
> 
> This netbook has a only one jack output and an internal mic.
> 
> By default, mic and jack sense aren't working. Using lenovo-101e
> parameters makes both work.
> 
> The device seems based on a Sharetronic Q70, so this should fix audio for
> this model too.
> 
> Signed-off-by: Anisse Astier <anisse@astier.eu>
> ---
> Hi,
> 
> Sorry for the delay. As usual, this is based on sound-2.6/for-next.

Applied now.  Thanks!


Takashi

> 
> Regards,
> 
> Anisse
> ---
>  sound/pci/hda/patch_realtek.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 1e092b3..6a43c1c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -18934,6 +18934,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>  					ALC662_3ST_6ch_DIG),
>  	SND_PCI_QUIRK_MASK(0x1854, 0xf000, 0x2000, "ASUS H13-200x",
>  			   ALC663_ASUS_H13),
> +	SND_PCI_QUIRK(0x1991, 0x5628, "Ordissimo EVE", ALC662_LENOVO_101E),
>  	{}
>  };
>  
> -- 
> 1.7.3.2
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-11  7:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-21 14:45 [PATCH] ALSA: hda - add quirk for Ordissimo EVE using a realtek ALC662 Anisse Astier
2011-01-21 15:36 ` Paul Menzel
2011-01-24 13:35   ` Takashi Iwai
     [not found]     ` <20110124174300.079c8cb7@destiny.ordissimo>
2011-02-10 12:14       ` [PATCH resend] " Anisse Astier
2011-02-11  7:53         ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.