* [PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN
@ 2011-01-24 22:59 Michael Chan
2011-01-25 7:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2011-01-24 22:59 UTC (permalink / raw)
To: davem; +Cc: eric.dumazet, jesse, netdev
TSO does not work if the VLAN tag is in the packet (non-accelerated).
We may be able to remove this restriction in future firmware.
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/bnx2.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index df99edf..99e7652 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -7553,6 +7553,10 @@ bnx2_set_flags(struct net_device *dev, u32 data)
!(data & ETH_FLAG_RXVLAN))
return -EINVAL;
+ /* TSO with VLAN tag won't work with current firmware */
+ if (!(data & ETH_FLAG_TXVLAN))
+ return -EINVAL;
+
rc = ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH | ETH_FLAG_RXVLAN |
ETH_FLAG_TXVLAN);
if (rc)
--
1.6.4.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN
2011-01-24 22:59 [PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN Michael Chan
@ 2011-01-25 7:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-25 7:16 UTC (permalink / raw)
To: mchan; +Cc: eric.dumazet, jesse, netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 24 Jan 2011 14:59:02 -0800
> TSO does not work if the VLAN tag is in the packet (non-accelerated).
> We may be able to remove this restriction in future firmware.
>
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-25 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-24 22:59 [PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN Michael Chan
2011-01-25 7:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.