All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pch_gbe: don't use flush_scheduled_work()
@ 2011-01-24 14:32 Tejun Heo
  2011-01-25  7:19 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2011-01-24 14:32 UTC (permalink / raw)
  To: linux-kernel, David S. Miller; +Cc: Masayuki Ohtake, Toshiharu Okada

Directly cancel adapter->reset_task instead of using to-be-deprecated
flush_scheduled_work().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Cc: David S. Miller <davem@davemloft.net>
---
 drivers/net/pch_gbe/pch_gbe_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/net/pch_gbe/pch_gbe_main.c
===================================================================
--- work.orig/drivers/net/pch_gbe/pch_gbe_main.c
+++ work/drivers/net/pch_gbe/pch_gbe_main.c
@@ -2247,7 +2247,7 @@ static void pch_gbe_remove(struct pci_de
 	struct net_device *netdev = pci_get_drvdata(pdev);
 	struct pch_gbe_adapter *adapter = netdev_priv(netdev);
 
-	flush_scheduled_work();
+	cancel_work_sync(&adapter->reset_task);
 	unregister_netdev(netdev);
 
 	pch_gbe_hal_phy_hw_reset(&adapter->hw);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pch_gbe: don't use flush_scheduled_work()
  2011-01-24 14:32 [PATCH] pch_gbe: don't use flush_scheduled_work() Tejun Heo
@ 2011-01-25  7:19 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-25  7:19 UTC (permalink / raw)
  To: tj; +Cc: linux-kernel, masa-korg, toshiharu-linux

From: Tejun Heo <tj@kernel.org>
Date: Mon, 24 Jan 2011 15:32:25 +0100

> Directly cancel adapter->reset_task instead of using to-be-deprecated
> flush_scheduled_work().
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>

Applied, thanks Tejun.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-25  7:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-24 14:32 [PATCH] pch_gbe: don't use flush_scheduled_work() Tejun Heo
2011-01-25  7:19 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.