[PATCH] fix a shutdown regression in intel_idle

[PATCH] fix a shutdown regression in intel_idle

[Shaohua Li]

Fix a shutdown regression caused by 2a2d31c8. Looks the clockevent framework
can automatically shutdown broadcast timers for hotremove CPUs. And we get a
shutdown regression when we shutdown broadcast timer for hot remove CPU, so
just delete some code.
Also fix some section mismatch.

Reported-by: Ari Savolainen <ari.m.savolainen@gmail.com>
Signed-off-by: Shaohua Li <shaohua.li@intel.com>

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 7acb32e..1fa091e 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -263,7 +263,7 @@ static void __setup_broadcast_timer(void *arg)
 	clockevents_notify(reason, &cpu);
 }
 
-static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
+static int setup_broadcast_cpuhp_notify(struct notifier_block *n,
 		unsigned long action, void *hcpu)
 {
 	int hotcpu = (unsigned long)hcpu;
@@ -273,15 +273,11 @@ static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
 		smp_call_function_single(hotcpu, __setup_broadcast_timer,
 			(void *)true, 1);
 		break;
-	case CPU_DOWN_PREPARE:
-		smp_call_function_single(hotcpu, __setup_broadcast_timer,
-			(void *)false, 1);
-		break;
 	}
 	return NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata setup_broadcast_notifier = {
+static struct notifier_block setup_broadcast_notifier = {
 	.notifier_call = setup_broadcast_cpuhp_notify,
 };
 

Re: [PATCH] fix a shutdown regression in intel_idle

[Ozan Çağlayan]

Pazartesi 24 Ocak 2011 günü (saat 10:00:01) Shaohua Li şunları yazmıştı:
> Fix a shutdown regression caused by 2a2d31c8. Looks the clockevent framework
> can automatically shutdown broadcast timers for hotremove CPUs. And we get a
> shutdown regression when we shutdown broadcast timer for hot remove CPU, so
> just delete some code.
> Also fix some section mismatch.

stable@kernel.org was CC'ed in 2a2d31c8 so this should be CC'ed too I think.

---
Ozan Çağlayan
TUBITAK/UEKAE - Pardus Linux
http://www.pardus.org.tr/eng
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html