All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache
@ 2011-01-20 20:23 Peter Korsgaard
  2011-01-24 16:08 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2011-01-20 20:23 UTC (permalink / raw)
  To: buildroot


commit: http://git.buildroot.net/buildroot/commit/?id=464f862d82c2c1dee1f154e587e8771bbf45f780
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Cmake gets confused about ccache, so don't use ccache for cmake builds.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 package/cdrkit/cdrkit.mk |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/cdrkit/cdrkit.mk b/package/cdrkit/cdrkit.mk
index a0ce9cb..7d6899a 100644
--- a/package/cdrkit/cdrkit.mk
+++ b/package/cdrkit/cdrkit.mk
@@ -13,8 +13,9 @@ endif
 
 # CMake doesn't support having the --sysroot option directly in the
 # compiler path, so move this option to the CFLAGS/CXXFLAGS variables.
-CDRKIT_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC))
-CDRKIT_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX))
+# It also gets confused by ccache, so don't use ccache here.
+CDRKIT_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC_NOCCACHE))
+CDRKIT_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX_NOCCACHE))
 CDRKIT_TARGET_CFLAGS = $(filter --sysroot=%,$(TARGET_CC)) $(TARGET_CFLAGS)
 CDRKIT_TARGET_CXXFLAGS = $(filter --sysroot=%,$(TARGET_CXX)) $(TARGET_CXXFLAGS)
 
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache
  2011-01-20 20:23 [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache Peter Korsgaard
@ 2011-01-24 16:08 ` Thomas Petazzoni
  2011-01-24 16:14   ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2011-01-24 16:08 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 20 Jan 2011 21:23:23 +0100
Peter Korsgaard <jacmet@sunsite.dk> wrote:

> Cmake gets confused about ccache, so don't use ccache for cmake builds.

Which problems did you had exactly ?

While this is obviously the right short-term fix, it's a bit of a shame
of CMake doesn't play well with ccache, so maybe it's something I could
raise on the CMake mailing-list.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache
  2011-01-24 16:08 ` Thomas Petazzoni
@ 2011-01-24 16:14   ` Peter Korsgaard
  2011-01-24 16:55     ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2011-01-24 16:14 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Hello,
 Thomas> On Thu, 20 Jan 2011 21:23:23 +0100
 Thomas> Peter Korsgaard <jacmet@sunsite.dk> wrote:

 >> Cmake gets confused about ccache, so don't use ccache for cmake builds.

 Thomas> Which problems did you had exactly ?

See the quoted error message in the libcuefile thread:

http://lists.busybox.net/pipermail/buildroot/2011-January/040755.html

(and followups)

 Thomas> While this is obviously the right short-term fix, it's a bit of
 Thomas> a shame of CMake doesn't play well with ccache, so maybe it's
 Thomas> something I could raise on the CMake mailing-list.

Indeed. We left it here for you to have fun with once you're back from
holidays :P

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache
  2011-01-24 16:14   ` Peter Korsgaard
@ 2011-01-24 16:55     ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2011-01-24 16:55 UTC (permalink / raw)
  To: buildroot

On Mon, 24 Jan 2011 17:14:00 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

>  >> Cmake gets confused about ccache, so don't use ccache for cmake builds.
> 
>  Thomas> Which problems did you had exactly ?
> 
> See the quoted error message in the libcuefile thread:
> 
> http://lists.busybox.net/pipermail/buildroot/2011-January/040755.html
> 
> (and followups)

Thanks. In fact, I found this e-mail while going through the rest of my
Buildroot backlog (which I'm going through in a reverse chronological
order).

>  Thomas> While this is obviously the right short-term fix, it's a bit of
>  Thomas> a shame of CMake doesn't play well with ccache, so maybe it's
>  Thomas> something I could raise on the CMake mailing-list.
> 
> Indeed. We left it here for you to have fun with once you're back from
> holidays :P

Thanks so much :-)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-01-24 16:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-20 20:23 [Buildroot] [git commit master 1/1] cdrkit: fix build with ccache Peter Korsgaard
2011-01-24 16:08 ` Thomas Petazzoni
2011-01-24 16:14   ` Peter Korsgaard
2011-01-24 16:55     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.