* [Patch V2] video: fix some comments in drivers/video/console/vgacon.c
@ 2011-01-19 6:24 ` Amerigo Wang
0 siblings, 0 replies; 4+ messages in thread
From: Amerigo Wang @ 2011-01-19 6:24 UTC (permalink / raw)
To: linux-kernel
Cc: lethal, WANG Cong, Arnd Bergmann, Andrew Morton,
Greg Kroah-Hartman, Yannick Heneault, Matthew Garrett,
open list:FRAMEBUFFER LAYER
Now vgacon_scrollback_startup() uses slab, not bootmem,
the comment above it is obsolete, so does __init_refok.
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index c97491b..915fd74 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -202,11 +202,7 @@ static void vgacon_scrollback_init(int pitch)
}
}
-/*
- * Called only duing init so call of alloc_bootmen is ok.
- * Marked __init_refok to silence modpost.
- */
-static void __init_refok vgacon_scrollback_startup(void)
+static void vgacon_scrollback_startup(void)
{
vgacon_scrollback = kcalloc(CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, 1024, GFP_NOWAIT);
vgacon_scrollback_init(vga_video_num_columns * 2);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Patch V2] video: fix some comments in drivers/video/console/vgacon.c
@ 2011-01-19 6:24 ` Amerigo Wang
0 siblings, 0 replies; 4+ messages in thread
From: Amerigo Wang @ 2011-01-19 6:24 UTC (permalink / raw)
To: linux-kernel
Cc: lethal, WANG Cong, Arnd Bergmann, Andrew Morton,
Greg Kroah-Hartman, Yannick Heneault, Matthew Garrett,
open list:FRAMEBUFFER LAYER
Now vgacon_scrollback_startup() uses slab, not bootmem,
the comment above it is obsolete, so does __init_refok.
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index c97491b..915fd74 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -202,11 +202,7 @@ static void vgacon_scrollback_init(int pitch)
}
}
-/*
- * Called only duing init so call of alloc_bootmen is ok.
- * Marked __init_refok to silence modpost.
- */
-static void __init_refok vgacon_scrollback_startup(void)
+static void vgacon_scrollback_startup(void)
{
vgacon_scrollback = kcalloc(CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, 1024, GFP_NOWAIT);
vgacon_scrollback_init(vga_video_num_columns * 2);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch V2] video: fix some comments in drivers/video/console/vgacon.c
2011-01-19 6:24 ` Amerigo Wang
@ 2011-01-25 7:03 ` Paul Mundt
-1 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2011-01-25 7:03 UTC (permalink / raw)
To: Amerigo Wang
Cc: linux-kernel, Arnd Bergmann, Andrew Morton, Greg Kroah-Hartman,
Yannick Heneault, Matthew Garrett, linux-fbdev
On Wed, Jan 19, 2011 at 02:24:02PM +0800, Amerigo Wang wrote:
> Now vgacon_scrollback_startup() uses slab, not bootmem,
> the comment above it is obsolete, so does __init_refok.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch V2] video: fix some comments in drivers/video/console/vgacon.c
@ 2011-01-25 7:03 ` Paul Mundt
0 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2011-01-25 7:03 UTC (permalink / raw)
To: Amerigo Wang
Cc: linux-kernel, Arnd Bergmann, Andrew Morton, Greg Kroah-Hartman,
Yannick Heneault, Matthew Garrett, linux-fbdev
On Wed, Jan 19, 2011 at 02:24:02PM +0800, Amerigo Wang wrote:
> Now vgacon_scrollback_startup() uses slab, not bootmem,
> the comment above it is obsolete, so does __init_refok.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-25 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-19 6:24 [Patch V2] video: fix some comments in drivers/video/console/vgacon.c Amerigo Wang
2011-01-19 6:24 ` Amerigo Wang
2011-01-25 7:03 ` Paul Mundt
2011-01-25 7:03 ` Paul Mundt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.