All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] monitor: use after free in do_wav_capture()
@ 2011-01-21 10:53 Isaku Yamahata
  2011-01-25  8:24 ` Aurelien Jarno
  0 siblings, 1 reply; 2+ messages in thread
From: Isaku Yamahata @ 2011-01-21 10:53 UTC (permalink / raw)
  To: qemu-devel; +Cc: yamahata

use after free in do_wav_capture() on the error path.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 monitor.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/monitor.c b/monitor.c
index d291158..cab5f20 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2511,6 +2511,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
     if (wav_start_capture (s, path, freq, bits, nchannels)) {
         monitor_printf(mon, "Faied to add wave capture\n");
         qemu_free (s);
+        return;
     }
     QLIST_INSERT_HEAD (&capture_head, s, entries);
 }
-- 
1.7.1.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] monitor: use after free in do_wav_capture()
  2011-01-21 10:53 [Qemu-devel] [PATCH] monitor: use after free in do_wav_capture() Isaku Yamahata
@ 2011-01-25  8:24 ` Aurelien Jarno
  0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-01-25  8:24 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: qemu-devel

On Fri, Jan 21, 2011 at 07:53:55PM +0900, Isaku Yamahata wrote:
> use after free in do_wav_capture() on the error path.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  monitor.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/monitor.c b/monitor.c
> index d291158..cab5f20 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2511,6 +2511,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
>      if (wav_start_capture (s, path, freq, bits, nchannels)) {
>          monitor_printf(mon, "Faied to add wave capture\n");
>          qemu_free (s);
> +        return;
>      }
>      QLIST_INSERT_HEAD (&capture_head, s, entries);
>  }
> -- 
> 1.7.1.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-25  8:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-21 10:53 [Qemu-devel] [PATCH] monitor: use after free in do_wav_capture() Isaku Yamahata
2011-01-25  8:24 ` Aurelien Jarno

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.